Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OS variables from image.yml and remove ArtifactName template parameter which is always hard coded to 'packages' #44556

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use OS variables from image.yml and remove ArtifactName template parameter which is always hard coded to 'packages' #44556

wants to merge 1 commit into from

Conversation

JimSuplizio
Copy link
Member

This is some cleanup work.

  1. For whatever reason, when eng/pipelines/templates/variables/image.yml was added, the template pipelines weren't updated to use it.
  2. parameters.ArtifactName was hard coded to 'packages' and threaded through different templates. Remove the parameter and just hard code packages. Also, in most cases 'packages' was also just the start of the artifacts name eg. 'packages-signed'.
  3. The azure-sdk-template-bom/pom.xml's change is to update the version so I can test the release.

Fixes: #44548
Fixes: #44550

@JimSuplizio
Use OS variables from image.yml and remove ArtifactName template para…
10a3e63 
…meter which is always hard coded to 'packages'
@JimSuplizio JimSuplizio added the Central-EngSys This issue is owned by the Engineering System team. label Mar 7, 2025
@JimSuplizio JimSuplizio self-assigned this Mar 7, 2025
weshaggard
weshaggard reviewed Mar 7, 2025
View reviewed changes
eng/pipelines/partner-release.yml
@@ -110,8 +110,8 @@ extends:
targetPath: '$(Pipeline.Workspace)/packages-esrp-flattened'

pool:
name: azsdk-pool-mms-win-2022-general
image: azsdk-pool-mms-win-2022-1espt
name: $(WINDOWSPOOL)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC there were some issues with deployment jobs not being able to use variables so do be sure to test the deployment job with this change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that kind of looks like what's going on with an outstanding lack of errors messages or any indication that's the case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard left review comments

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@conniey conniey Awaiting requested review from conniey conniey is a code owner

@lmolkova lmolkova Awaiting requested review from lmolkova lmolkova is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@JimSuplizio JimSuplizio

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Azure SDK EngSys 🤖🧠
Status: 🤔 Triage
Milestone
No milestone
2 participants
@JimSuplizio @weshaggard