Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "PartitionId" is mispelled as "PartionId" in EventHubTriggerInput logs #48460

Open
the-m4a opened this issue Feb 27, 2025 · 4 comments
Open
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Event Hubs issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close.
Milestone

Comments

@the-m4a
Copy link

the-m4a commented Feb 27, 2025

Library name and version

Azure.Messaging.EventHub 6.3.5

Describe the bug

Minor issue only observed in logs:

In the GetTriggerDetails function, the label for the PartitionId is mispelled as "PartionId":

{ "PartionId", context.PartitionId },

The label appears in various messages in App Insights related to the Event Hub Triggers, as well as the customDimensions field.

I am opening this bug entirely because I was trying to put together a query using Partition ID as one of the columns and spent a few minutes wondering why "customDimensions.prop__PartitionId" was showing as empty.

Link to the line:

Expected behavior

The label should be "PartitionId". It appears it has been mispelled for as long as this file has existed in this repo.

Actual behavior

Example output from App Insights, message field:

Image

CustomDimensions field:

Image

Reproduction Steps

Enable App Insights Logging for any Azure function that uses an Event Hub trigger and the Azure.Messaging.EventHub package.

Environment

All environments

@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Event Hubs needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Feb 27, 2025
Copy link

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@jsquire
Copy link
Member

jsquire commented Mar 3, 2025

Hi @the-m4a. Thanks for reaching out and letting us know. You're correct in that the misspelling has been present since the original move to this repository in 2020. That makes it a bit tricky, as a straight fix has a high risk of breaking existing applications that rely on the misspelling. I've opened #48517 which works around that by adding a new member with the correct spelling. I do want to get thoughts from the folks who own the Azure Functions host+platform before moving forward, though, as the extension has no insight nor influence over what Functions does with that data.

@jsquire jsquire added bug This issue requires a change to an existing behavior in the product in order to be resolved. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Mar 3, 2025
@jsquire jsquire modified the milestones: 2025-03, 2025-04 Mar 3, 2025
@jsquire
Copy link
Member

jsquire commented Mar 3, 2025

fixed by #48517 and will be included in our next release. Release timing is unknown at present.

@jsquire jsquire added the issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. label Mar 3, 2025
@github-actions github-actions bot removed the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Mar 3, 2025
Copy link

github-actions bot commented Mar 3, 2025

Hi @the-m4a. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text "/unresolve" to remove the "issue-addressed" label and continue the conversation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Event Hubs issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close.
Projects
None yet
Development

No branches or pull requests

2 participants