Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split MPG related logic into a sub-plugin from Azure plugin #48481

Open
live1206 opened this issue Feb 28, 2025 · 0 comments
Open

Split MPG related logic into a sub-plugin from Azure plugin #48481

live1206 opened this issue Feb 28, 2025 · 0 comments
Assignees
@live1206
Labels
CodeGen Issues that relate to code generation Mgmt This issue is related to a management-plane library.

Comments

@live1206
Copy link
Member

live1206 commented Feb 28, 2025 •
edited
Loading

We are having more and more check of IsAzureArm in Azure plugin, and it grows.

azure-sdk-for-net/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureClientPlugin.cs

Line 56 in 211a881

if (IsAzureArm.Value)

azure-sdk-for-net/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureTypeFactory.cs

Line 116 in 211a881

if (!AzureClientPlugin.Instance.IsAzureArm.Value)

azure-sdk-for-net/eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureOutputLibrary.cs

Line 81 in 211a881

if (AzureClientPlugin.Instance.IsAzureArm.Value == true)

azure-sdk-for-net/eng/packages/http-client-csharp/generator/Azure.Generator/src/Primitives/NewAzureProjectScaffolding.cs

Line 124 in 211a881

AzureClientPlugin.Instance.IsAzureArm.Value == true

It's time to split MPG part out from it with a new sub-plugin called MPGClientPlugin.
The existing AzureClientPlugin holds the logic for DPG.
@live1206 live1206 added CodeGen Issues that relate to code generation Mgmt This issue is related to a management-plane library. labels Feb 28, 2025
@live1206 live1206 self-assigned this Feb 28, 2025
@live1206 live1206 changed the title Split Azure plugin into sub-plugins for DPG and MPG Split MPG related logic into a sub-plugin from Azure plugin Feb 28, 2025
@live1206 live1206 mentioned this issue Mar 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@live1206 live1206

Labels
CodeGen Issues that relate to code generation Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@live1206