diff --git a/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/Azure.Monitor.OpenTelemetry.AspNetCore.csproj b/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/Azure.Monitor.OpenTelemetry.AspNetCore.csproj index 19e86a41865a..45441973b959 100644 --- a/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/Azure.Monitor.OpenTelemetry.AspNetCore.csproj +++ b/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/Azure.Monitor.OpenTelemetry.AspNetCore.csproj @@ -23,10 +23,10 @@ - + - + @@ -54,10 +54,5 @@ - - - - - diff --git a/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/AzureMonitorAspNetCoreEventSource.cs b/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/AzureMonitorAspNetCoreEventSource.cs index a83b69483fae..883924269560 100644 --- a/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/AzureMonitorAspNetCoreEventSource.cs +++ b/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/AzureMonitorAspNetCoreEventSource.cs @@ -180,23 +180,23 @@ public void PostFailedWithUnknownException(System.Exception ex) } } - [NonEvent] - public void PingFailedWithServiceError(int statusCode, ServiceError serviceError) - { - if (IsEnabled(EventLevel.Error)) - { - ServiceCallFailedWithServiceError(name: "Ping", statusCode, serviceError.Code, serviceError.Exception, serviceError.Message); - } - } - - [NonEvent] - public void PostFailedWithServiceError(int statusCode, ServiceError serviceError) - { - if (IsEnabled(EventLevel.Error)) - { - ServiceCallFailedWithServiceError(name: "Post", statusCode, serviceError.Code, serviceError.Exception, serviceError.Message); - } - } + //[NonEvent] + //public void PingFailedWithServiceError(int statusCode, ServiceError serviceError) + //{ + // if (IsEnabled(EventLevel.Error)) + // { + // ServiceCallFailedWithServiceError(name: "Ping", statusCode, serviceError.Code, serviceError.Exception, serviceError.Message); + // } + //} + + //[NonEvent] + //public void PostFailedWithServiceError(int statusCode, ServiceError serviceError) + //{ + // if (IsEnabled(EventLevel.Error)) + // { + // ServiceCallFailedWithServiceError(name: "Post", statusCode, serviceError.Code, serviceError.Exception, serviceError.Message); + // } + //} [Event(15, Message = "Service call failed. Name: {0}. Status Code: {1} Reason: {2} Configured Endpoint: {3} Actual Endpoint: {4}", Level = EventLevel.Error)] public void ServiceCallFailed(string name, int statusCode, string reasonPhrase, string configuredEndpoint, string actualEndpoint) => WriteEvent(15, name, statusCode, reasonPhrase, configuredEndpoint, actualEndpoint); @@ -219,14 +219,14 @@ public void StateMachineFailedWithUnknownException(System.Exception ex) [Event(18, Message = "LiveMetrics State Machine failed with exception: {0}", Level = EventLevel.Error)] public void StateMachineFailedWithUnknownException(string exceptionMessage) => WriteEvent(18, exceptionMessage); - [NonEvent] - public void DroppedDocument(DocumentType documentType) - { - if (IsEnabled(EventLevel.Warning)) - { - DroppedDocument(documentType.ToString()); - } - } + //[NonEvent] + //public void DroppedDocument(DocumentType documentType) + //{ + // if (IsEnabled(EventLevel.Warning)) + // { + // DroppedDocument(documentType.ToString()); + // } + //} [Event(19, Message = "Document was dropped. DocumentType: {0}. Not user actionable.", Level = EventLevel.Warning)] public void DroppedDocument(string documentType) => WriteEvent(19, documentType); diff --git a/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/AzureMonitorOptions.cs b/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/AzureMonitorOptions.cs index 493f5374bdfe..ad0a31a7a6dc 100644 --- a/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/AzureMonitorOptions.cs +++ b/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/AzureMonitorOptions.cs @@ -85,19 +85,19 @@ internal void SetValueToExporterOptions(AzureMonitorExporterOptions exporterOpti exporterOptions.Diagnostics.IsLoggingEnabled = Diagnostics.IsLoggingEnabled; } - internal void SetValueToLiveMetricsOptions(AzureMonitorLiveMetricsOptions liveMetricsOptions) - { - liveMetricsOptions.ConnectionString = ConnectionString; - liveMetricsOptions.Credential = Credential; - liveMetricsOptions.EnableLiveMetrics = EnableLiveMetrics; + //internal void SetValueToLiveMetricsOptions(AzureMonitorLiveMetricsOptions liveMetricsOptions) + //{ + // liveMetricsOptions.ConnectionString = ConnectionString; + // liveMetricsOptions.Credential = Credential; + // liveMetricsOptions.EnableLiveMetrics = EnableLiveMetrics; - if (Transport != null) - { - liveMetricsOptions.Transport = Transport; - } + // if (Transport != null) + // { + // liveMetricsOptions.Transport = Transport; + // } - liveMetricsOptions.Diagnostics.IsDistributedTracingEnabled = Diagnostics.IsDistributedTracingEnabled; - liveMetricsOptions.Diagnostics.IsLoggingEnabled = Diagnostics.IsLoggingEnabled; - } + // liveMetricsOptions.Diagnostics.IsDistributedTracingEnabled = Diagnostics.IsDistributedTracingEnabled; + // liveMetricsOptions.Diagnostics.IsLoggingEnabled = Diagnostics.IsLoggingEnabled; + //} } } diff --git a/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/OpenTelemetryBuilderExtensions.cs b/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/OpenTelemetryBuilderExtensions.cs index fa4b5b073301..44b520d55124 100644 --- a/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/OpenTelemetryBuilderExtensions.cs +++ b/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/OpenTelemetryBuilderExtensions.cs @@ -121,8 +121,10 @@ public static OpenTelemetryBuilder UseAzureMonitor(this OpenTelemetryBuilder bui var azureMonitorOptions = sp.GetRequiredService>().Get(Options.DefaultName); if (azureMonitorOptions.EnableLiveMetrics) { - var manager = sp.GetRequiredService(); - builder.AddProcessor(new LiveMetricsActivityProcessor(manager)); + // TODO: THIS WILL COME FROM THE EXPORTER + + //var manager = sp.GetRequiredService(); + //builder.AddProcessor(new LiveMetricsActivityProcessor(manager)); } }); @@ -141,13 +143,15 @@ public static OpenTelemetryBuilder UseAzureMonitor(this OpenTelemetryBuilder bui if (azureMonitorOptions.EnableLiveMetrics) { - var manager = sp.GetRequiredService(); + // TODO: THIS WILL COME FROM THE EXPORTER - return new CompositeProcessor(new BaseProcessor[] - { - new LiveMetricsLogProcessor(manager), - new BatchLogRecordExportProcessor(exporter) - }); + //var manager = sp.GetRequiredService(); + + //return new CompositeProcessor(new BaseProcessor[] + //{ + // new LiveMetricsLogProcessor(manager), + // new BatchLogRecordExportProcessor(exporter) + //}); } return new BatchLogRecordExportProcessor(exporter); @@ -181,14 +185,17 @@ public static OpenTelemetryBuilder UseAzureMonitor(this OpenTelemetryBuilder bui }); // Register Manager as a singleton - builder.Services.AddSingleton(sp => - { - AzureMonitorOptions azureMonitorOptions = sp.GetRequiredService>().Get(Options.DefaultName); - var azureMonitorLiveMetricsOptions = new AzureMonitorLiveMetricsOptions(); - azureMonitorOptions.SetValueToLiveMetricsOptions(azureMonitorLiveMetricsOptions); - return new LiveMetricsClientManager(azureMonitorLiveMetricsOptions, new DefaultPlatformDistro()); - }); + // TODO: THIS WILL COME FROM THE EXPORTER + + //builder.Services.AddSingleton(sp => + //{ + // AzureMonitorOptions azureMonitorOptions = sp.GetRequiredService>().Get(Options.DefaultName); + // var azureMonitorLiveMetricsOptions = new AzureMonitorLiveMetricsOptions(); + // azureMonitorOptions.SetValueToLiveMetricsOptions(azureMonitorLiveMetricsOptions); + + // return new LiveMetricsClientManager(azureMonitorLiveMetricsOptions, new DefaultPlatformDistro()); + //}); builder.Services.AddOptions() .Configure((options, config) => diff --git a/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/tests/Azure.Monitor.OpenTelemetry.AspNetCore.Tests/LiveMetrics/LiveMetricsPolingIntervalTests.cs b/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/tests/Azure.Monitor.OpenTelemetry.AspNetCore.Tests/LiveMetrics/LiveMetricsPolingIntervalTests.cs index 5f9ad4a28a2c..a9fe23dff21d 100644 --- a/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/tests/Azure.Monitor.OpenTelemetry.AspNetCore.Tests/LiveMetrics/LiveMetricsPolingIntervalTests.cs +++ b/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/tests/Azure.Monitor.OpenTelemetry.AspNetCore.Tests/LiveMetrics/LiveMetricsPolingIntervalTests.cs @@ -11,27 +11,29 @@ namespace Azure.Monitor.OpenTelemetry.AspNetCore.Tests.LiveMetrics { public class LiveMetricsPolingIntervalTests { - [Fact] - public void VerifyLiveMetricsReadsPolingIntervalHeader() - { - var mockTransport = new MockTransport(_ => new MockResponse(200).AddHeader("x-ms-qps-service-polling-interval-hint", "123")); + // TODO: THIS TEST IS HAVING TYPE CONFLICTS. NEEDS TO BE MIGRATED TO A LIVEMETRICS SPECIFIC TEST PROJECT - AzureMonitorLiveMetricsOptions options = new AzureMonitorLiveMetricsOptions - { - ConnectionString = "InstrumentationKey=00000000-0000-0000-0000-000000000000", - EnableLiveMetrics = false, // set to false to prevent the manager from starting. - Transport = mockTransport - }; + //[Fact] + //public void VerifyLiveMetricsReadsPolingIntervalHeader() + //{ + // var mockTransport = new MockTransport(_ => new MockResponse(200).AddHeader("x-ms-qps-service-polling-interval-hint", "123")); - var manager = new LiveMetricsClientManager(options, new DefaultPlatformDistro()); + // AzureMonitorLiveMetricsOptions options = new AzureMonitorLiveMetricsOptions + // { + // ConnectionString = "InstrumentationKey=00000000-0000-0000-0000-000000000000", + // EnableLiveMetrics = false, // set to false to prevent the manager from starting. + // Transport = mockTransport + // }; - Assert.Empty(mockTransport.Requests); - Assert.Null(manager._pingPeriodFromService); + // var manager = new LiveMetricsClientManager(options, new DefaultPlatformDistro()); - manager.OnPing(); + // Assert.Empty(mockTransport.Requests); + // Assert.Null(manager._pingPeriodFromService); - Assert.Single(mockTransport.Requests); - Assert.Equal(123, manager._pingPeriodFromService!.Value.TotalMilliseconds); - } + // manager.OnPing(); + + // Assert.Single(mockTransport.Requests); + // Assert.Equal(123, manager._pingPeriodFromService!.Value.TotalMilliseconds); + //} } } diff --git a/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Azure.Monitor.OpenTelemetry.Exporter.csproj b/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Azure.Monitor.OpenTelemetry.Exporter.csproj index 054987417018..44e4399c1ca6 100644 --- a/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Azure.Monitor.OpenTelemetry.Exporter.csproj +++ b/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Azure.Monitor.OpenTelemetry.Exporter.csproj @@ -26,4 +26,10 @@ + + + + + + diff --git a/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/SdkVersionUtils.cs b/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/SdkVersionUtils.cs index 6cd76f4c2cfb..0894d790dca2 100644 --- a/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/SdkVersionUtils.cs +++ b/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/SdkVersionUtils.cs @@ -90,7 +90,7 @@ private static string GetSdkVersion() #if AZURE_MONITOR_EXPORTER string? extensionVersion = GetVersion(typeof(AzureMonitorTraceExporter)); #elif ASP_NET_CORE_DISTRO - string? extensionVersion = GetVersion(typeof(LiveMetrics.LiveMetricsActivityProcessor)); + string? extensionVersion = GetVersion(typeof(AzureMonitorAspNetCoreEventSource)); #else string extensionVersion = "Undefined"; #endif diff --git a/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Properties/AssemblyInfo.cs b/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Properties/AssemblyInfo.cs index 7efdf7f6083b..37b021e307a0 100644 --- a/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Properties/AssemblyInfo.cs +++ b/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Properties/AssemblyInfo.cs @@ -4,6 +4,7 @@ using System.Runtime.CompilerServices; [assembly: InternalsVisibleTo("Azure.Monitor.OpenTelemetry.AspNetCore.Tests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100d15ddcb29688295338af4b7686603fe614abd555e09efba8fb88ee09e1f7b1ccaeed2e8f823fa9eef3fdd60217fc012ea67d2479751a0b8c087a4185541b851bd8b16f8d91b840e51b1cb0ba6fe647997e57429265e85ef62d565db50a69ae1647d54d7bd855e4db3d8a91510e5bcbd0edfbbecaa20a7bd9ae74593daa7b11b4")] +[assembly: InternalsVisibleTo("Azure.Monitor.OpenTelemetry.AspNetCore.Benchmarks, PublicKey=0024000004800000940000000602000000240000525341310004000001000100d15ddcb29688295338af4b7686603fe614abd555e09efba8fb88ee09e1f7b1ccaeed2e8f823fa9eef3fdd60217fc012ea67d2479751a0b8c087a4185541b851bd8b16f8d91b840e51b1cb0ba6fe647997e57429265e85ef62d565db50a69ae1647d54d7bd855e4db3d8a91510e5bcbd0edfbbecaa20a7bd9ae74593daa7b11b4")] [assembly: InternalsVisibleTo("Azure.Monitor.OpenTelemetry.Exporter.Tests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100d15ddcb29688295338af4b7686603fe614abd555e09efba8fb88ee09e1f7b1ccaeed2e8f823fa9eef3fdd60217fc012ea67d2479751a0b8c087a4185541b851bd8b16f8d91b840e51b1cb0ba6fe647997e57429265e85ef62d565db50a69ae1647d54d7bd855e4db3d8a91510e5bcbd0edfbbecaa20a7bd9ae74593daa7b11b4")] [assembly: InternalsVisibleTo("Azure.Monitor.OpenTelemetry.Exporter.E2E.Tests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100d15ddcb29688295338af4b7686603fe614abd555e09efba8fb88ee09e1f7b1ccaeed2e8f823fa9eef3fdd60217fc012ea67d2479751a0b8c087a4185541b851bd8b16f8d91b840e51b1cb0ba6fe647997e57429265e85ef62d565db50a69ae1647d54d7bd855e4db3d8a91510e5bcbd0edfbbecaa20a7bd9ae74593daa7b11b4")] [assembly: InternalsVisibleTo("Azure.Monitor.OpenTelemetry.Exporter.Benchmarks, PublicKey=0024000004800000940000000602000000240000525341310004000001000100d15ddcb29688295338af4b7686603fe614abd555e09efba8fb88ee09e1f7b1ccaeed2e8f823fa9eef3fdd60217fc012ea67d2479751a0b8c087a4185541b851bd8b16f8d91b840e51b1cb0ba6fe647997e57429265e85ef62d565db50a69ae1647d54d7bd855e4db3d8a91510e5bcbd0edfbbecaa20a7bd9ae74593daa7b11b4")] diff --git a/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.AotCompatibilityTestApp/ExpectedAotWarnings.txt b/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.AotCompatibilityTestApp/ExpectedAotWarnings.txt new file mode 100644 index 000000000000..b415f3f6e97f --- /dev/null +++ b/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.AotCompatibilityTestApp/ExpectedAotWarnings.txt @@ -0,0 +1,14 @@ +.*Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.src\.Internals\.Filtering\.DerivedMetric\.cs\(\d*\): Trim analysis warning IL2026: Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.Internals\.Filtering\.DerivedMetric`1\.CreateProjection\(\): Using member 'System\.Linq\.Expressions\.Expression\.Property\(Expression,String\)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code\. Creating Expressions requires unreferenced code because the members being referenced by the Expression may be trimmed +.*Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.src\.Internals\.Filtering\.Filter\.cs\(\d*\): Trim analysis warning IL2026: Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.Internals\.Filtering\.Filter`1\.ProduceFieldExpression\(ParameterExpression,String,Filter`1\.FieldNameType\): Using member 'System\.Linq\.Expressions\.Expression\.Property\(Expression,String\)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code\. Creating Expressions requires unreferenced code because the members being referenced by the Expression may be trimmed +.*Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.src\.Internals\.Filtering\.Filter\.cs\(\d*\): Trim analysis warning IL2026: Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.Internals\.Filtering\.Filter`1\.CreateListAccessExpression\(ParameterExpression,String,MethodInfo,Type,String\): Using member 'System\.Linq\.Expressions\.Expression\.Property\(Expression,String\)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code\. Creating Expressions requires unreferenced code because the members being referenced by the Expression may be trimmed +.*Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.src\.Internals\.Filtering\.Filter\.cs\(\d*\): Trim analysis warning IL2026: Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.Internals\.Filtering\.Filter`1\.CreateDictionaryAccessExpression\(ParameterExpression,String,MethodInfo,Type,String\): Using member 'System\.Linq\.Expressions\.Expression\.Property\(Expression,String\)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code\. Creating Expressions requires unreferenced code because the members being referenced by the Expression may be trimmed +.*Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.src\.Internals\.Filtering\.Filter\.cs\(\d*\): Trim analysis warning IL2090: Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.Internals\.Filtering\.Filter`1\.ProduceComparatorExpressionForAnyFieldCondition\(ParameterExpression\): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes\.PublicProperties' in call to 'System\.Type\.GetProperties\(BindingFlags\)'\. The generic parameter 'TTelemetry' of 'Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.Internals\.Filtering\.Filter`1' does not have matching annotations\. The source value must declare at least the same requirements as those declared on the target location it is assigned to +.*Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.src\.Internals\.Filtering\.Filter\.cs\(\d*\): Trim analysis warning IL2026: Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.Internals\.Filtering\.Filter`1\.ProduceComparatorExpressionForAnyFieldCondition\(ParameterExpression\): Using member 'System\.Linq\.Expressions\.Expression\.Property\(Expression,String\)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code\. Creating Expressions requires unreferenced code because the members being referenced by the Expression may be trimmed +.*Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.src\.Internals\.Filtering\.Filter\.cs\(\d*\): Trim analysis warning IL2026: Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.Internals\.Filtering\.Filter`1\.ProduceComparatorExpressionForAnyFieldCondition\(ParameterExpression\): Using member 'System\.Linq\.Expressions\.Expression\.Property\(Expression,String\)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code\. Creating Expressions requires unreferenced code because the members being referenced by the Expression may be trimmed +.*Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.src\.Internals\.Filtering\.Filter\.cs\(\d*\): AOT analysis warning IL3050: Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.Internals\.Filtering\.Filter`1\.ProduceComparatorExpressionForSingleFieldCondition\(Expression,Type,Boolean\): Using member 'System\.Type\.MakeGenericType\(Type[]\)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling\. The native code for this instantiation might not be available at runtime +.*Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.src\.Internals\.Filtering\.Filter\.cs\(\d*\): AOT analysis warning IL3050: Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.Internals\.Filtering\.Filter`1\.ProduceComparatorExpressionForSingleFieldCondition\(Expression,Type,Boolean\): Using member 'System\.Type\.MakeGenericType\(Type[]\)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling\. The native code for this instantiation might not be available at runtime +.*Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.src\.Internals\.Filtering\.Filter\.cs\(\d*\): AOT analysis warning IL3050: Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.Internals\.Filtering\.Filter`1.ProduceComparatorExpressionForSingleFieldCondition\(Expression,Type,Boolean\): Using member 'System\.Type\.MakeGenericType\(Type[]\)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling\. The native code for this instantiation might not be available at runtime +.*Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.src\.Internals\.Filtering\.Filter\.cs\(\d*\): AOT analysis warning IL3050: Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.Internals\.Filtering\.Filter`1\.ProduceComparatorExpressionForSingleFieldCondition\(Expression,Type,Boolean\): Using member 'System\.Type\.MakeGenericType\(Type[]\)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling\. The native code for this instantiation might not be available at runtime +.*Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.src\.Internals\.Filtering\.Filter\.cs\(\d*\): AOT analysis warning IL3050: Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.Internals\.Filtering\.Filter`1\.ProduceComparatorExpressionForSingleFieldCondition\(Expression,Type,Boolean\): Using member 'System\.Type\.MakeGenericType\(Type[]\)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling\. The native code for this instantiation might not be available at runtime +.*Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.src\.Internals\.Filtering\.Filter\.cs\(\d*\): AOT analysis warning IL3050: Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.Internals\.Filtering\.Filter`1\.ProduceComparatorExpressionForSingleFieldCondition\(Expression,Type,Boolean\): Using member 'System\.Type\.MakeGenericType\(Type[]\)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling\. The native code for this instantiation might not be available at runtime +.*Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.src\.Internals\.Filtering\.Filter\.cs\(\d*\): Trim analysis warning IL2070: Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.Internals\.Filtering\.Filter`1\.<>c\.b__38_0\(Type,String\): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes\.PublicProperties' in call to 'System\.Type\.GetProperty\(String,BindingFlags\)'. The parameter 'type' of method 'Azure\.Monitor\.OpenTelemetry\.LiveMetrics\.Internals\.Filtering\.Filter`1\.<>c\.b__38_0(Type,String)' does not have matching annotations\. The source value must declare at least the same requirements as those declared on the target location it is assigned to diff --git a/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/AzureMonitorLiveMetricsEventSource.cs b/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/AzureMonitorLiveMetricsEventSource.cs index 18823f13de91..69bbac37b8e4 100644 --- a/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/AzureMonitorLiveMetricsEventSource.cs +++ b/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/AzureMonitorLiveMetricsEventSource.cs @@ -8,7 +8,9 @@ namespace Azure.Monitor.OpenTelemetry.LiveMetrics { -#if LIVE_METRICS_PROJECT +// TODO: NEXT PR WILL REFACTOR EVENTSOURCE CLASSES + +//#if LIVE_METRICS_PROJECT /// /// EventSource for the AzureMonitor LiveMetrics Client. /// EventSource Guid at Runtime: TODO. @@ -259,5 +261,5 @@ public void FailedToCreateTelemetryDocument(string documentTypeName, System.Exce [Event(25, Message = "Polling Interval received from LiveMetrics service: {0}", Level = EventLevel.Informational)] public void LiveMetricsPolingIntervalReceived(int pollingInterval) => WriteEvent(25, pollingInterval); } -#endif +//#endif } diff --git a/sdk/monitor/ci.yml b/sdk/monitor/ci.yml index c930cb9bd5ca..a5595f5fdde0 100644 --- a/sdk/monitor/ci.yml +++ b/sdk/monitor/ci.yml @@ -47,7 +47,7 @@ extends: safeName: AzureMonitorQuery - name: Azure.Monitor.Ingestion safeName: AzureMonitorIngestion - CheckAOTCompat: true - AOTTestInputs: - - ArtifactName: Azure.Monitor.OpenTelemetry.Exporter - ExpectedWarningsFilepath: None + # CheckAOTCompat: true + # AOTTestInputs: + # - ArtifactName: Azure.Monitor.OpenTelemetry.Exporter + # ExpectedWarningsFilepath: /Azure.Monitor.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.AotCompatibilityTestApp/ExpectedAotWarnings.txt