Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump versions and simplify dependencies #2294

Merged
merged 6 commits into from
Mar 7, 2025
Merged

Bump versions and simplify dependencies #2294

merged 6 commits into from
Mar 7, 2025

Conversation

heaths
Copy link
Member

@heaths heaths commented Mar 6, 2025

At least in the workspace Cargo.toml, crates that should only ever be in dev-dependencies can have a path and no version. This makes referencing them easier, but I'd be fine with crates taking a local path as well.

@heaths
Bump versions and simplify dependencies
f7ed968 
At least in the workspace `Cargo.toml`, crates that should only ever be in `dev-dependencies` can have a `path` and no `version`. This makes referencing them easier, but I'd be fine with crates taking a local `path` as well.
@heaths heaths requested review from hallipr and analogrelay March 6, 2025 20:37
@github-actions github-actions bot added Azure.Core The azure_core crate Azure.Identity The azure_identity crate Cosmos The azure_cosmos crate Storage Storage Service (Queues, Blobs, Files) labels Mar 6, 2025
hallipr
hallipr reviewed Mar 6, 2025
View reviewed changes
@heaths heaths mentioned this pull request Mar 6, 2025
Merged
@heaths
Copy link
Member Author

heaths commented Mar 6, 2025

What's breaking the MSRV builds is likely a change to rustc/cargo that check crates' rust-version better than before:

error: rustc 1.80.1 is not supported by the following packages:
  [email protected] requires rustc 1.81
  [email protected] requires rustc 1.81
Either upgrade rustc or select compatible dependency versions with
`cargo update <name>@<current-ver> --precise <compatible-ver>`
where `<compatible-ver>` is the latest version supporting rustc 1.80.1

Running cargo tree -i on these dependencies show they are coming in from url...which further adds weight to replacing it with our own. I'll have to see how I can either avoid these dependencies (they're used for IDNA, which is unlikely we'll ever need) or...I don't know.

@Manishearth Manishearth mentioned this pull request Mar 7, 2025
Closed
@heaths
Use specific versions of litemap, zerofrom
ce84570 
Only in the `rust - pullrequest` pipelines was it seemingly ignoring our `Cargo.lock` file and using newer versions of these crates that upgraded their MSRV.
This explicitly adds the versions we had in our `Cargo.lock` file to see if that passes the PR builds. We may still want to pass `--locked` in both PR and CI builds;
however, oddly, the CI builds are passing even after a manual run I just kicked off an hour or so ago.
@heaths heaths mentioned this pull request Mar 7, 2025
Closed
@heaths heaths requested a review from weshaggard as a code owner March 7, 2025 01:12
@heaths heaths linked an issue Mar 7, 2025 that may be closed by this pull request
Our CI and PR builds should run with --locked #2300
Closed
@heaths
Fix typespec_macro compilation tests
cebe690 
The Cargo.lock file wasn't committed; still, don't know why it just started failing in PR but still not in CI builds.
@heaths heaths removed a link to an issue Mar 7, 2025
Our CI and PR builds should run with --locked #2300
Closed
@heaths
Remove --locked from build and test commands
7f0dc93 
We'll decide as part of Azure#2300. Kept it in `package` and `publish` to make sure we ship what we intended.
@heaths heaths enabled auto-merge (squash) March 7, 2025 01:54
@heaths heaths disabled auto-merge March 7, 2025 02:12
@heaths heaths merged commit fedaba3 into Azure:main Mar 7, 2025
17 checks passed
@heaths heaths deleted the bump-versions branch March 7, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hallipr hallipr hallipr left review comments

@LarryOsterman LarryOsterman LarryOsterman approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay analogrelay is a code owner

@Pilchie Pilchie Awaiting requested review from Pilchie Pilchie is a code owner

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@tvaron3 tvaron3 Awaiting requested review from tvaron3 tvaron3 is a code owner

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@kundadebdatta kundadebdatta Awaiting requested review from kundadebdatta kundadebdatta is a code owner

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@JeffreyRichter JeffreyRichter Awaiting requested review from JeffreyRichter JeffreyRichter is a code owner

@vincenttran-msft vincenttran-msft Awaiting requested review from vincenttran-msft vincenttran-msft is a code owner

@jalauzon-msft jalauzon-msft Awaiting requested review from jalauzon-msft jalauzon-msft is a code owner

@ronniegeraghty ronniegeraghty Awaiting requested review from ronniegeraghty ronniegeraghty is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

Assignees
No one assigned
Labels
Azure.Core The azure_core crate Azure.Identity The azure_identity crate Cosmos The azure_cosmos crate Storage Storage Service (Queues, Blobs, Files)
Projects
Azure Identity SDK Improvements
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heaths @hallipr @LarryOsterman