Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a PR template for SDK configuration updates only #9384

Open
maririos opened this issue Nov 14, 2024 · 0 comments
Open

Create a PR template for SDK configuration updates only #9384

maririos opened this issue Nov 14, 2024 · 0 comments
Assignees
@maririos
Labels
Central-EngSys This issue is owned by the Engineering System team. Engagement Experience

Comments

@maririos
Copy link
Member

The specs repo has 2 pipelines for opening PRs: for changes on data or management plane on their API. If a user needs to change something about their SDK configuration (i.e. package name) they need to open a new PR. In this case both templates won't apply.
We should add a template for a third option that contains:

  • Confirmation that only changes to SDK configuration are happening
  • Documentation to how to make the SDK configuration changes (for OpenAPI and TypeSpec specs)
  • Process information: no need for an official review. SDK pipelines will validate the changes and anyone with write permissions can approve and merge the PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maririos maririos

Labels
Central-EngSys This issue is owned by the Engineering System team. Engagement Experience
Projects
Azure SDK EngSys 🚢🎉
Status: 🤔 Triage
Engagement Experience
Status: New
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maririos