Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default authentication validation for ARM cases in mockapi.ts #617

Open
MaryGao opened this issue Jul 1, 2024 · 2 comments
Open

Add default authentication validation for ARM cases in mockapi.ts #617

MaryGao opened this issue Jul 1, 2024 · 2 comments
Assignees

Comments

@MaryGao
Copy link
Member

MaryGao commented Jul 1, 2024

In typespec-azure-resource-manager it would directly add the defulat outh2 for ARM spec. It may introduce a token credential for some languages. We should validate this token for ARM cases in mockapi.ts.

https://github.com/Azure/typespec-azure/blob/54567f763257300e64603091659d282072631d2a/packages/typespec-azure-resource-manager/src/namespace.ts#L199-L213

@tadelesh
Copy link
Member

tadelesh commented Jul 1, 2024

i believe current test already use the decorator and has the auth definition:

@MaryGao MaryGao changed the title Add default authentication for ARM cases Add default authentication validation for ARM cases in mockapi.ts Jul 1, 2024
@MaryGao MaryGao self-assigned this Jul 1, 2024
@XiaofeiCao
Copy link
Contributor

Wonder if it's necessary. The acquired token can only be mocked by each client, not through normal flow(e.g. ClientSecret or Azure CLI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants