From 6ca2577da59d0a718051d75da8762b1d4b60ec98 Mon Sep 17 00:00:00 2001 From: Heinrich Gantenbein <6719941+techlake@users.noreply.github.com> Date: Thu, 25 Jan 2024 19:00:25 -0600 Subject: [PATCH] Improved warnings for missing Policies in CSV file (#465) --- Scripts/Helpers/Build-AssignmentDefinitionNode.ps1 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Scripts/Helpers/Build-AssignmentDefinitionNode.ps1 b/Scripts/Helpers/Build-AssignmentDefinitionNode.ps1 index d25f3a76..f4be01cc 100644 --- a/Scripts/Helpers/Build-AssignmentDefinitionNode.ps1 +++ b/Scripts/Helpers/Build-AssignmentDefinitionNode.ps1 @@ -233,7 +233,7 @@ function Build-AssignmentDefinitionNode { # Ignore empty lines with a warning $name = $row.name if ($null -eq $name -or $name -eq "") { - Write-Warning " Node $($nodeName): CSV parameterFile '$parameterFileName' has an empty row." + Write-Verbose " Node $($nodeName): CSV parameterFile '$parameterFileName' has an empty row." continue } @@ -264,8 +264,8 @@ function Build-AssignmentDefinitionNode { } else { $flatPolicyEntry = $flatPolicyList.$flatPolicyEntryKey - if ($flatPolicyEntry.isEffectParameterized) { - # Complain only about Policies with parameterized effect value + if ($VerbosePreference -eq "Continue" -or ($flatPolicyEntry.effectDefault -ne "Manual" -and $flatPolicyEntry.effectDefault -ne "Disabled")) { + # Complain only about Policies NOT with Manual or Disabled effect default or when Verbose is on if ($flatPolicyEntry.referencePath) { $null = $missingInCsv.Add("$($flatPolicyEntry.displayName) ($($flatPolicyEntry.name) -- $($flatPolicyEntry.referencePath))") }