Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALZ Defaults Inconsistency #867

Open
jeremiahhoward opened this issue Jan 31, 2025 · 1 comment
Open

ALZ Defaults Inconsistency #867

jeremiahhoward opened this issue Jan 31, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@jeremiahhoward
Copy link
Member

Describe the bug
Inconsistent assignment default values between tools:
Lack of feature parity between Sync-AlzPolicies and Export-PolicyToEpac. The default values are not part of the policySet definitions, and this caused the gap. Sync-AlzPolicies gathers data beyond the policySetDefinition, and Export-PolicyToEpac does not.

To Reproduce
This can be reproduced by comparing the export of Enforce-ALZ-Sandbox and reviewing the listOfResourceTypesNotAllowed parameter default configuration vs the default configuration produced by Sync-AlzPolicies. When reviewing the policySetDefinition, Export-PolicyToEpac reproduces the configured default effect.

Expected behavior
Sync-AlzPolicies adds to the default values in a way that should be reproduced in the Export-PolicyToEpac effect for ALZ custom definitions (no advantage for built-in).

EPAC Version
Version of EPAC module you are using.

IDEALLY ALZ team will improve consistency between definition and the additional recommendations to improve consistency universally.

@jeremiahhoward jeremiahhoward added the bug Something isn't working label Jan 31, 2025
@krallsm
Copy link

krallsm commented Feb 19, 2025

Shoot, sorry, I didn't realize one of the maintainers had already opened up an issue on this when I posted. Here's my summary of the same issue. #886

Feel free to close mine in favor of yours, but perhaps my summary can also help with some of the changes needed for improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants