[Bug]: getAllModels returns models with empty names for Azure Core types

[srnagar]

Describe the bug

When generating from ManufacturingDataSolution.Copilot spec, getAllModels returns a couple of models with no names that are coming from Azure.Core.

Workaround is to use getAllModels(this.sdkContext).filter((model) => !isAzureCoreModel(model));

Reproduction

Run tsp compile <path-to-mds-copilot-spec>/main.tsp and inspect the response of getAllModels() call.

Checklist

• Follow our Code of Conduct
• Check that this issue is about the Azure libraries for typespec. For bug in the typespec language or core libraries file it in the TypeSpec repo
• Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
• The provided reproduction is a minimal reproducible example of the bug.

[weidongxu-microsoft]

Yes, we got 2 model/file without a name. I will need help from TCGC.

The model seems from sdkMethod.lroMetadata.finalResponse

[weidongxu-microsoft]

playground to reproduce

It is model Instruction + @header operationLocation

However, I think @header operationLocation should not be in finalResponse. It is an indicator for polling.

Also the @pollingOperation would actually change the finalResponse, which is a bit weird.

[weidongxu-microsoft]

The LRO template is a PATCH, which is against guideline in Azure
https://github.com/Azure/azure-rest-api-specs/pull/33052/files#r1984403422

However, whatever the cause, I'd expect TCGC provides a reasonable name. (even if just LroResposne, LroResponse1...)