azure-http-specs, validate orphan model serializable #2318
Merged
+49
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/azure-http-specs/specs/azure/client-generator-core/usage/main.tsp
Show resolved
Hide resolved
|
All changed packages have been documented.
Show changes
|
packages/azure-http-specs/specs/azure/client-generator-core/usage/main.tsp
Show resolved
Hide resolved
|
You can try these changes here
|
tadelesh
reviewed
Mar 6, 2025
packages/azure-http-specs/specs/azure/client-generator-core/usage/main.tsp
Show resolved
Hide resolved
weidongxu-microsoft
requested review from
iscai-msft,
lmazuel,
m-nash,
joheredi,
srnagar,
jhendrixMSFT,
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
XiaofeiCao
approved these changes
Mar 10, 2025
tadelesh
approved these changes
Mar 10, 2025
weidongxu-microsoft
deleted the
azure-http-specs_validate-orphan-model-serializable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, we want to verify that an orphan model is by default serializable as JSON.
Since there were an existing test on orphan model, I just enhanced it and added an operation to verify the serialization.