New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canUseDom is a function but is being used as a boolean #44

Open

WilliamPriorielloGarda opened this issue Feb 19, 2024 · 1 comment

WilliamPriorielloGarda commented Feb 19, 2024

canUseDom is a function defined here https://github.com/B3nnyL/react-zendesk/blob/master/src/index.js#L4

However, you are using it as a boolean in if statements here: https://github.com/B3nnyL/react-zendesk/blob/master/src/index.js#L47
and here https://github.com/B3nnyL/react-zendesk/blob/master/src/index.js#L55

This has the effect of always being truthy. If the function is necessary, then call it. If it's not necessary, it should be removed.

dartess commented Mar 14, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment