add phpmd

Author: arkadiusjonczek

composer.json

@@ -21,6 +21,7 @@
     },
     "require-dev": {
         "php": ">=5.3 <8.0",
+        "phpmd/phpmd": "2.4.*",
         "phpunit/phpunit": "^4.8",
         "squizlabs/php_codesniffer": "^2.9"
     },
@@ -36,9 +37,15 @@
     },
     "scripts": {
         "test": "vendor/bin/phpunit",
-        "cs": "vendor/bin/phpcs src tests"
+        "cs": "vendor/bin/phpcs",
+        "md": "vendor/bin/phpmd src,tests text phpmd.xml.dist",
+        "test:full": [
+            "composer test",
+            "composer cs",
+            "composer md"
+        ]
     },
     "config": {
       "sort-packages": true
     }
-}
+}

phpcs.xml.dist

@@ -1,8 +1,12 @@
 <?xml version="1.0" encoding="UTF-8"?>
+
 <ruleset name="babymarkt/deepl-php-lib">
     <description>The coding standard of deepl-php-lib package</description>
-    <arg value="p" />
 
+    <file>src</file>
+    <file>tests</file>
+
+    <arg value="p" />
     <arg name="colors" />
     <arg value="s" />
 

phpmd.xml.dist

@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+
+<ruleset name="deepl-php-lib ruleset"
+         xmlns="http://pmd.sf.net/ruleset/1.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 http://pmd.sf.net/ruleset_xml_schema.xsd"
+         xsi:noNamespaceSchemaLocation="http://pmd.sf.net/ruleset_xml_schema.xsd"
+>
+    <description>PHPMD Rules for deepl-php-lib</description>
+
+    <rule ref="rulesets/cleancode.xml" />
+    <rule ref="rulesets/codesize.xml" />
+    <rule ref="rulesets/controversial.xml" />
+    <rule ref="rulesets/design.xml" />
+    <rule ref="rulesets/naming.xml" />
+    <rule ref="rulesets/unusedcode.xml" />
+</ruleset>

src/DeepL.php

@@ -175,9 +175,9 @@ public function translate(
             throw new DeepLException('No translations found.');
         } elseif ($translationsCount == 1) {
             return $translationsArray['translations'][0]['text'];
-        } else {
-            return $translationsArray['translations'];
         }
+
+        return $translationsArray['translations'];
     }
 
     /**
@@ -298,16 +298,16 @@ protected function request($url, $body)
 
         $response = curl_exec($this->curl);
 
-        if (!curl_errno($this->curl)) {
-            $httpCode = curl_getinfo($this->curl, CURLINFO_HTTP_CODE);
-
-            if ($httpCode != 200 && array_key_exists($httpCode, $this->errorCodes)) {
-                throw new DeepLException($this->errorCodes[$httpCode], $httpCode);
-            }
-        } else {
+        if (curl_errno($this->curl)) {
             throw new DeepLException('There was a cURL Request Error.');
         }
 
+        $httpCode = curl_getinfo($this->curl, CURLINFO_HTTP_CODE);
+
+        if ($httpCode != 200 && array_key_exists($httpCode, $this->errorCodes)) {
+            throw new DeepLException($this->errorCodes[$httpCode], $httpCode);
+        }
+
         $translationsArray = json_decode($response, true);
 
         if (!$translationsArray) {

tests/DeepLTest.php

@@ -2,10 +2,13 @@
 
 namespace BabyMarkt\DeepL;
 
+use ReflectionClass;
+
 /**
  * Class DeepLTest
  *
  * @package BabyMarkt\DeepL
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
  */
 class DeepLTest extends \PHPUnit_Framework_TestCase
 {
@@ -23,7 +26,9 @@ public static function setUpBeforeClass()
     {
         parent::setUpBeforeClass();
 
-        if (($authKey = getenv('DEEPL_AUTH_KEY')) === false) {
+        $authKey = getenv('DEEPL_AUTH_KEY');
+
+        if ($authKey === false) {
             return;
         }
 
@@ -42,7 +47,7 @@ public static function setUpBeforeClass()
      */
     protected static function getMethod($className, $methodName)
     {
-        $class = new \ReflectionClass($className);
+        $class = new ReflectionClass($className);
         $method = $class->getMethod($methodName);
         $method->setAccessible(true);
 
@@ -253,6 +258,6 @@ public function testTranslateException()
 
         $this->setExpectedException('\BabyMarkt\DeepL\DeepLException');
 
-        $translatedText = $deepl->translate($germanText);
+        $deepl->translate($germanText);
     }
 }