Skip to content

Confusing input for the parallel all node. #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robojan opened this issue Apr 18, 2025 · 0 comments
Open

Confusing input for the parallel all node. #966

robojan opened this issue Apr 18, 2025 · 0 comments

Comments

@robojan
Copy link

robojan commented Apr 18, 2025

The parallel all node has an input named "max_failures". This input is described as "If the number of children returning FAILURE exceeds this value, ParallelAll returns FAILURE"

From the name and description I would expect that the node returns failure if the number of children failures > max_failures. But it is implemented as >=.

I feel that changing the behavior would be a massive breaking change as suddenly the failure condition changes. So maybe we change the input to a better name and description.

Similarly, I could not find documentation for this node. It would be great if this is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant