[Fix] Cache - Avoiding expensive operations when cache isn't available #15182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing is disabled - Moved cache availability checks before expensive operations to improve performance for non-cached requests - Updated client code to handle None responses from caching handler
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Fixed `TypeError: typing.Any cannot be used with isinstance()` that was occurring in the caching handler when checking cached streaming responses. The issue was caused by CustomStreamWrapper being aliased to `typing.Any` at runtime through the TYPE_CHECKING conditional import pattern. When the code attempted to use isinstance(cached_result, CustomStreamWrapper) at lines 222 and 338, it failed because Python's isinstance() cannot be used with typing.Any. Solution: Import CustomStreamWrapper at runtime separately from the TYPE_CHECKING block, while keeping a type alias for static type checking. This allows isinstance checks to work properly while maintaining type hints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
[Fix] Cache - Avoiding expensive operations when cache isn't available
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🧹 Refactoring
Changes
Performance Gains
With DB
Before
After
With DB + Redis
Before
After