Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rlibigraph #3725

Open
11 tasks done
LTLA opened this issue Feb 7, 2025 · 12 comments
Open
11 tasks done

Rlibigraph #3725

LTLA opened this issue Feb 7, 2025 · 12 comments
Assignees
Labels
2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place ABNORMAL WARNINGS

Comments

@LTLA
Copy link

LTLA commented Feb 7, 2025

Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

  • I understand that by submitting my package to Bioconductor,
    the package source and all review commentary are visible to the
    general public.

  • I have read the Bioconductor Package Submission
    instructions. My package is consistent with the Bioconductor
    Package Guidelines.

  • I understand Bioconductor Package Naming Policy and acknowledge
    Bioconductor may retain use of package name.

  • I understand that a minimum requirement for package acceptance
    is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
    Passing these checks does not result in automatic acceptance. The
    package will then undergo a formal review and recommendations for
    acceptance regarding other Bioconductor standards will be addressed.

  • My package addresses statistical or bioinformatic issues related
    to the analysis and comprehension of high throughput genomic data.

  • I am committed to the long-term maintenance of my package. This
    includes monitoring the support site for issues that users may
    have, subscribing to the bioc-devel mailing list to stay aware
    of developments in the Bioconductor community, responding promptly
    to requests for updates from the Core team in response to changes in
    R or underlying software.

  • I understand it is my responsibility to maintain a valid, active
    maintainer email in the DESCRIPTION of my package. This email should allow
    emails from [email protected] and [email protected] to allow
    automatic notifications from the Bioconductor team concerning my package.

  • I am familiar with the Bioconductor code of conduct and
    agree to abide by it.

I am familiar with the essential aspects of Bioconductor software
management, including:

  • The 'devel' branch for new packages and features.
  • The stable 'release' branch, made available every six
    months, for bug fixes.
  • Bioconductor version control using Git
    (optionally via GitHub).

For questions/help about the submission process, including questions about
the output of the automatic reports generated by the SPB (Single Package
Builder), please use the #package-submission channel of our Community Slack.
Follow the link on the home page of the Bioconductor website to sign up.

@bioc-issue-bot
Copy link
Collaborator

Hi @LTLA

Thanks for submitting your package. We are taking a quick
look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: Rlibigraph
Type: Package
Version: 0.99.0
Date: 2025-02-06
Title: igraph library as an R package
License: GPL-3
Authors@R: person("Aaron", "Lun", role=c("cre", "aut"), email="[email protected]")
Description:
    Vendors the igraph source code and builds it into a static library.
    Other Bioconductor packages can link to libigraph.a in their own C/C++ code.
    This is particularly useful for packages wrapping C/C++ libraries that depend on the igraph C library
    and cannot be easily adapted to use the canonical R bindings to igraph.
LinkingTo:
    biocmake 
Suggests:
    BiocStyle,
    knitr,
    rmarkdown,
    testthat
VignetteBuilder: knitr
biocViews:
    Clustering,
    GraphAndNetwork
URL: https://github.com/libscran/Rlibigraph
BugReports: https://github.com/libscran/Rlibigraph/issues
Encoding: UTF-8
RoxygenNote: 7.3.2

@bioc-issue-bot bioc-issue-bot added the 1. awaiting moderation submitted and waiting clearance to access resources label Feb 7, 2025
@vjcitn
Copy link
Collaborator

vjcitn commented Feb 21, 2025

Hi -- I remember checking this package out as a client of biocmake. Do you also have
a package that uses this one? Some questions have arisen about how to categorize and
review these deep infrastructure packages, noting the similarity to Rhtslib and Rhdf5lib.
There was a suggestion that this R*lib nomenclature be adopted if possible.

@LTLA
Copy link
Author

LTLA commented Feb 22, 2025

scrapper intends to use this to replace the calls to R-igraph, as discussed in #3536.

I don't mind renaming it to Rigraphlib if that is the way to go.

@vjcitn
Copy link
Collaborator

vjcitn commented Feb 22, 2025

I think using the R*lib naming scheme would be appreciated. Do you have a branch in scrapper that uses this package's code? Let us know as that will be a part of evaluating this submission.

@LTLA
Copy link
Author

LTLA commented Feb 23, 2025

Done with the name change.

See the libigraph branch at https://github.com/libscran/scrapper. Haven't repaired the tests yet but the examples work well enough.

@vjcitn
Copy link
Collaborator

vjcitn commented Feb 23, 2025

Yes, I had no trouble installing and building vignette for the libigraph branch of scrapper after installing Rigraphlib package on linux. So @lshep I think github.com/libscran/Rigraphlib (name change implemented) can be brought in for review, not sure if scrapper should function as a related package in the spb/review process. @hpages your input is welcome also.

@hpages
Copy link
Contributor

hpages commented Feb 23, 2025

In the DESCRIPTION file:

This is particularly useful for packages wrapping C/C++ libraries that depend on the igraph C library and cannot be easily adapted to use the canonical R bindings to igraph.

@LTLA I find the second part of the sentence a little bit cryptic. Is "the canonical R bindings to igraph" the igraph R package? Maybe try to clarify what you mean by "cannot be easily adapted to use the canonical R bindings to igraph". Thanks

@lshep You can assign the package to me if you want.

@lshep lshep added the pre-check passed pre-review performed and ready to be added to git label Feb 24, 2025
@bioc-issue-bot
Copy link
Collaborator

Your package has been added to git.bioconductor.org to continue the
pre-review process. A build report will be posted shortly. Please
fix any ERROR and WARNING in the build report before a reviewer is
assigned or provide a justification on why you feel the ERROR or
WARNING should be granted an exception.

IMPORTANT: Please read this documentation for setting
up remotes to push to git.bioconductor.org. All changes should be
pushed to git.bioconductor.org moving forward. It is required to push a
version bump to git.bioconductor.org to trigger a new build report.

Bioconductor utilized your github ssh-keys for git.bioconductor.org
access. To manage keys and future access you may want to active your
Bioconductor Git Credentials Account

@bioc-issue-bot bioc-issue-bot added pre-review on bioconductor git and access to on demand build but not assigned reviewer until build report clean and removed 1. awaiting moderation submitted and waiting clearance to access resources pre-check passed pre-review performed and ready to be added to git labels Feb 24, 2025
@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ABNORMAL".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/Rlibigraph to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@lshep
Copy link
Contributor

lshep commented Feb 24, 2025

sorry had to do with the renaming. I just kicked off a new build and should have a new report shortly

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "WARNINGS".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
Linux (Ubuntu 24.04.1 LTS): Rigraphlib_0.99.1.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/Rigraphlib to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@lshep lshep added 2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place and removed pre-review on bioconductor git and access to on demand build but not assigned reviewer until build report clean labels Feb 25, 2025
@bioc-issue-bot
Copy link
Collaborator

A reviewer has been assigned to your package for an indepth review.
Please respond accordingly to any further comments from the reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place ABNORMAL WARNINGS
Projects
None yet
Development

No branches or pull requests

5 participants