Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pathMED #3732

Open
11 tasks done
jordimartorell opened this issue Feb 17, 2025 · 3 comments
Open
11 tasks done

pathMED #3732

jordimartorell opened this issue Feb 17, 2025 · 3 comments
Labels
1. awaiting moderation submitted and waiting clearance to access resources 3d. needs interop Package must explicitly use Bioconductor structures and methods 3e. pending pre-review changes review has indicated blocking concern that needs attention

Comments

@jordimartorell
Copy link

Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

  • I understand that by submitting my package to Bioconductor,
    the package source and all review commentary are visible to the
    general public.

  • I have read the Bioconductor Package Submission
    instructions. My package is consistent with the Bioconductor
    Package Guidelines.

  • I understand Bioconductor Package Naming Policy and acknowledge
    Bioconductor may retain use of package name.

  • I understand that a minimum requirement for package acceptance
    is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
    Passing these checks does not result in automatic acceptance. The
    package will then undergo a formal review and recommendations for
    acceptance regarding other Bioconductor standards will be addressed.

  • My package addresses statistical or bioinformatic issues related
    to the analysis and comprehension of high throughput genomic data.

  • I am committed to the long-term maintenance of my package. This
    includes monitoring the support site for issues that users may
    have, subscribing to the bioc-devel mailing list to stay aware
    of developments in the Bioconductor community, responding promptly
    to requests for updates from the Core team in response to changes in
    R or underlying software.

  • I understand it is my responsibility to maintain a valid, active
    maintainer email in the DESCRIPTION of my package. This email should allow
    emails from [email protected] and [email protected] to allow
    automatic notifications from the Bioconductor team concerning my package.

  • I am familiar with the Bioconductor code of conduct and
    agree to abide by it.

I am familiar with the essential aspects of Bioconductor software
management, including:

  • The 'devel' branch for new packages and features.
  • The stable 'release' branch, made available every six
    months, for bug fixes.
  • Bioconductor version control using Git
    (optionally via GitHub).

For questions/help about the submission process, including questions about
the output of the automatic reports generated by the SPB (Single Package
Builder), please use the #package-submission channel of our Community Slack.
Follow the link on the home page of the Bioconductor website to sign up.

@bioc-issue-bot
Copy link
Collaborator

Hi @jordimartorell

Thanks for submitting your package. We are taking a quick
look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: pathMED
Type: Package
Title: Scoring Personalized Molecular Portraits
Version: 0.99.0
Authors@R: c(person("Jordi", "Martorell-Marugán", email="[email protected]", role=c("cre", "aut"), comment = c(ORCID = "0000-0002-5186-0735")),
  person("Daniel", "Toro-Domínguez", email="[email protected]", role=c("aut"), comment = c(ORCID = "0000-0001-8440-312X")),
  person("Raúl", "López-Domínguez", email="[email protected]", role=c("aut"), comment = c(ORCID = "0000-0001-8634-117X")),
  person("Iván", "Ellson", email="[email protected]", role=c("aut"), comment = c(ORCID = "0000-0001-6307-3141")))
Description:   PathMED is a collection of tools to facilitate precision medicine studies
  with omics data (e.g. transcriptomics). Among its funcionalities, genesets
  scores for individual samples may be calculated with several methods.
  These scores may be used to train machine learning models and to predict 
  clinical features on new data. For this, several machine learning
  methods are evaluated in order to select the best method based on internal 
  validation and to tune the hyperparameters. Performance metrics and a 
  ready-to-use model to predict the outcomes for new patients are returned.
Depends: R (>= 4.5.0)
Suggests: ada,
        AUCell,
        Biobase,
        BiocGenerics,
        BiocStyle,       
        fgsea (>= 1.15.4),
        gam,
        import,
        kernlab,
        klaR,
        knitr,
        mboost,
        MLeval,
        randomForest,
        ranger,
        rmarkdown,
        RUnit,
        utils,
        xgboost
Imports: 
    BiocParallel,
    caret,
    caretEnsemble,
    decoupleR,
    ggplot2,
    GSVA,
    factoextra,
    FactoMineR,
    magrittr,
    matrixStats,
    methods,
    metrica,
    pbapply,
    reshape2,
    singscore,
    stats,
    stringi,
    dplyr,
VignetteBuilder: knitr
biocViews: Pathways,
 Classification,
 FeatureExtraction,
 Transcriptomics
BugReports: https://github.com/jordimartorell/pathMED/issues
URL: https://github.com/jordimartorell/pathMED
License: GPL-2
Encoding: UTF-8
LazyData: false
RoxygenNote: 7.3.2

@bioc-issue-bot bioc-issue-bot added the 1. awaiting moderation submitted and waiting clearance to access resources label Feb 17, 2025
@lshep
Copy link
Contributor

lshep commented Feb 21, 2025

Could you please provide an abstract/intro section in your vignette that
provides motivation for inclusion in Bioconductor and when appropriate a review
and comparison to existing Bioconductor packages with similar functionality or
scope.

I currently do not see strong interoperability with existing Bioconductor classes. You mention omics - so class structures like SingleCellExperiments or SpatialExperiment should be utilized. you also create or take as input gene lists so class structures like BiocSet or GeneSets/GeneSetCollections.

@lshep lshep added 3e. pending pre-review changes review has indicated blocking concern that needs attention 3d. needs interop Package must explicitly use Bioconductor structures and methods labels Feb 21, 2025
@jordimartorell
Copy link
Author

Dear @lshep,

Thank you for your comments. We added an Introduction in the vignette. We also added compatibility with SumarizedExperiment, ExpressionSet and GeneSetCollection classes in the functions that use omics data and gene sets. These changes are available in the new version 0.99.1.

Best regards,
Jordi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. awaiting moderation submitted and waiting clearance to access resources 3d. needs interop Package must explicitly use Bioconductor structures and methods 3e. pending pre-review changes review has indicated blocking concern that needs attention
Projects
None yet
Development

No branches or pull requests

3 participants