Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package that have never propagated get a shell landing page with empty rev deps fields #14

Open
hpages opened this issue Oct 22, 2024 · 1 comment

Comments

@hpages
Copy link
Contributor

hpages commented Oct 22, 2024

See for example: https://bioconductor.org/packages/3.20/HTqPCR

Imports Me field is empty even though Bioconductor packages unifiedWMWqPCR and nondetects both import HTqPCR.

This is caused by a bug in the biocViews::write_VIEWS() function where the place holder for packages that haven't propagated yet is added after the computation of dependsOnMe, importsMe, etc... See

biocViews/R/repository.R

Lines 761 to 763 in acbc4c9

# Add place Holder for valid packages compared to manifest
# That haven't built so they get a shell landing page rather
# than no landing page

More precisely, when the rev deps are computed here, the dbMat matrix doesn't have rows for the packages that haven't propagated yet, so when these packages are later added to the matrix they end up with nothing in these fields.

@hpages
Copy link
Contributor Author

hpages commented Nov 27, 2024

Another occurence of this problem is pasilla which hasn't propagated in BioC 3.21 (current devel) yet, as of Nov 27, 2024. So its landing page doesn't report any reverse deps (see https://bioconductor.org/packages/3.21/pasilla) even though the package has many of them (via Suggests Me).

See landing page in release where the rev deps are correctly reported: https://bioconductor.org/packages/3.20/pasilla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant