Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support self-update #11

Open
Bios-Marcel opened this issue Mar 29, 2024 · 1 comment
Open

Support self-update #11

Bios-Marcel opened this issue Mar 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Bios-Marcel
Copy link
Owner

Currently, self-updating doesn't work, as scoop indicates we are still running.

I need to investigate whether this would be an issue if we were to install a new version and re-link.

The workaround is currently up to the user, instead running: scoop update spoon.

@Bios-Marcel Bios-Marcel added the bug Something isn't working label Mar 29, 2024
@Bios-Marcel
Copy link
Owner Author

Bios-Marcel commented Apr 12, 2024

Windows doesn't allow deleting the current process executable. You can however move it and create a new file in the old spot.

Note that we are also getting errors for updating the shims. Technically, we can just omit replacing the shim executable, as it should be the same.

Additionally, we don't actually want to do an in-place update right now, as spoon is installed via scoop. I need to check whether this actually means we don't have a problem here.

IF there is still a problem, it might be wiser to actually provide a different way of installing spoon. The user could simply download the executable and then execute some type of setup command maybe, instructions may look something like this:

download URL/spoon.exe; ./spoon.exe setup

This would then create a shim and whatever else would be required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant