Update rps_part_three.rst

fixed bringing it all together code

Author: Kudzmat

rps_part_three.rst

@@ -296,152 +296,161 @@ Bringing it all together!!
 
 .. code-block:: python
 
-    # our constants
-    CPU_OPTIONS = ['rock', 'paper', 'scissors']
-    USER_OPTIONS = [1,2,3]
-    GAME_RULES = {
+import random, time
+
+# global
+name = ""
+
+# our constants
+CPU_OPTIONS = ['rock', 'paper', 'scissors']
+USER_OPTIONS = [1, 2, 3]
+GAME_RULES = {
     1: {'strong': 'scissors', 'weak': 'paper'},
     2: {'strong': 'rock', 'weak': 'scissors'},
     3: {'strong': 'paper', 'weak': 'rock'}
-    }
+}
 
-    # game menu
-    def game_menu():  
-        logged = False
-        options = [1,2]
-    
-        while not logged:
-            # type casing to make sure we get int
-            menu_selection = int(input(f"""
-                    Welcome {name}, what would you like to do?
-                    1. Play Game
-                    2. Exit Game
-                    """))
-    
-            # many ways to create defence
-            if menu_selection not in options:
-                print("Please select either 1 or 2")
-                logged = False
-            else:
-                logged = True
-        return menu_selection
 
-    def find_winner(user_selection):
+# game menu
+def game_menu():
+    logged = False
+    options = [1, 2]
 
-        # use for loop to start game
-        for item in CPU_CHOICES:
-            print(f"{item.capitalize()}...")
-            time.sleep(1)
+    # get name
+    global name  # we need to call the global variable before using it
+    name = input("Welcome to Rock, Paper, Scissors! Please Enter Your Name: ").capitalize()
+    print()
 
-        # get cpu option
-        cpu = random.choice(CPU_CHOICES)
+    while not logged:
+        # type casing to make sure we get int
+        menu_selection = int(input(f"""
+                Welcome {name}, what would you like to do?
+                1. Play Game
+                2. Exit Game
+                """))
 
-        # show each option
-        # since we're using numbers, we can index with a list
-        print(f"{name} - {CPU_CHOICES[user_selection - 1]} vs CPU - {cpu}")
-        print("-------------------------------------")
+        # many ways to create defence
+        if menu_selection not in options:
+            print("Please select either 1 or 2")
+            logged = False
+        else:
+            logged = True
+    return menu_selection
+
+
+def find_winner(user_selection):
+    # use for loop to start game
+    for item in CPU_OPTIONS:
+        print(f"{item.capitalize()}...")
+        time.sleep(1)
+
+    # get cpu option
+    cpu = random.choice(CPU_OPTIONS)
+
+    # show each option
+    # since we're using numbers, we can index with a list
+    print(f"{name} - {CPU_OPTIONS[user_selection - 1]} vs CPU - {cpu}")
+    print("-------------------------------------")
+
+    # win
+    if GAME_RULES[user_selection]['strong'] == cpu:
+        return "*** You Win!!! ***", 1
+
+    # lose
+    elif GAME_RULES[user_selection]['weak'] == cpu:
+        return "--- You Lose! --- :(", 2
+
+    # tie
+    else:
+        return "^^^ It's a Tie!! ^^^ ", 0
+
+
+def replay():
+    menu_options = [1, 2]
+    confirmed = False  # user has not selected option
+
+    # play again or exit
+    while not confirmed:
+        option = int(input("""
+        Please Select:
+        1. Continue Playing
+        2. Stop Playing and Exit"""))
+
+        if option not in menu_options:
+            print("Please select either 1 or 2")
+            confirmed = False
 
-        
-        # win
-        if GAME_RULES[user]['strong'] == cpu:
-            return "*** You Win!!! ***", 1
-        
-        # lose
-        elif GAME_RULES[user]['weak'] == cpu:
-            return "--- You Lose! --- :(", 2
-        
-        # tie
         else:
-            return "^^^ It's a Tie!! ^^^ ", 0
+            confirmed = True
+        return option
 
-    def replay():
-        menu_options = [1,2]
-        confirmed = False # user has not selected option
-            
-         # play again or exit
-        while not confirmed:
-            option = int(input("""
-            Please Select:
-            1. Continue Playing
-            2. Stop Playing and Exit"""))
-    
-                
-            if option not in menu_options:
-                print("Please select either 1 or 2")
-                confirmed = False
 
+def play_game():
+    # counters for keeping game score
+    win = 0
+    loss = 0
+    draw = 0
+
+    # we want to play multiple rounds
+    playing = True
+
+    while playing:
+        # type casting
+        user_selection = int(input("""Please Select One:
+        1. Rock
+        2. Paper
+        3. Scissors"""))
+
+        # verify
+        if user_selection not in USER_OPTIONS:
+            print("Please select either 1 or 2")
+            continue  # top of the loop
+
+        else:
+
+            # save results in a variable (will be a tuple)
+            results = find_winner(user_selection)
+
+            # game results
+            # win
+            if results[1] == 1:
+                win += 1
+            # loss
+            elif results[1] == 2:
+                loss += 1
+            # draw
             else:
-                confirmed = True
-            return option
+                draw += 1
 
-    def play_game():
+            print(results[0])  # show game result
+            # show current record
+            print(f"""
+            Current Record:
+            Wins - {win} | Losses {loss} | Draws {draw}""")
 
-        # counters for keeping game score
-        win = 0
-        loss = 0
-        draw = 0
-    
-        # we want to play multiple rounds
-        playing = True
-    
-        while playing:
-            # type casting
-            user_selection = int(input("""Please Select One:
-            1. Rock
-            2. Paper
-            3. Scisoors"""))
+            # run replay function
+            replay_choice = replay()
 
-            # verify
-            if user_selection not in USER_OPTIONS:
-                print("Please select either 1 or 2")
-                continue # top of the loop
-            
+            # restart from top of the while loop/ play again
+            if replay_choice == 1:
+                continue
             else:
-    
-                # save results in a variable (will be a tuple)
-                results = find_winner(user_selection)
-        
-                
-                # game results
-                # win
-                if result[1] == 1:
-                    win += 1
-                # loss
-                elif result[1] == 2:
-                    loss += 1
-                # draw
-                else:
-                    draw += 1
-        
-                print(result[0])  # show game result
-                # show current record
-                print(f"""
-                Current Record:
-                Wins - {win} | Losses {loss} | Draws {draw}""")
-    
-                # run replay function
-                replay_choice = replay()
-    
-                # restart from top of the while loop/ play again
-                if option == 1:
-                    continue
-                else:
-                    playing = False
-        print(f"Bye {name}, thanks For Playing!")
-        exit()
+                playing = False
 
-    game_on = True
+    print(f"Bye {name}, thanks For Playing!")
+    exit()
 
-    while game_on:
-      game_option = game_menu()
 
-        # play game
-        if game_option == 1:
-            play_game()
+game_on = True
+while game_on:
+    game_option = game_menu()
+    # play game
+    if game_option == 1:
+        play_game()
+
         # stop playing
-        else:
-            print(f"Bye {name}, thanks For Playing!")
-            game_on = False
-        
-    exit()
+    else:
+        print(f"Bye {name}, thanks For Playing!")
+        game_on = False
+exit()