diff --git a/.github/workflows/conference.yml b/.github/workflows/conference.yml index 2e534d0..5704432 100644 --- a/.github/workflows/conference.yml +++ b/.github/workflows/conference.yml @@ -55,19 +55,19 @@ jobs: automated pr add_comment: runs-on: ubuntu-latest - + steps: - - name: Add comment to the issue - uses: actions/github-script@v6 - if: ${{ github.event.issue.user.type != 'User' }} #adds comment only if the issue is created by a bot - with: - github-token: ${{ secrets.GITHUB_TOKEN }} - script: | - const issueNumber = context.payload.issue.number; - const comment = "Automated issue, no action is required." - - github.issues.createComment({ - ...context.repo, - issue_number: issueNumber, - body: comment - }); + - name: Add comment to the issue + uses: actions/github-script@v6 + if: ${{ github.event.issue.user.type != 'User' }} #adds comment only if the issue is created by a bot + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + script: | + const issueNumber = context.payload.issue.number; + const comment = "Automated issue, no action is required." + + github.issues.createComment({ + ...context.repo, + issue_number: issueNumber, + body: comment + }); diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml index 7b34ad7..6ce23a6 100644 --- a/.github/workflows/playwright.yml +++ b/.github/workflows/playwright.yml @@ -13,6 +13,7 @@ on: jobs: test: + timeout-minutes: 30 runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 05abbdc..6243373 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -58,7 +58,15 @@ Follow these steps and note these guidelines to begin contributing: ![Bundle install terminal](/assets/images/bundle_install_terminal.png) -- After installing the dependencies, its time to run the application. We do this by running the command `bundle exec jekyll serve` or run the default **Build Task** Ctrl + Shift + B: +- Afterwards, run the command `pip install -r requirements-dev.txt` to install the python dev dependencies. + + ![Pip install terminal](/assets/images/pip_install_terminal.png) + +- Install the pre-commit hooks to automatically format the code before committing. Run the command `pre-commit install`: + + ![Pre-commit install terminal](/assets/images/pre-commit_install_terminal.png) + +- After installing the dependencies, its time to run the application. We do this by running the command `bundle exec jekyll serve --detach` or run the default **Build Task** Ctrl + Shift + B: ![Jekyll serve terminal](/assets/images/jekyll_serve_terminal.png) @@ -70,6 +78,32 @@ Follow these steps and note these guidelines to begin contributing: ![Running page](/assets/images/running_page.png) -- Test your changes (create new tests as needed) +### Testing Changes (create new tests as needed) + +- To run the test suites for the codebase + + - Ensure the site is running locally with `bundle exec jekyll serve --detach`. This will run the server in the background, and any content changes will immediately reflect on the site. + + ![Jekyll serve terminal](/assets/images/jekyll_serve_terminal.png) + + - If you need to restart the server, you can run `pkill -f jekyll` to stop the server and then run `bundle exec jekyll serve --detach` to start the server again. + + - Run all tests in the test-suite with the command `python3 -m pytest`: + + ![Pytest terminal](/assets/images/pytest_run_terminal.png) + +### Pushing Changes + +- Run `pre-commit run --all` to ensure your code is formatted and linted correctly before pushing your changes. + + ![Pre-commit run terminal](/assets/images/pre-commit_run_terminal.png) + +- Run `git commit -m ""` to commit your changes. + + ![Git commit terminal](/assets/images/git_commit_terminal.png) + +- Finally run `git push origin ` to push your changes to your fork. + + ![Git push terminal](/assets/images/git_push_terminal.png) - Once you’ve committed and pushed all of your changes to GitHub, go to the page for your fork on GitHub, select your development branch, and click the pull request button. Please ensure that you compare your feature branch to the desired branch of the repo you are supposed to make a PR to. If you need to make any adjustments to your pull request, just push the updates to GitHub. Your pull request will automatically track the changes in your development branch and update it. 🥳 diff --git a/assets/images/git_commit_terminal.png b/assets/images/git_commit_terminal.png new file mode 100644 index 0000000..962f6c8 Binary files /dev/null and b/assets/images/git_commit_terminal.png differ diff --git a/assets/images/git_push_terminal.png b/assets/images/git_push_terminal.png new file mode 100644 index 0000000..605220b Binary files /dev/null and b/assets/images/git_push_terminal.png differ diff --git a/assets/images/jekyll_serve_terminal.png b/assets/images/jekyll_serve_terminal.png index fbbd413..76230d5 100644 Binary files a/assets/images/jekyll_serve_terminal.png and b/assets/images/jekyll_serve_terminal.png differ diff --git a/assets/images/pip_install_terminal.png b/assets/images/pip_install_terminal.png new file mode 100644 index 0000000..81da357 Binary files /dev/null and b/assets/images/pip_install_terminal.png differ diff --git a/assets/images/pre-commit_install_terminal.png b/assets/images/pre-commit_install_terminal.png new file mode 100644 index 0000000..72f930c Binary files /dev/null and b/assets/images/pre-commit_install_terminal.png differ diff --git a/assets/images/pre-commit_run_terminal.png b/assets/images/pre-commit_run_terminal.png new file mode 100644 index 0000000..6d793a5 Binary files /dev/null and b/assets/images/pre-commit_run_terminal.png differ diff --git a/assets/images/pytest_run_terminal.png b/assets/images/pytest_run_terminal.png new file mode 100644 index 0000000..66fd337 Binary files /dev/null and b/assets/images/pytest_run_terminal.png differ