Fix Windows corpus transport and CI test dependencies

Author: FrancescAlted

.github/workflows/build.yml

@@ -108,11 +108,18 @@ jobs:
       id: build_non_windows
       run: pip install -e . --group test
 
+    - name: Install Arrow dictionary test dependency
+      # Pandas is already a dev dependency; Arrow's dictionary conversions now
+      # import it even when the test does not construct a pandas object.
+      run: python -m pip install pandas
+
     # Build isolation uses NumPy 2 headers for the dual-ABI extension. Optional
     # test dependencies may upgrade the runtime too, so pin it AFTER installing.
     - name: Install NumPy 1.26-compatible test runtime
       if: matrix.numpy-version == '1.26'
-      run: pip install "numpy==1.26.*" "zarr>=3.1.5,<3.2"
+      # PyArrow 26 dropped the NumPy 1 ABI without encoding it in Requires-Dist.
+      # Keep this host-compatibility job on a known dual-ABI Arrow release.
+      run: pip install "numpy==1.26.*" "zarr>=3.1.5,<3.2" "pyarrow==21.0.0" pandas
 
     - name: Verify requested NumPy runtime
       if: matrix.numpy-version

.github/workflows/menudet-paired.yml

@@ -74,7 +74,10 @@ jobs:
         if: runner.os != 'Windows'
         env:
           MENUDET_REQUIRE_JIT: '1'
-        run: python -m pytest tests/test_menudet_jit.py -q -n 0
+          ME_DSL_TRACE: '1'
+        run: |
+          set -o pipefail
+          python -m pytest tests/test_menudet_jit.py -q -n 0 2>&1 | tee menudet-jit.log
       - name: Record exact paired revisions
         if: always()
         run: |
@@ -87,3 +90,4 @@ jobs:
           path: |
             paired-revisions.txt
             native-build/Testing/Temporary/LastTest.log
+            menudet-jit.log

tests/test_menudet_conformance.py

@@ -5,6 +5,7 @@
 import os
 import subprocess
 from pathlib import Path
+from types import SimpleNamespace
 
 import numpy as np
 import pytest
@@ -88,6 +89,25 @@ def test_platform_qualified_reference_is_exact(machine, key, monkeypatch):
         compat.reference_expected(case)
 
 
+def test_native_input_is_closed_before_subprocess(monkeypatch, tmp_path):
+    case = compat.make_case("closed-input", "identity", "x", [np.array([1.0])])
+    corpus = {"schema_version": compat.VERSION, "cases": [case]}
+    row = {"id": case["id"], "outcome": "matching"}
+    paths = []
+
+    def run(command, **kwargs):
+        path = Path(command[1])
+        assert json.loads(path.read_text()) == corpus
+        # Windows permits this only after the writer closes its handle.
+        path.unlink()
+        paths.append(path)
+        return SimpleNamespace(returncode=0, stdout=json.dumps(row), stderr="")
+
+    monkeypatch.setattr(compat.subprocess, "run", run)
+    assert compat.native(corpus, tmp_path / "runner", tmp_path) == [row]
+    assert not paths[0].parent.exists()
+
+
 def test_seeded_generator_and_minimization():
     assert compat.property_cases(1729) == compat.property_cases(1729)
     failure = compat.property_cases(1729)[-1]

tools/menudet_conformance.py

@@ -573,10 +573,12 @@ def integrate(corpus, jit=False):  # noqa: C901 -- paired execution, diagnostics
 
 def native(corpus, runner, work_dir, jit=False, observe=False):
     validate(corpus)
-    with tempfile.NamedTemporaryFile(mode="w", suffix=".json", dir=work_dir) as file:
-        json.dump(corpus, file)
-        file.flush()
-        command = [str(runner.resolve()), file.name, "on" if jit else "off"] + (
+    # Close the input before launching the native reader. Windows cannot reopen
+    # a live NamedTemporaryFile with its default delete/share mode.
+    with tempfile.TemporaryDirectory(dir=work_dir) as directory:
+        path = Path(directory) / "corpus.json"
+        path.write_text(json.dumps(corpus))
+        command = [str(runner.resolve()), str(path), "on" if jit else "off"] + (
             ["observe"] if observe else []
         )
         proc = subprocess.run(command, capture_output=True, text=True, check=False)