Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Hurwitz Zeta function #125

Closed
rockbmb opened this issue Aug 12, 2018 · 3 comments
Closed

Implement Hurwitz Zeta function #125

rockbmb opened this issue Aug 12, 2018 · 3 comments

Comments

@rockbmb
Copy link
Contributor

rockbmb commented Aug 12, 2018

After #44 and #120, both the Riemann zeta function and the Dirichlet beta function have been implemented.

The Hurwitz zeta function is another important function that can be used to define both the Riemann zeta and the Dirichlet beta functions, so this issue is about refactoring the two latter functions to use the former.

This should all go into the newly created Math.NumberTheory.Zeta namespace.
@rockbmb
Copy link
Contributor Author

rockbmb commented Aug 12, 2018

I'll assign myself to this issue, but if anyone else wants to work on it, please go ahead.

rockbmb added a commit to rockbmb/arithmoi that referenced this issue Aug 13, 2018
@rockbmb
[Bodigrim#125] Implement Hurwitz zeta function
32ae9ef
@rockbmb rockbmb mentioned this issue Aug 13, 2018
Merged
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Aug 14, 2018
@rockbmb
[Bodigrim#125] Fix 'zeta' function
89604ae 
The previous version of 'zeta' was incorrect as it returned a list
of successively improving approximations of the zeta function
for its arguments instead of the final one.
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Aug 14, 2018
@rockbmb
[Bodigrim#125] Refactor Riemann zeta and Dirichlet beta functions (WIP)
43e0c90
@rockbmb
Copy link
Contributor Author

rockbmb commented Sep 10, 2018 •
edited
Loading

@Bodigrim I have not forgotten about this issue, will tackle it next. In fact, @b-mehta you've been contributing to the package recently as well (and your PR is relevant to this issue), if you have any ideas or suggestions I'll listen.

Afterwards, I plan on doing #79 and #100, but I'll take my time.

@b-mehta
Copy link
Contributor

b-mehta commented Sep 10, 2018 •
edited
Loading

I don't have any suggestions right now, but I'm happy to provide help or feedback when appropriate!

rockbmb added a commit to rockbmb/arithmoi that referenced this issue Sep 17, 2018
@rockbmb
[Bodigrim#125] Refactor Hurwitz zeta function
724dd90
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Sep 18, 2018
@rockbmb
[Bodigrim#125] More refactoring
9158106
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Sep 24, 2018
@rockbmb
[Bodigrim#125] Merge branch 'master' into hurwitz-zeta
a509142
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Sep 24, 2018
@rockbmb
[Bodigrim#125] Fix Dirichlet beta/Riemann zeta precision tests
44ea390 
In `betasProperty2/zetasProperty2`, sometimes a precision greater
than `2e-53` was generated, and because the tests use `Double`, this
lead to incorrect results with `NaN` values and improper test cases.

The tests have been changed to avoid generating a precision greater
than `2e-53`.
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Sep 24, 2018
@rockbmb
[Bodigrim#125] Refactoring
07bff72 
* The Hurwitz `zeta` function has been renamed to `zetaHurwitz`
 to avoid confusion with the Riemann `zetas` recurrence
* The `betasProperty2` test now compares more terms of the
 Dirichlet beta function because the new implementation of
 `betasEven` is more numerically stable
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Sep 24, 2018
@rockbmb
[Bodigrim#125] Update comments
9f821b4
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Sep 29, 2018
@rockbmb
[Bodigrim#125] Extend Hurwitz zeta's first argument to Floating
10a0757
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Sep 29, 2018
@rockbmb
[Bodigrim#125] Revert Hurwitz zeta function's first argument to `Inte…
78e0f93 
…gral`
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Sep 29, 2018
@rockbmb
[Bodigrim#125] Increase terms of Riemann zeta/Dirichlet beta terms co…
ca9626a 
…mpared in precision test
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Sep 30, 2018
@rockbmb
[Bodigrim#125] Expose zetaHurwitz to end-users
f00f9f9
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Oct 3, 2018
@rockbmb
[Bodigrim#125] Implement Hurwitz zeta function
69dc1f5
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Oct 3, 2018
@rockbmb
[Bodigrim#125] Fix 'zeta' function
2a6920b 
The previous version of 'zeta' was incorrect as it returned a list
of successively improving approximations of the zeta function
for its arguments instead of the final one.
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Oct 3, 2018
@rockbmb
[Bodigrim#125] Refactor Riemann zeta and Dirichlet beta functions (WIP)
df24d04
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Oct 3, 2018
@rockbmb
[Bodigrim#125] Refactor Hurwitz zeta function
9859366
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Oct 3, 2018
@rockbmb
[Bodigrim#125] More refactoring
839f7fb
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Oct 3, 2018
@rockbmb
[Bodigrim#125] Fix Dirichlet beta/Riemann zeta precision tests
f112227 
In `betasProperty2/zetasProperty2`, sometimes a precision greater
than `2e-53` was generated, and because the tests use `Double`, this
lead to incorrect results with `NaN` values and improper test cases.

The tests have been changed to avoid generating a precision greater
than `2e-53`.
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Oct 3, 2018
@rockbmb
[Bodigrim#125] Refactoring
6cd605c 
* The Hurwitz `zeta` function has been renamed to `zetaHurwitz`
 to avoid confusion with the Riemann `zetas` recurrence
* The `betasProperty2` test now compares more terms of the
 Dirichlet beta function because the new implementation of
 `betasEven` is more numerically stable
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Oct 3, 2018
@rockbmb
[Bodigrim#125] Update comments
9f038ae
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Oct 3, 2018
@rockbmb
[Bodigrim#125] Extend Hurwitz zeta's first argument to Floating
5d6fb09
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Oct 3, 2018
@rockbmb
[Bodigrim#125] Revert Hurwitz zeta function's first argument to `Inte…
aa7e762 
…gral`
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Oct 3, 2018
@rockbmb
[Bodigrim#125] Increase terms of Riemann zeta/Dirichlet beta terms co…
4804b57 
…mpared in precision test
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Oct 3, 2018
@rockbmb
[Bodigrim#125] Expose zetaHurwitz to end-users
c8def42
rockbmb added a commit to rockbmb/arithmoi that referenced this issue Oct 19, 2018
@rockbmb
[Bodigrim#125] Fix Haddock comments
9f0776b 
Haddock comments for `zetas,betas,zetaHurwitz` now have paragraphs
for better readability.

Plus, the stability and portability Haddock module comment fields
for the Hurwitz module have been removed.
Bodigrim added a commit that referenced this issue Oct 19, 2018
@Bodigrim
Merge pull request #126 from rockbmb/hurwitz-zeta
a021429 
[#125] Implement Hurwitz zeta function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rockbmb @b-mehta