Skip to content
This repository was archived by the owner on Apr 2, 2020. It is now read-only.
This repository was archived by the owner on Apr 2, 2020. It is now read-only.

Suggestions. #1

@JamieKnight

Description

@JamieKnight

Heya,

Just some notes form out conversion:

  • Be good to look at package.json for expressing dependencies (http://browsenpm.org/package.json)
  • In server.js it may be clearer to use something like node async waterfall or series to manage the callbacks and express intent. (https://github.com/caolan/async#waterfall)
  • Consider wrapping long conditional (like "if (!Bridge.DiscoveredBridge.HueRegistered || !Bridge.DiscoveredBridge.HueIpAddress || !Bridge.DiscoveredBridge.HueUsername)" into a function for readability. So it could read "if (Bridge.ReadyToRun()) { " etc. Easier to understand the intent.
  • Consider a switch when testing the same value repeatedly and you want a default action (such as in FindBridge)

Hope that helps, happy to get together for a day of pairing sometime if you fancy,

Cheers,

Jamie + Lion

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions