# Refatorar e testes unitarios

Author: Bulletdev

.github/workflows/qodana_code_quality.yml

@@ -0,0 +1,24 @@
+name: Qodana
+on:
+  workflow_dispatch:
+  pull_request:
+  push:
+    branches:
+      - main
+
+jobs:
+  qodana:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: write
+      pull-requests: write
+      checks: write
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+          fetch-depth: 0
+      - name: 'Qodana Scan'
+        uses: JetBrains/[email protected]
+        env:
+          QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }}

.idea/.gitignore

@@ -1,28 +1,36 @@
 package main
 
 import (
-    "bullet-cloud-api/internal/handlers"
-    "log"
-    "net/http"
-    "os"
+	"bullet-cloud-api/internal/handlers"
+	"log"
+	"net/http"
+	"os"
 
-    "github.com/gorilla/mux"
-) 
+	"github.com/gorilla/mux"
+)
+
+const defaultPort = "4444"
 
 func main() {
-    r := mux.NewRouter()
-    r.HandleFunc("/health", handlers.HealthCheck).Methods("GET")
-    r.HandleFunc("/products", handlers.GetAllProducts).Methods("GET")
-    r.HandleFunc("/products", handlers.CreateProduct).Methods("POST")
-    r.HandleFunc("/products/{id}", handlers.GetProduct).Methods("GET")
-    r.HandleFunc("/products/{id}", handlers.UpdateProduct).Methods("PUT")
-    r.HandleFunc("/products/{id}", handlers.DeleteProduct).Methods("DELETE")
-
-    port := os.Getenv("API_PORT")
-    if port == "" {
-        port = "4444" // Porta padrão, caso não esteja definida no ambiente
-    }
-
-    log.Printf("Server starting on :%s", port)
-    log.Fatal(http.ListenAndServe(":"+port, r))
+	r := setupRoutes()
+
+	port := os.Getenv("API_PORT")
+	if port == "" {
+		port = defaultPort // Porta padrão definida para maior clareza
+	}
+
+	log.Printf("Server starting on :%s", port)
+	log.Fatal(http.ListenAndServe(":"+port, r))
+}
+
+func setupRoutes() *mux.Router {
+	r := mux.NewRouter()
+
+	r.HandleFunc("/health/{id}", handlers.HealthCheck).Methods("GET")
+	r.HandleFunc("/products", handlers.GetAllProducts).Methods("GET")
+	r.HandleFunc("/products", handlers.CreateProduct).Methods("POST")
+	r.HandleFunc("/products/{id}", handlers.GetProduct).Methods("GET")
+	r.HandleFunc("/products/{id}", handlers.UpdateProduct).Methods("PUT")
+	r.HandleFunc("/products/{id}", handlers.DeleteProduct).Methods("DELETE")
+	return r
 }

.idea/bullet-cloud-api.iml

@@ -13,15 +13,21 @@ var productRepo = models.NewProductRepository()
 
 func HealthCheck(w http.ResponseWriter, r *http.Request) {
 	w.Header().Set("Content-Type", "application/json")
-	json.NewEncoder(w).Encode(map[string]string{"status": "healthy"})
+	err := json.NewEncoder(w).Encode(map[string]string{"status": "healthy"})
+	if err != nil {
+		return
+	}
 }
 
 func GetAllProducts(w http.ResponseWriter, r *http.Request) {
 	products := productRepo.GetAll()
 	w.Header().Set("Content-Type", "application/json")
-	json.NewEncoder(w).Encode(products)
+	err := json.NewEncoder(w).Encode(products)
+	if err != nil {
+		return
+	}
 }
-// bulletdev
+
 func CreateProduct(w http.ResponseWriter, r *http.Request) {
 	var product models.Product
 
@@ -37,7 +43,9 @@ func CreateProduct(w http.ResponseWriter, r *http.Request) {
 
 	w.Header().Set("Content-Type", "application/json")
 	w.WriteHeader(http.StatusCreated)
-	json.NewEncoder(w).Encode(product)
+	if err := json.NewEncoder(w).Encode(product); err != nil {
+		http.Error(w, err.Error(), http.StatusInternalServerError)
+	}
 }
 
 func GetProduct(w http.ResponseWriter, r *http.Request) {
@@ -49,9 +57,12 @@ func GetProduct(w http.ResponseWriter, r *http.Request) {
 		http.Error(w, err.Error(), http.StatusNotFound)
 		return
 	}
-// bulletdev
+
 	w.Header().Set("Content-Type", "application/json")
-	json.NewEncoder(w).Encode(product)
+	err = json.NewEncoder(w).Encode(product)
+	if err != nil {
+		return
+	}
 }
 
 func UpdateProduct(w http.ResponseWriter, r *http.Request) {
@@ -70,9 +81,11 @@ func UpdateProduct(w http.ResponseWriter, r *http.Request) {
 	}
 
 	w.Header().Set("Content-Type", "application/json")
-	json.NewEncoder(w).Encode(updatedProduct)
+	if err := json.NewEncoder(w).Encode(updatedProduct); err != nil {
+		http.Error(w, err.Error(), http.StatusInternalServerError)
+	}
 }
-// bulletdev
+
 func DeleteProduct(w http.ResponseWriter, r *http.Request) {
 	vars := mux.Vars(r)
 	id := vars["id"]

.idea/modules.xml

@@ -2,6 +2,8 @@ package handlers
 
 import (
 	"net/http"
+	"net/http/httptest"
+	"strings"
 	"testing"
 )
 
@@ -14,7 +16,20 @@ func TestUpdateProduct(t *testing.T) {
 		name string
 		args args
 	}{
-		// TODO: Add test cases.
+		{
+			name: "Valid request",
+			args: args{
+				w: httptest.NewRecorder(),
+				r: httptest.NewRequest("PUT", "/products/1", strings.NewReader(`{"name":"Updated Product"}`)),
+			},
+		},
+		{
+			name: "Invalid request",
+			args: args{
+				w: httptest.NewRecorder(),
+				r: httptest.NewRequest("PUT", "/products/1", strings.NewReader(`{"invalid":"data"}`)),
+			},
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {

.idea/vcs.xml

@@ -0,0 +1,29 @@
+#-------------------------------------------------------------------------------#
+#               Qodana analysis is configured by qodana.yaml file               #
+#             https://www.jetbrains.com/help/qodana/qodana-yaml.html            #
+#-------------------------------------------------------------------------------#
+version: "1.0"
+
+#Specify inspection profile for code analysis
+profile:
+  name: qodana.starter
+
+#Enable inspections
+#include:
+#  - name: <SomeEnabledInspectionId>
+
+#Disable inspections
+#exclude:
+#  - name: <SomeDisabledInspectionId>
+#    paths:
+#      - <path/where/not/run/inspection>
+
+#Execute shell command before Qodana execution (Applied in CI/CD pipeline)
+#bootstrap: sh ./prepare-qodana.sh
+
+#Install IDE plugins before Qodana execution (Applied in CI/CD pipeline)
+#plugins:
+#  - id: <plugin.id> #(plugin id can be found at https://plugins.jetbrains.com)
+
+#Specify Qodana linter for analysis (Applied in CI/CD pipeline)
+linter: jetbrains/qodana-go:2024.3