chore: silence codeQL warning about stb_image.h and other

Author: Toni500github

.github/workflows/codeql.yml

@@ -90,7 +90,7 @@ jobs:
         -D SDL_RPATH=OFF
 
     - name: Build and Install SDL3
-      run: cmake --build build && sudo cmake --install build
+      run: cmake --build build && sudo cmake --install build && rm -rf SDL
 
     # If the analyze step fails for one of the languages you are analyzing with
     # "We were unable to automatically build your code", modify the matrix above

include/stb/stb_image.h

@@ -1817,7 +1817,7 @@ static stbi__uint16 *stbi__convert_format16(stbi__uint16 *data, int img_n, int r
    if (req_comp == img_n) return data;
    STBI_ASSERT(req_comp >= 1 && req_comp <= 4);
 
-   good = (stbi__uint16 *) stbi__malloc(req_comp * x * y * 2);
+   good = (stbi__uint16 *) stbi__malloc((size_t)req_comp * x * y * 2);
    if (good == NULL) {
       STBI_FREE(data);
       return (stbi__uint16 *) stbi__errpuc("outofmem", "Out of memory");
@@ -4821,7 +4821,7 @@ static int stbi__create_png_image_raw(stbi__png *a, stbi_uc *raw, stbi__uint32 r
             stbi__create_png_alpha_expand8(dest, dest, x, img_n);
       } else if (depth == 8) {
          if (img_n == out_n)
-            memcpy(dest, cur, x*img_n);
+            memcpy(dest, cur, (size_t)x*img_n);
          else
             stbi__create_png_alpha_expand8(dest, cur, x, img_n);
       } else if (depth == 16) {
@@ -6201,7 +6201,7 @@ static void *stbi__psd_load(stbi__context *s, int *x, int *y, int *comp, int req
       out = (stbi_uc *) stbi__malloc_mad3(8, w, h, 0);
       ri->bits_per_channel = 16;
    } else
-      out = (stbi_uc *) stbi__malloc(4 * w*h);
+      out = (stbi_uc *) stbi__malloc((size_t)4 * w*h);
 
    if (!out) return stbi__errpuc("outofmem", "Out of memory");
    pixelCount = w*h;
@@ -6524,7 +6524,7 @@ static void *stbi__pic_load(stbi__context *s,int *px,int *py,int *comp,int req_c
    // intermediate buffer is RGBA
    result = (stbi_uc *) stbi__malloc_mad3(x, y, 4, 0);
    if (!result) return stbi__errpuc("outofmem", "Out of memory");
-   memset(result, 0xff, x*y*4);
+   memset(result, 0xff, (size_t)x*y*4);
 
    if (!stbi__pic_load_core(s,x,y,comp, result)) {
       STBI_FREE(result);
@@ -6833,11 +6833,11 @@ static stbi_uc *stbi__gif_load_next(stbi__context *s, stbi__gif *g, int *comp, i
       }
 
       // background is what out is after the undoing of the previou frame;
-      memcpy( g->background, g->out, 4 * g->w * g->h );
+      memcpy( g->background, g->out, (size_t) 4 * g->w * g->h );
    }
 
    // clear my history;
-   memset( g->history, 0x00, g->w * g->h );        // pixels that were affected previous frame
+   memset( g->history, 0x00, (size_t) g->w * g->h );        // pixels that were affected previous frame
 
    for (;;) {
       int tag = stbi__get8(s);
@@ -6963,12 +6963,12 @@ static void *stbi__load_gif_main_outofmem(stbi__gif *g, stbi_uc *out, int **dela
 static void *stbi__load_gif_main(stbi__context *s, int **delays, int *x, int *y, int *z, int *comp, int req_comp)
 {
    if (stbi__gif_test(s)) {
-      int layers = 0;
+      size_t layers = 0;
       stbi_uc *u = 0;
       stbi_uc *out = 0;
       stbi_uc *two_back = 0;
       stbi__gif g;
-      int stride;
+      size_t stride = 0;
       int out_size = 0;
       int delays_size = 0;
 

src/engine.cpp

@@ -335,7 +335,7 @@ TextureBufferAndMemory Engine::LoadTextureFromFile(const std::string &name) {
 
     fmt::println("Loading image {} ...", name);
     stbi_uc *imageData = stbi_load(name.data(), &texWidth, &texHeight, nullptr, STBI_rgb_alpha);
-    VkDeviceSize imageSize = texWidth * texHeight * 4;
+    VkDeviceSize imageSize = static_cast<VkDeviceSize>(texWidth * texHeight * 4);
 
     if (!imageData)
     {
@@ -923,7 +923,7 @@ Glyph Engine::GenerateGlyph(EngineSharedContext &sharedContext, FT_Face ftFace,
             }
     }
 
-    VkDeviceSize glyphBufferSize = ftFace->glyph->bitmap.width * ftFace->glyph->bitmap.rows;
+    VkDeviceSize glyphBufferSize = static_cast<VkDeviceSize>(ftFace->glyph->bitmap.width * ftFace->glyph->bitmap.rows);
 
     TextureBufferAndMemory glyphBuffer{};
     AllocateBuffer(sharedContext, glyphBufferSize, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, VK_MEMORY_PROPERTY_HOST_COHERENT_BIT | VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT, glyphBuffer.bufferAndMemory.buffer, glyphBuffer.bufferAndMemory.memory);

src/tinyfiledialogs.cpp

@@ -92,9 +92,11 @@ misrepresented as being the original software.
 #else
  #include <limits.h>
  #include <unistd.h>
+ #include <fcntl.h>
  #include <dirent.h> /* on old systems try <sys/dir.h> instead */
  #include <termios.h>
  #include <sys/utsname.h>
+ #include <sys/stat.h>
  #include <signal.h> /* on old systems try <sys/signal.h> instead */
  #define TINYFD_SLASH "/"
 #endif /* _WIN32 */
@@ -393,19 +395,19 @@ static int fileExists( char const * aFilePathAndName )
 
 static void wipefile(char const * aFilename)
 {
-		int i;
+		int i, fd;
 		struct stat st;
 		FILE * lIn;
 
-		if (stat(aFilename, &st) == 0)
+		if ((fd = open(aFilename, O_WRONLY)) != -1)
 		{
-				if ((lIn = fopen(aFilename, "w")))
+				if (fstat(fd, &st) == 0)
 				{
 						for (i = 0; i < st.st_size; i++)
 						{
-								fputc('A', lIn);
+								write(fd, "A", 1);
 						}
-						fclose(lIn);
+						close(fd);
 				}
 		}
 }