with_detach fails silently on macOS

[benzeneringlq]

Current Behavior

platform	call	args	result
macOS	/usr/bin/open	main.pdf -a hellohello	silent after triggers /usr/bin/open successfully
Linux	hellohello	main.pdf	error because fails triggers hellohello

Expected Behavior

open::with_detach( main.pdf , hellohello) should return an error, consistent with the behavior of running open main.pdf -a hellohello in the terminal.

background : typst/typst/issues/8061

Since both open-rs and the underlying '/usr/bin/open' command implement detachment, Would it make sense to remove one layer to simplify things? It might be better to implement this removal upstream.

I've gone through Byron/open-rs#46

[Byron]

Thanks a lot for reporting.

Are you suggesting that PR #46 is introducing the bug? Do you think you could implement that removal of one layer of abstraction, at least for macOS, to fix this?

[benzeneringlq]

I didn't mean to imply that PR #46 introduced a bug; I was simply looking through it to get a better understanding of the project's development history.

My suggestion

The code changes below allows with_detached to report errors on macOS ( This change effectively replaces with_detach with with. ), but I'm unsure of other impacts. I can't guarantee that open won't block in some rare scenarios.

pub fn with_detached<T: AsRef<OsStr>>(path: T, app: impl Into<String>) -> io::Result<()> {
    #[cfg(target_os = "macos")]
    {
        let mut cmd = with_command(path, app);
        cmd.status_without_output().into_result(&cmd)
    }

Results before modification

> cargo run -- "/Users/liuming/projects/test/main.pdf" --with-detach "hellohello"
Opened '/Users/liuming/projects/test/main.pdf' successfully.

The program reports success, but in reality , will fail in practice. Because there is no such program as 'hellohello'.

Results after modification

> cargo run -- "/Users/liuming/projects/test/main.pdf" --with-detach "hellohello"
Error: Custom { kind: Other, error: "Launcher \"/usr/bin/open\" \"/Users/liuming/projects/test/main.pdf\" \"-a\" \"hellohello\" failed with ExitStatus(unix_wait_status(256))" }
> cargo run -- "/Users/liuming/projects/test/main.pdf" --with "hellohello"
Error: Custom { kind: Other, error: "Launcher \"/usr/bin/open\" \"/Users/liuming/projects/test/main.pdf\" \"-a\" \"hellohello\" failed with ExitStatus(unix_wait_status(256))" }

If you're on board with this, I'd be happy to submit a PR.

[Byron]

Thanks! Let's do it!