Skip to content

Commit 4707304

Browse files
committed
update ttl type from millisecond to second(#263)
1 parent 5fa08c2 commit 4707304

File tree

2 files changed

+11
-13
lines changed

2 files changed

+11
-13
lines changed

structure/string.go

+3-5
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ func stringToBytesWithKey(key string) []byte {
3535
}
3636

3737
func integerToDuration(ttl int64) time.Duration {
38-
return time.Duration(ttl) * time.Millisecond
38+
return time.Duration(ttl) * time.Second
3939
}
4040

4141
// Set sets the value of a key
@@ -395,7 +395,7 @@ func (s *StringStructure) Size(key string) (string, error) {
395395

396396
sizeInBytes := len(toString)
397397

398-
// 将字节数转换成对应的单位(KB、MB等)
398+
// Convert bytes to corresponding units (KB, MB...)
399399
const (
400400
KB = 1 << 10
401401
MB = 1 << 20
@@ -558,8 +558,6 @@ var (
558558
ErrInvalidValue = errors.New("Wrong value: invalid value")
559559
// ErrInvalidType is returned if the type is invalid.
560560
ErrInvalidType = errors.New("Wrong value: invalid type")
561-
// ErrKeyExpired is returned if the key is expired.
562-
ErrKeyExpired = errors.New("Wrong value: key expired")
563561
)
564562

565563
// decodeStringValue decodes the value
@@ -596,7 +594,7 @@ func decodeStringValue(value []byte) ([]byte, int64, error) {
596594

597595
// Check the expiration time expire
598596
if expire != 0 && expire < time.Now().UnixNano() {
599-
return nil, -1, ErrKeyExpired
597+
return nil, -1, _const.ErrKeyIsExpired
600598
}
601599

602600
// Return the original value value

structure/string_test.go

+8-8
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ func TestStringStructure_Get(t *testing.T) {
2626

2727
err = str.Set("1", randkv.RandomValue(100), 0)
2828
assert.Nil(t, err)
29-
err = str.Set("1", randkv.RandomValue(100), 2000)
29+
err = str.Set("1", randkv.RandomValue(100), 2)
3030
assert.Nil(t, err)
3131

3232
value1, err := str.Get("1")
@@ -36,7 +36,7 @@ func TestStringStructure_Get(t *testing.T) {
3636
time.Sleep(3 * time.Second)
3737

3838
value2, err := str.Get("1")
39-
assert.Equal(t, err, ErrKeyExpired)
39+
assert.Equal(t, err, _const.ErrKeyIsExpired)
4040
assert.Nil(t, value2)
4141

4242
_, err = str.Get("3")
@@ -305,29 +305,29 @@ func TestStringStructure_Expire(t *testing.T) {
305305
err = str.Set("1", []byte("1"), 0)
306306
assert.Nil(t, err)
307307

308-
err = str.Expire("1", 1000)
308+
err = str.Expire("1", 1)
309309
assert.Nil(t, err)
310310
v1, err := str.Get("1")
311311
assert.Nil(t, err)
312312
assert.Equal(t, v1, []byte("1"))
313313

314314
time.Sleep(2 * time.Second)
315315
v2, err := str.Get("1")
316-
assert.Equal(t, err, ErrKeyExpired)
316+
assert.Equal(t, err, _const.ErrKeyIsExpired)
317317
assert.Equal(t, v2, nil)
318318

319319
err = str.Set("2", "你好", 0)
320320
assert.Nil(t, err)
321321

322-
err = str.Expire("2", 1000)
322+
err = str.Expire("2", 1)
323323
assert.Nil(t, err)
324324
v3, err := str.Get("2")
325325
assert.Nil(t, err)
326326
assert.Equal(t, v3, "你好")
327327

328328
time.Sleep(2 * time.Second)
329329
v4, err := str.Get("2")
330-
assert.Equal(t, err, ErrKeyExpired)
330+
assert.Equal(t, err, _const.ErrKeyIsExpired)
331331
assert.Equal(t, v4, nil)
332332
}
333333

@@ -338,7 +338,7 @@ func TestStringStructure_Persist(t *testing.T) {
338338
err = str.Set("1", []byte("1"), 0)
339339
assert.Nil(t, err)
340340

341-
err = str.Expire("1", 1000)
341+
err = str.Expire("1", 1)
342342
assert.Nil(t, err)
343343
v1, err := str.Get("1")
344344
assert.Nil(t, err)
@@ -449,7 +449,7 @@ func TestStringStructure_TTL(t *testing.T) {
449449
str, _ := initdb()
450450
defer str.db.Clean()
451451

452-
err = str.Set("1", []byte("1"), 2000)
452+
err = str.Set("1", []byte("1"), 2)
453453
assert.Nil(t, err)
454454

455455
ttl, err := str.TTL("1")

0 commit comments

Comments
 (0)