Skip to content

Commit bfcbdd7

Browse files
committed
refactor hash ttl in grpc(#274)
1 parent a327106 commit bfcbdd7

File tree

4 files changed

+428
-252
lines changed

4 files changed

+428
-252
lines changed

engine/grpc/service/hash.go

+18-18
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ func (s *hash) CloseDb() error {
3434
func (s *hash) HSet(ctx context.Context, req *ghash.GHashSetRequest) (*ghash.GHashSetResponse, error) {
3535
fmt.Println("receive put request: key: ", req.Key, " field: ", req.GetField(), " value: ", req.GetValue())
3636
var err error
37-
result, err := setValue(s, req.Key, req.Field, req.Ttl, req)
37+
result, err := setValue(s, req.Key, req.Field, req)
3838
if err != nil {
3939
return &ghash.GHashSetResponse{Ok: result}, err
4040
}
@@ -77,28 +77,28 @@ func (s *hash) HDel(ctx context.Context, req *ghash.GHashDelRequest) (*ghash.GHa
7777
return &ghash.GHashDelResponse{Ok: ok}, err
7878
}
7979

80-
func setValue(s *hash, key string, field interface{}, ttl int64, r *ghash.GHashSetRequest) (bool, error) {
80+
func setValue(s *hash, key string, field interface{}, r *ghash.GHashSetRequest) (bool, error) {
8181
switch r.Value.(type) {
8282
case *ghash.GHashSetRequest_StringValue:
83-
ok, err := s.dbh.HSet(key, field, r.GetStringValue(), ttl)
83+
ok, err := s.dbh.HSet(key, field, r.GetStringValue())
8484
return ok, err
8585
case *ghash.GHashSetRequest_Int32Value:
86-
ok, err := s.dbh.HSet(key, field, r.GetInt32Value(), ttl)
86+
ok, err := s.dbh.HSet(key, field, r.GetInt32Value())
8787
return ok, err
8888
case *ghash.GHashSetRequest_Int64Value:
89-
ok, err := s.dbh.HSet(key, field, r.GetInt64Value(), ttl)
89+
ok, err := s.dbh.HSet(key, field, r.GetInt64Value())
9090
return ok, err
9191
case *ghash.GHashSetRequest_Float32Value:
92-
ok, err := s.dbh.HSet(key, field, r.GetFloat32Value(), ttl)
92+
ok, err := s.dbh.HSet(key, field, r.GetFloat32Value())
9393
return ok, err
9494
case *ghash.GHashSetRequest_Float64Value:
95-
ok, err := s.dbh.HSet(key, field, r.GetFloat64Value(), ttl)
95+
ok, err := s.dbh.HSet(key, field, r.GetFloat64Value())
9696
return ok, err
9797
case *ghash.GHashSetRequest_BoolValue:
98-
ok, err := s.dbh.HSet(key, field, r.GetBoolValue(), ttl)
98+
ok, err := s.dbh.HSet(key, field, r.GetBoolValue())
9999
return ok, err
100100
case *ghash.GHashSetRequest_BytesValue:
101-
ok, err := s.dbh.HSet(key, field, r.GetBytesValue(), ttl)
101+
ok, err := s.dbh.HSet(key, field, r.GetBytesValue())
102102
return ok, err
103103
default:
104104
return false, fmt.Errorf("unknown value type")
@@ -219,35 +219,35 @@ func (s *hash) HMove(ctx context.Context, req *ghash.GHashMoveRequest) (*ghash.G
219219

220220
func (s *hash) HSetNX(ctx context.Context, req *ghash.GHashSetNXRequest) (*ghash.GHashSetNXResponse, error) {
221221
// Check if the key already exists
222-
ok, err := setNXValue(s, req.Key, req.Field, req.Ttl, req)
222+
ok, err := setNXValue(s, req.Key, req.Field, req)
223223
if err != nil {
224224
return &ghash.GHashSetNXResponse{Ok: ok}, err
225225
}
226226

227227
return &ghash.GHashSetNXResponse{Ok: ok}, nil
228228
}
229-
func setNXValue(s *hash, key string, field interface{}, ttl int64, r *ghash.GHashSetNXRequest) (bool, error) {
229+
func setNXValue(s *hash, key string, field interface{}, r *ghash.GHashSetNXRequest) (bool, error) {
230230
switch r.Value.(type) {
231231
case *ghash.GHashSetNXRequest_StringValue:
232-
ok, err := s.dbh.HSetNX(key, field, r.GetStringValue(), ttl)
232+
ok, err := s.dbh.HSetNX(key, field, r.GetStringValue())
233233
return ok, err
234234
case *ghash.GHashSetNXRequest_Int32Value:
235-
ok, err := s.dbh.HSetNX(key, field, r.GetInt32Value(), ttl)
235+
ok, err := s.dbh.HSetNX(key, field, r.GetInt32Value())
236236
return ok, err
237237
case *ghash.GHashSetNXRequest_Int64Value:
238-
ok, err := s.dbh.HSetNX(key, field, r.GetInt64Value(), ttl)
238+
ok, err := s.dbh.HSetNX(key, field, r.GetInt64Value())
239239
return ok, err
240240
case *ghash.GHashSetNXRequest_Float32Value:
241-
ok, err := s.dbh.HSetNX(key, field, r.GetFloat32Value(), ttl)
241+
ok, err := s.dbh.HSetNX(key, field, r.GetFloat32Value())
242242
return ok, err
243243
case *ghash.GHashSetNXRequest_Float64Value:
244-
ok, err := s.dbh.HSetNX(key, field, r.GetFloat64Value(), ttl)
244+
ok, err := s.dbh.HSetNX(key, field, r.GetFloat64Value())
245245
return ok, err
246246
case *ghash.GHashSetNXRequest_BoolValue:
247-
ok, err := s.dbh.HSetNX(key, field, r.GetBoolValue(), ttl)
247+
ok, err := s.dbh.HSetNX(key, field, r.GetBoolValue())
248248
return ok, err
249249
case *ghash.GHashSetNXRequest_BytesValue:
250-
ok, err := s.dbh.HSetNX(key, field, r.GetBytesValue(), ttl)
250+
ok, err := s.dbh.HSetNX(key, field, r.GetBytesValue())
251251
return ok, err
252252
default:
253253
return false, fmt.Errorf("unknown value type")

0 commit comments

Comments
 (0)