Copy editing / technical /design review after accept: Simulating and visualising data in environmental history: Airborne dust concentration from the Belval plant in Luxembourg (1911-1997)

[inactinique]

PID: ZDFmmD3xv4S7

[eliselavy]

@inactinique
Didn't take into account desanomization made by the authors

align with:

[eliselavy]

@inactinique sent for copy-editing

[eliselavy]

@biumiamy copy-editing can be added https://github.com/jdh-observer/ZDFmmD3xv4S7/blob/main/article.md
ZDFmmD3xv4S7.docx updated

[biumiamy]

done, PR here: https://github.com/jdh-observer/ZDFmmD3xv4S7/compare/corrections?expand=1

There is one editorial problem in my eyes: They used anchors to refer to sections of their article. But since we dont show those numbers, it's not very easy for readers to understand what they refer to (apart from clicking to jump there.. and then having to scroll back to where they were originally reading).

I recommend the authors to change this to sth that works better with our structure of the frontend. Reference to the name of the chapter or whatever..

Also:

• videos not implemented (I can upload them to vimeo, but they need to decided where to put the videos.. and what text and figure title etc.)
• images (and video make the repo size) too big, need to decrease in last step of design review

[eliselavy]

done, PR here: https://github.com/jdh-observer/ZDFmmD3xv4S7/compare/corrections?expand=1

There is one editorial problem in my eyes: They used anchors to refer to sections of their article. But since we dont show those numbers, it's not very easy for readers to understand what they refer to (apart from clicking to jump there.. and then having to scroll back to where they were originally reading).

I recommend the authors to change this to sth that works better with our structure of the frontend. Reference to the name of the chapter or whatever..

Also:

• videos not implemented (I can upload them to vimeo, but they need to decided where to put the videos.. and what text and figure title etc.)
• images (and video make the repo size) too big, need to decrease in last step of design review

consolidation made - anchor works
about the use of the section mention , the reviewer made any feedback about it
@inactinique article here

[eliselavy]

@biumiamy social media cover

[biumiamy]

here are the two videos that are in their repo hosted on vimeo:
pollution animation
pollution Esch
And I recommend to integrate the video from their website

(but actually the provided quality is very bad..)

[biumiamy]

@danieleguido the dot beside my mouse pointer is cut off for some reason

[biumiamy]

added social media cover: https://github.com/jdh-observer/ZDFmmD3xv4S7/blob/main/socialmediacover.png

[inactinique]

Hum. Some paragraphs are badly numbered.

[inactinique]

here are the two videos that are in their repo hosted on vimeo: pollution animation pollution Esch And I recommend to integrate the video from their website

(but actually the provided quality is very bad..)

What should I precisely write to them in this respect? There are cells with ffmpeg, but not sure that it is displaying anything?

[inactinique]

Problem of this cell that should be in the hermeneutics layer:

In the markdown fil, it is tagged hermeneutics. Maybe it's something already corrected.

[biumiamy]

What should I precisely write to them in this respect? There are cells with ffmpeg, but not sure that it is displaying anything?

There's only images implemented for the moment. And I dont know, where did you find those cells, I cant see them in Jupyter Lab at least..

You can just ask them

• where they would like to add their 2 videos
• and if they also would like to link the general video from their website (we need a vimeo link then).

[inactinique]

Isn't there that there should be the two videos? (ffmpeg code)

[eliselavy]

@biumiamy apparenlty it's you that have the version on vimeo of the animation , otherwise need to upload this on vimeo
https://github.com/jdh-observer/ZDFmmD3xv4S7/blob/main/media/pollution_animation_ENFR.mp4
and this one also
https://github.com/jdh-observer/ZDFmmD3xv4S7/blob/main/media/pollution_ENFR_Esch.mp4

[biumiamy]

here are the two videos that are in their repo hosted on vimeo: pollution animation pollution Esch

they are already on vimeo

[biumiamy]

Question:
At the end of the introduction, you explain the structure of your article, by referring to section 2, section 3, etc. As this is not the way we display sections, I have replaced those references to the actual titles of sections.

Answer:
I’ve just noticed that when clicking on the links, it brings you to the middle of the section and not to the beginning, it’s not a big deal, just in case you want to check that.

Remark about the videos:
Yes, the two videos in the media folder of Github are the final ones, and they can be uploaded to Vimeo. Do we have an account of the university/C2DH, are you uploading them or do you want me to do it? Just let me know.

Question:
Could you tell us where they should be precisely, or confirm that the first video should be after the cell ‘The visualisations were subsequently animated to show the evolution over time.’ (or rather after the code cell following this one) and that the second video should be before the cell starting with ‘The videos were integrated into a dedicated page of the Minett Stories virtual exhibition’.

Answer:
The first video should go right after the code generated in cell 38, so first the text in 37 “The visualisations were subsequently animated to show the evolution over time.”,then the code, then the general video “pollution_animation_ENFR.mp4”. The second video “pollution_ENFR_Esch.mp4” should go after the code in cell 41, so first the text in 39 “To visualise the impact of pollution in the inhabited quarters of Esch, we repeated the process with a zoomed-in map, thus highlighting the immediate vicinity of the Belval plant.”, then two cells with code and then the video right before the text in cell 42. The links in cell 42 are correct, it’s a different video including the narrative.

Remark:
I’ve just noticed while reviewing it that the text in cell 30 “The dust concentrations around the Belval plant (in g/) were visualised using a contour map with ten predefined levels…” it should say “nine levels” instead of ten to match the last update of the code. Maybe you can also do that small change.

[biumiamy]

Hum. Some paragraphs are badly numbered.

I just found out the reason.. its all in just one cell. Should I just separate it a bit by paragraph? But then I need to do it for the whole article.. this pattern is consistently everywhere. @inactinique

[eliselavy]

@biumiamy I remove all the width mention to the notebook ( size now 28.2 MB before 38.8 MB)
can you check if any issue https://github.com/jdh-observer/ZDFmmD3xv4S7/blob/remove-width/skim-article.ipynb

i see you made already some improvment on the pictures jdh-observer/ZDFmmD3xv4S7@0927c11 ,

[eliselavy]

Problem code no more run

Files have been renamed :
jdh-observer/ZDFmmD3xv4S7@0927c11
They are used in the code...
@biumiamy

img= plt.imread("media/All_FR_EN.jpg")
img = plt.imread("media/Esch_ENFR.jpg")

[biumiamy]

Okay so I replaced all images again with JPG, that makes it much smaller in size. But I added again the original 3 images that are used in the code part (now JPG, not PNG). Finally they are really big, so not sure they need to stay this way?

I tried different size versions, but either way, they are displayed in a very strang way:

Normally it should like this I believe:

Otherwise, in the code they are not missing anymore, but I have this error:

[eliselavy]

@biumiamy this error is linked to the missing matplotlib's toolkit module. Be sure to have following package installed: https://github.com/jdh-observer/ZDFmmD3xv4S7/blob/remove-width/requirements.txt

by the way, i execute the code on my side, problem with the images: before all images where in png, you replace in jpg
i update the code to take into account the jpg format
this doesn't work for the part where 2 images are displayed, cf figure 7
need to keep PNG
we are in the branch remove-width

[biumiamy]

All images are now JPG except for the code section where they are PNG. I debugged some of the code as well. Now everything should work
PR: jdh-observer/ZDFmmD3xv4S7#7 in remove-width branch

[eliselavy]

All images are now JPG except for the code section where they are PNG. I debugged some of the code as well. Now everything should work PR: jdh-observer/ZDFmmD3xv4S7#7 in remove-width branch
@biumiamy
jdh-observer/ZDFmmD3xv4S7#7 (review)

[eliselavy]

@biumiamy problem labels

for label we can used the one defined in Remix project https://minett-stories.lu/en/document/ch8-Timelaps

[eliselavy]

Fixed realted issues for video
DOI: JDH.2023.0016.R1

[inactinique]

JDH.2023.0016 (R1 is related to the peer review version of the article. Not obliged to put it).

[eliselavy]

JDH.2023.0016 (R1 is related to the peer review version of the article. Not obliged to put it).

In production https://journalofdigitalhistory.org/en/article/ZDFmmD3xv4S7 , can be sent to the author for final check before launching social campaign

One question of affiliation that has been changed since the redaction of the article, orcid url

[eliselavy]

Remarks from the author to be integrated:

comments, listed per paragraph:

3: © the results -> (c) the results
5: ( Uekötter 2020 ). -> ( Uekötter 2020 )).
5: Mosley 2001 ). -> Mosley 2001 )).
6: The lines between brackets should be placed directly after "themselves".
15: ( Uekötter 2017 ). -> ( Uekötter 2017 )).
Caption fig. 3: delete Denis
45, and also twice in 46, and once in 111:( Kritik in Punkto Umweltschutz - 'Elo... um richtege Wé...?' 1974 ). -> (Hoffmann 1974)
90: and (Table 1). ->and (Table 1)).
Merge paragraphs 93 and 94
100: delete field of occupational medicine in (field of occupational medicine ( Gochfeld 2005 )).
110: delete the comma in of the model),).
116: delete the comma in 1970s),.

Also, I'm wondering if there is a way to have brackets "glued" to the references, instead of having them for instance appear as

see (
Brüggemeier, Rommelspacher 1992 , Mosley 2001 ).

This occurs throughout the text, and it looks really weird.

Finally, I noted that the first image misses its caption.

[biumiamy]

comments to changes:

• 3: (c) always makes © - so I changed it to a), b) and c)
• change in Juypter citation in Jupyter: 45, and also twice in 46, and once in 111:( Kritik in Punkto Umweltschutz - 'Elo... um richtege Wé...?' 1974 ). -> (Hoffmann 1974)
• brackets "glued" to the references? -> second person to complain
• first img misses caption (all of them do always)

[biumiamy]

Ah for the citation, it is shown in the wrong way because it was not well made in Zotero..
it should show the author and year, not the title

@eliselavy where can I edit the notebook metadata of all citations again? I cannot find it anymore..
or do we need to change it in Zotero?

[eliselavy]

Ah for the citation, it is shown in the wrong way because it was not well made in Zotero.. it should show the author and year, not the title

@eliselavy where can I edit the notebook metadata of all citations again? I cannot find it anymore.. or do we need to change it in Zotero?

fix

[jdh-observer]

• citation fixed in notebook metadata

[biumiamy]

• so finally the sync is still working? merging md and jupyter?

[biumiamy]

Anyway, now its okay. ready to go

[eliselavy]

@inactinique correction requested by author has been integrated - licence was in smb://atlas.uni.lux/C2DH_JDH/licence jdh003 - digital tools , i move it to smb://atlas.uni.lux/C2DH_JDH/licence jdh004 - varia
@biumiamy tweets are there https://github.com/jdh-observer/ZDFmmD3xv4S7/blob/main/tweets.md for the social media campain

[biumiamy]

scheduled on FB and bluesky for later today