Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy-editing - design review - Chronoferencing the Italian-Slovenian Borderlands. Citizen Science, Oral History and Output Criticism #178

Closed
eliselavy opened this issue Sep 4, 2024 · 54 comments
Assignees
Labels
publish-social-media ready to publish on social media

Comments

@eliselavy
Copy link
Collaborator

eliselavy commented Sep 4, 2024

@eliselavy eliselavy self-assigned this Sep 4, 2024
eliselavy added a commit to jdh-observer/6ig87tC5GKjQ that referenced this issue Sep 4, 2024
@eliselavy
Copy link
Collaborator Author

Sent for copy-editing

@eliselavy
Copy link
Collaborator Author

@biumiamy copy-editing can be inserted

very small corrections, only on pages 20 and 27

eliselavy added a commit to jdh-observer/6ig87tC5GKjQ that referenced this issue Sep 18, 2024
@biumiamy
Copy link
Collaborator

biumiamy commented Sep 23, 2024

done:
jdh-observer/6ig87tC5GKjQ#4

eliselavy added a commit to jdh-observer/6ig87tC5GKjQ that referenced this issue Sep 23, 2024
@eliselavy
Copy link
Collaborator Author

eliselavy commented Sep 23, 2024

ok consolidation made
I need to do the desanomization
otherwise no design issue @biumiamy ?

@biumiamy
Copy link
Collaborator

biumiamy commented Sep 23, 2024

I'm correcting missing spaces

2024-09-23 14_51_52-Journal of Digital History

And this makes no sense btw? maybe a citation got lost?

2024-09-23 14_50_50-Journal of Digital History

@biumiamy
Copy link
Collaborator

done. I did it in the md file
jdh-observer/6ig87tC5GKjQ#5

eliselavy added a commit to jdh-observer/6ig87tC5GKjQ that referenced this issue Sep 23, 2024
eliselavy added a commit to jdh-observer/6ig87tC5GKjQ that referenced this issue Sep 23, 2024
@eliselavy
Copy link
Collaborator Author

eliselavy commented Sep 23, 2024

consolidation
desanomysation made

citation is there in the notebook
Screenshot 2024-09-23 at 17 40 30

but missing author in the metadata needs to recheck in zotero

"8820477/X9UECV7S": {
        "id": "8820477/X9UECV7S",
        "title": "Van Houtum and Van Naerssen - 2002 - Bordering, Ordering and Othering.pdf",
        "type": "article"
      },

eliselavy added a commit to jdh-observer/6ig87tC5GKjQ that referenced this issue Sep 23, 2024
@eliselavy
Copy link
Collaborator Author

eliselavy commented Sep 23, 2024

consolidation desanomysation made

citation is there in the notebook Screenshot 2024-09-23 at 17 40 30

but missing author in the metadata needs to recheck in zotero

"8820477/X9UECV7S": {
        "id": "8820477/X9UECV7S",
        "title": "Van Houtum and Van Naerssen - 2002 - Bordering, Ordering and Othering.pdf",
        "type": "article"
      },

ok fixed
Screenshot 2024-09-23 at 17 58 08

@eliselavy
Copy link
Collaborator Author

@biumiamy need to say if skim or not
and look at media folder if some reduction can be made as article > 26MB

@biumiamy
Copy link
Collaborator

biumiamy commented Sep 25, 2024

Skim and I reduced the file size of some of the biggest audio files:
jdh-observer/6ig87tC5GKjQ#7

I used this: https://www.xconvert.com/compress-m4v

@eliselavy
Copy link
Collaborator Author

good rerun nbconvert - now article 17,3MB against 26,3MB before

@eliselavy
Copy link
Collaborator Author

@eliselavy
Copy link
Collaborator Author

eliselavy commented Sep 25, 2024

oups to remove
Screenshot 2024-09-25 at 10 05 05

@eliselavy
Copy link
Collaborator Author

citation to fixed
Screenshot 2024-09-25 at 10 04 57

@eliselavy eliselavy assigned inactinique and biumiamy and unassigned eliselavy Sep 25, 2024
@eliselavy eliselavy added final-author-check Last check of the author after article was published and removed design_review labels Sep 25, 2024
eliselavy added a commit to jdh-observer/6ig87tC5GKjQ that referenced this issue Sep 25, 2024
@eliselavy eliselavy added design_review and removed final-author-check Last check of the author after article was published labels Jan 3, 2025
@eliselavy
Copy link
Collaborator Author

@biumiamy update in prod for dialogue

Image

@biumiamy
Copy link
Collaborator

biumiamy commented Feb 24, 2025

So finally process is:

  • download zip of author's new repo and check what they did (locally)
  • BUT: make changes in the jdh-observer repo in a separate branch

implemented changes:

  • trimmed the empty space around figure 1
  • added video tag (instead of figure)
  • convert all monologues to dialogue and add tags

@biumiamy
Copy link
Collaborator

biumiamy commented Feb 26, 2025

here is the PR: jdh-observer/6ig87tC5GKjQ#11

the problem is.. that it looks inconsistent yes. Example:

Image

  • dialogue 4 is running text (without br) (this is to demonstrate the monologue I think)
  • dialogue 5 shows a part of it with breaks
  • dialogue 6 shows it as running text again.. but I think this is how the author wanted it. Can we see the original from before somewhere still?
  • and also when its only one person in the dialog.. that the name is still on the left but the text on the right side..

@biumiamy
Copy link
Collaborator

biumiamy commented Feb 26, 2025

the plotly (figure 2) is missing two lines before:
!pip install plotly
!pip install --upgrade pip

but I cannot add it in Jupyter Lab, I always get this error:

Image

@biumiamy
Copy link
Collaborator

Now I could edit it again. But still doesnt show the graph:

Image

@eliselavy
Copy link
Collaborator Author

Now I could edit it again. But still doesnt show the graph:

Image

for the plotly , the library is defined in the requirements.txt : https://github.com/jdh-observer/6ig87tC5GKjQ/blob/main/requirements.txt

is the notebook trusted, otherwise plotly not displayed?

@biumiamy
Copy link
Collaborator

in previous versions it was always displayed without any issues 🤔

eliselavy added a commit to jdh-observer/6ig87tC5GKjQ that referenced this issue Feb 27, 2025
@eliselavy
Copy link
Collaborator Author

in previous versions it was always displayed without any issues 🤔

plotly fixed - https://journalofdigitalhistory.org/en/article/6ig87tC5GKjQ?idx=30

@eliselavy
Copy link
Collaborator Author

@eliselavy
Copy link
Collaborator Author

@biumiamy C2DH/journal-of-digital-history#691 fixed - can be sent for final author check?

eliselavy added a commit to jdh-observer/6ig87tC5GKjQ that referenced this issue Mar 13, 2025
eliselavy added a commit to jdh-observer/6ig87tC5GKjQ that referenced this issue Mar 13, 2025
@eliselavy
Copy link
Collaborator Author

eliselavy commented Mar 13, 2025

@biumiamy for the label the snippet of code to use is:
display(IFrame(src_url, width=608, height=402), metadata=metadata)

Not:
IFrame(src_url, width=608, height=402, metadata=metadata)

@biumiamy
Copy link
Collaborator

this issue wasnt processed yet: C2DH/journal-of-digital-history#694

@eliselavy
Copy link
Collaborator Author

this issue wasnt processed yet: C2DH/journal-of-digital-history#694

to be tested in dev: http://10.240.4.179/ @biumiamy

@eliselavy eliselavy added publish-social-media ready to publish on social media and removed design_review labels Mar 20, 2025
@eliselavy
Copy link
Collaborator Author

eliselavy commented Mar 20, 2025

@inactinique article published - licence ?
@biumiamy social media cover to generate - tweets are in the repo

@biumiamy
Copy link
Collaborator

biumiamy commented Mar 21, 2025

  • fingerprint replaced
  • sent email with implemented changes to Johanna (ah no, her email is no longer active - how can we contact her? or never mind?)

@eliselavy
Copy link
Collaborator Author

  • fingerprint replaced
  • sent email with implemented changes to Johanna (ah no, her email is no longer active - how can we contact her? or never mind?)

@inactinique licence staved in atlas
@biumiamy author contacted by @inactinique on her gmail address

@biumiamy
Copy link
Collaborator

email:

Thank you very much for your email. I am very happy seeing the paper has been published. I sent the signed document to Machteld and she will send it to you soon.

When opening the article on my phone I noticed that it is not correctly displayed. I checked other articles and this does not seem to be a problem there. I just wanted to inform you about this. You can find a screenshot attached to this email.

Thanks again and best wishes,
Johanna

-> ready to schedule for social media

@biumiamy
Copy link
Collaborator

scheduled for today on FB and bluesky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
publish-social-media ready to publish on social media
Projects
None yet
Development

No branches or pull requests

4 participants