Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical + design review, copy-editing after accept: The Text Analysis Prototype for Galileo's Library and Letters Online: GaLiLeO #193

Open
inactinique opened this issue Jan 28, 2025 · 19 comments
Assignees

Comments

@inactinique
Copy link
Collaborator

PID: FYjDViXVXggz
Github jdh-observer repo: https://github.com/jdh-observer/FYjDViXVXggz
Github author repo: https://github.com/crystaljhall/GaLiLeO_JDH/tree/master

@eliselavy

eliselavy added a commit to jdh-observer/FYjDViXVXggz that referenced this issue Jan 28, 2025
@eliselavy
Copy link
Collaborator

No merge to do :
Sent to peer-review in august #172 (comment)
no change in the repo : https://github.com/crystaljhall/GaLiLeO_JDH/commits/master/The-Text-Analysis-Prototype-for-Galileo's-Library-and-Letters-Online-(GaLiLeO).ipynb

Sent to copy-editing

@eliselavy
Copy link
Collaborator

eliselavy added a commit to jdh-observer/FYjDViXVXggz that referenced this issue Feb 4, 2025
@biumiamy
Copy link
Collaborator

biumiamy commented Mar 4, 2025

copyediting done, PR merged

@biumiamy
Copy link
Collaborator

biumiamy commented Mar 4, 2025

For the design review already:

  • this author keeps having the references in brackets at the beginning of the sentence. I think it might be connected to the previous sentence though? @inactinique

Image

Image

@biumiamy
Copy link
Collaborator

biumiamy commented Mar 4, 2025

Is this an anchor to figure 3? or is it linked to the figure below (which is figure 2 though..)

Image

@biumiamy
Copy link
Collaborator

biumiamy commented Mar 4, 2025

would be nice to have an interactive chart instead of a static one (but I guess the tool (Galileo) the author uses only provides static img?

Image

@biumiamy
Copy link
Collaborator

biumiamy commented Mar 4, 2025

maybe show this in a table with 3 columns to save space and make it more readable? any other form of visualization would be beneficial for the reader

Image

@biumiamy
Copy link
Collaborator

biumiamy commented Mar 6, 2025

@biumiamy will make an alternative suggestion for the stop words

@biumiamy
Copy link
Collaborator

biumiamy commented Mar 7, 2025

Btw he refers to a section.. which one is it? then I can add an anchor

Image

@biumiamy
Copy link
Collaborator

biumiamy commented Mar 7, 2025

can add an anchor here too

Image

@biumiamy
Copy link
Collaborator

biumiamy commented Mar 7, 2025

in fact all figures keep being mentioned.. but I dont know if the reference is still correct always. I think they are all -1

Image

@biumiamy
Copy link
Collaborator

biumiamy commented Mar 7, 2025

Okay, I found the information in the author's repo 👍

Image

@biumiamy
Copy link
Collaborator

biumiamy commented Mar 7, 2025

and more section mentioning:

Image

Image

@biumiamy
Copy link
Collaborator

biumiamy commented Mar 7, 2025

and in the author's original repo ipynb are the sections:

Image

@biumiamy
Copy link
Collaborator

biumiamy commented Mar 10, 2025

How can I edit sth when the notebook is in R?

Image

I would like to try this:

# Sort the stop words alphabetically
sorted_stop_words <- sort(stop_words, decreasing = FALSE)

# Define the number of columns (e.g., 4)
num_cols <- 4

# Convert into a matrix to format it in multiple columns
stop_words_matrix <- matrix(
sorted_stop_words,
ncol = num_cols,
byrow = TRUE
)

# Convert to tibble for better formatting
stop_words_tibble <- as_tibble(stop_words_matrix)

# Rename columns for readability
colnames(stop_words_tibble) <- paste("Column", 1:num_cols)

# Print in Markdown format for Jupyter Notebook
knitr::kable(stop_words_tibble, format = "markdown")

@eliselavy
Copy link
Collaborator

eliselavy commented Mar 10, 2025

How can I edit sth when the notebook is in R?

Image

I would like to try this:

# Sort the stop words alphabetically sorted_stop_words <- sort(stop_words, decreasing = FALSE)

Define the number of columns (e.g., 4)

num_cols <- 4

Convert into a matrix to format it in multiple columns

stop_words_matrix <- matrix( sorted_stop_words, ncol = num_cols, byrow = TRUE )

Convert to tibble for better formatting

stop_words_tibble <- as_tibble(stop_words_matrix)

Rename columns for readability

colnames(stop_words_tibble) <- paste("Column", 1:num_cols)

Print in Markdown format for Jupyter Notebook

knitr::kable(stop_words_tibble, format = "markdown")``

@biumiamy used the docker stack for R https://github.com/C2DH/journal-of-digital-history-jupyter-stack?tab=readme-ov-file#for-rs-user or launch via mybinder and execute and downlaod the notebook after .

@eliselavy
Copy link
Collaborator

Problem with mybinder

unable to find user jovyan: no matching entries in passwd file
------
 > [7/8] RUN chmod -R u+w /home/jovyan:
------
Dockerfile:29
--------------------
  27 |     
  28 |     # Set permissions for the notebook files
  29 | >>> RUN chmod -R u+w /home/${NB_USER}
  30 |     
  31 |     # Ensure the .ipynb_checkpoints directory exists and has the correct permissions
--------------------
ERROR: failed to solve: process "/bin/sh -c chmod -R u+w /home/${NB_USER}" did not complete successfully: unable to find user jovyan: no matching entries in passwd file
Error during build: Command '['docker', 'buildx', 'build', '--progress', 'plain', '--push', '--build-arg', 'NB_USER=jovyan', '--build-arg', 'NB_UID=1000', '--file', 'Dockerfile', '--tag', 'registry.2i2c.mybinder.org/i-jdh-2dobserver-2dfyjdvixvxggz-a9dda8:8d0fadc53d5675dd306b0dd234cac00e100a529e', '--label', 'repo2docker.version=2024.07.0+159.gd0ddd2e', '--label', 'repo2docker.repo=https://github.com/jdh-observer/FYjDViXVXggz', '--label', 'repo2docker.ref=8d0fadc53d5675dd306b0dd234cac00e100a529e', '--platform', 'linux/amd64', '/tmp/repo2dockervxe9u3gd']' returned non-zero exit status 1.

@eliselavy
Copy link
Collaborator

@biumiamy by using the anaconda distribution now by default there is Python and R kernel

Image

@biumiamy
Copy link
Collaborator

Okay I see thx! I will give each a shot :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants