Skip to content

Muphys: Use view node in self-copy removal SDFG transformation#1069

Merged
edopao merged 5 commits intoouter_mask_graupel_rmcopies2from
muphy_remove_self_copies
Mar 20, 2026
Merged

Muphys: Use view node in self-copy removal SDFG transformation#1069
edopao merged 5 commits intoouter_mask_graupel_rmcopies2from
muphy_remove_self_copies

Conversation

@edopao
Copy link
Copy Markdown
Contributor

@edopao edopao commented Feb 19, 2026

No description provided.

@edopao
Copy link
Copy Markdown
Contributor Author

edopao commented Feb 19, 2026

cscs-ci run dace

Comment thread model/common/src/icon4py/model/common/dace_hooks.py Outdated
@edopao
Copy link
Copy Markdown
Contributor Author

edopao commented Feb 19, 2026

cscs-ci run dace

@edopao
Copy link
Copy Markdown
Contributor Author

edopao commented Feb 20, 2026

R2B06 benchmark on latest icon4py:main (which includes the inout t field) and gt4py:v1.1.4.

Baseleine           vs  Self-copy Removal
0.8063652515411377      0.7960093021392822
0.8046061992645264      0.7870404720306396
0.800187349319458       0.8077375888824463
0.7698495388031006      0.8004043102264404
0.8041069507598877      0.7910645008087158
0.7722852230072021      0.7776751518249512
0.7911474704742432      0.7825534343719482
0.7928476333618164      0.7938387393951416
0.7766461372375488      0.7829110622406006
0.8041651248931885      0.8013942241668701

There is no clear improvement.

@edopao
Copy link
Copy Markdown
Contributor Author

edopao commented Mar 3, 2026

The speedup is very small, on latest baseline. We decided to exclude this change, for now.

@edopao edopao closed this Mar 3, 2026
@edopao edopao reopened this Mar 20, 2026
@edopao edopao changed the base branch from main to outer_mask_graupel_rmcopies2 March 20, 2026 13:03
@github-actions
Copy link
Copy Markdown

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • cscs-ci run distributed

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark-bencher

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:

  • cscs-ci run extra

For more detailed information please look at CI in the EXCLAIM universe.

@edopao edopao changed the title Muphys: Remove self-copy in else-branch of mask expressions Muphys: Use view node in self-copy removal SDFG transformation Mar 20, 2026
@edopao edopao requested a review from iomaganaris March 20, 2026 13:16
@edopao edopao marked this pull request as ready for review March 20, 2026 13:18
@edopao edopao merged commit c705bfa into outer_mask_graupel_rmcopies2 Mar 20, 2026
1 check passed
@edopao edopao deleted the muphy_remove_self_copies branch March 20, 2026 13:18
edopao added a commit that referenced this pull request Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants