Bug solved: Shift before ceil was in the wrong direction

LeoValque · LeoValque · commit 3b29156f2937 · 2025-02-25T09:41:09.000+01:00
diff --git a/Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/triangle_soup_snap_rounding.h b/Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/triangle_soup_snap_rounding.h
@@ -183,7 +183,9 @@ bool polygon_soup_snap_rounding(PointRange &points,
   auto snap = [](typename Kernel::FT x, double scale)
   {
     // Scale the coordinate, round to nearest integer and scale back
-    return internal::ceil((x * scale) + 0.5) / scale;
+    // TODO replace this ceil by the one of Algebraic_fondation when it will be add to master
+    return internal::ceil((x * scale) - 0.5) / scale;
+    // return ceil((x * scale) - 0.5) / scale;
   };
   auto snap_p = [scale, snap](const Point_3 &p)
   {

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,9 @@ bool polygon_soup_snap_rounding(PointRange &points,`
`183`	`183`	`auto snap = [](typename Kernel::FT x, double scale)`
`184`	`184`	`{`
`185`	`185`	`// Scale the coordinate, round to nearest integer and scale back`
`186`		`- return internal::ceil((x * scale) + 0.5) / scale;`
	`186`	`+ // TODO replace this ceil by the one of Algebraic_fondation when it will be add to master`
	`187`	`+ return internal::ceil((x * scale) - 0.5) / scale;`
	`188`	`+ // return ceil((x * scale) - 0.5) / scale;`
`187`	`189`	`};`
`188`	`190`	`auto snap_p = [scale, snap](const Point_3 &p)`
`189`	`191`	`{`