Deprecated declarations relative to triangulate_and_refine_hole

[stla]

Hello,

While compiling my R package, g++ v12 finds the following "significant warnings" (not acceptable by CRAN):

  MODULE.h:1063: warning: ‘std::tuple<bool, FaceOutputIterator, VertexOutputIterator> CGAL::Polygon_mesh_processing::triangulate_refine_and_fair_hole(PolygonMesh&, typename boost::graph_traits<Graph>::halfedge_descriptor, FaceOutputIterator, VertexOutputIterator, const CGAL::Named_function_parameters<NP_T2, NP_Tag2, NP_Base2>&) [with PolygonMesh = CGAL::Surface_mesh<CGAL::Point_3<CGAL::Epeck> >; FaceOutputIterator = std::back_insert_iterator<std::vector<CGAL::SM_Face_index> >; VertexOutputIterator = std::back_insert_iterator<std::vector<CGAL::SM_Vertex_index> >; NP_T = bool; NP_Tag = CGAL::internal_np::all_default_t; NP_Base = CGAL::internal_np::No_property; typename boost::graph_traits<Graph>::halfedge_descriptor = CGAL::SM_Halfedge_index]’ is deprecated [-Wdeprecated-declarations]
  MODULE.h:1072: warning: ‘std::pair<_Tp1, _Tp2> CGAL::Polygon_mesh_processing::triangulate_and_refine_hole(PolygonMesh&, typename boost::graph_traits<Graph>::halfedge_descriptor, FaceOutputIterator, VertexOutputIterator, const CGAL::Named_function_parameters<NP_T2, NP_Tag2, NP_Base2>&) [with PolygonMesh = CGAL::Surface_mesh<CGAL::Point_3<CGAL::Epeck> >; FaceOutputIterator = std::back_insert_iterator<std::vector<CGAL::SM_Face_index> >; VertexOutputIterator = std::back_insert_iterator<std::vector<CGAL::SM_Vertex_index> >; NP_T = bool; NP_Tag = CGAL::internal_np::all_default_t; NP_Base = CGAL::internal_np::No_property; typename boost::graph_traits<Graph>::halfedge_descriptor = CGAL::SM_Halfedge_index]’ is deprecated [-Wdeprecated-declarations]

Could you enlighten me please? What is deprecated and what should I do? Here is my code:

  Rcpp::XPtr<EMesh3> fillBoundaryHole(int border, bool fairhole) {
    std::vector<halfedge_descriptor> border_cycles;
    PMP::extract_boundary_cycles(mesh, std::back_inserter(border_cycles));
    const int nborders = border_cycles.size();
    if(nborders == 0) {
      Rcpp::stop("There's no border in this mesh.");
    } 
    if(border >= nborders) {
      std::string msg;
      if(nborders == 1) {
        msg = "There's only one border in this mesh.";
      } else {
        msg = "There are only " + std::to_string(nborders) + " borders.";
      }
      Rcpp::stop(msg);
    }
    halfedge_descriptor h = border_cycles[border];
    std::vector<face_descriptor>   patch_faces;
    std::vector<vertex_descriptor> patch_vertices;
    if(fairhole) {
      const bool success = std::get<0>(
        PMP::triangulate_refine_and_fair_hole( // <-- this is line 1063
          mesh, h, 
          std::back_inserter(patch_faces), std::back_inserter(patch_vertices)
        )
      );
      if(!success) {
        Message("Fairing failed.");
      }
    } else {
      PMP::triangulate_and_refine_hole( // <-- this is line 1072
        mesh, h, 
        std::back_inserter(patch_faces), std::back_inserter(patch_vertices)
      );
    }
    Face_index_map fimap = mesh.add_property_map<face_descriptor, std::size_t>(
      "f:i", 0
    ).first;
    for(int i = 0; i < patch_faces.size(); i++) {
      fimap[patch_faces[i]] = 2;
    }
    EMesh3 hole;
    Filtered_graph ffg(mesh, 2, fimap);
    CGAL::copy_face_graph(ffg, hole);
    mesh.remove_property_map(fimap);
    return Rcpp::XPtr<EMesh3>(new EMesh3(hole), false);
  }

It's CGAL 5.6 compiled in C++17.

[sloriot]

Should be something like:

triangulate_refine_and_fair_hole(mesh, h, CGAL::parameters::face_output_iterator(std::back_inserter(patch_faces)).
                                                            vertex_output_iterator(std::back_inserter(patch_vertices));

[stla]

Thanks. I'm going to try now.