Ridges 3 bug fix doc pougetma #8440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pougetma Thanks for the PR. Do you agree that shipping the data is actually not needed and only the text should be updated? |
|
Do you mean I need to store the data outside of CGAL? I’m not aware of the practice of data management within cgal.
The 2 examples are light weight, so it seemed reasonable to have them in cgal.
M.
… On 29 Aug 2024, at 10:38, Sebastien Loriot ***@***.***> wrote:
@pougetma <https://github.com/pougetma> Thanks for the PR. Do you agree that shipping the data is actually not needed and only the text should be updated?
—
Reply to this email directly, view it on GitHub <#8440 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACWJZMF3F4UKFU6NMPY7RE3ZT3MZNAVCNFSM6AAAAABNIQUWVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJXGAZTGMJVGA>.
You are receiving this because you were mentioned.
|
|
Well, it does increase the history size of 0.5MB and I don't see any added value: None of them are used in tests, rocker-arm.off is a plain copy of aim@shape data and the ellipsoid could be regenerated using an implicit function with |
|
Ok, agree, I removed the data files |
sloriot
force-pushed
the
Ridges_3-bug_fix-doc-pougetma
branch
from
c90109c
to
24ca2df
Compare
|
Successfully tested in CGAL-6.0-Ic-318 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Add a rep example/data with 2 off files
Release Management
Solves issue 8327
#8327