Make it possible to enter target coordinates to move a point #8755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1838,7 +1838,7 @@ void Viewer::setLighting() | |||
| if (list.size()!=3){ | |||
| QMessageBox *msgBox = new QMessageBox; | |||
| msgBox->setWindowTitle("Error"); | |||
| msgBox->setText("ERROR : Input should consists of 3 floats."); | |||
| msgBox->setText("ERROR : Input should consist of 3 floats."); | |||
There was a problem hiding this comment.
Instead of "floats" wouldn't it be better to use "floating point numbers"
| @@ -69,7 +69,7 @@ public slots: | |||
| if (list.size()!=4){ | |||
| QMessageBox *msgBox = new QMessageBox; | |||
| msgBox->setWindowTitle("Error"); | |||
| msgBox->setText("ERROR : Input should consists of 4 doubles: The radius first, then the coordinates of the center."); | |||
| msgBox->setText("ERROR : Input should consist of 4 doubles: The radius first, then the coordinates of the center."); | |||
There was a problem hiding this comment.
Instead of "doubles" wouldn't it be better to use "floating point numbers"
|
Successfully tested in CGAL-6.1-Ic-104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Modifying coordinates in the files and reloading is painful, so this PR adds a way to specify new coordinates from the selection item:
Screencast.From.2025-02-26.00-10-02.mp4
Release Management
Lab