Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lab - Fixes for C3t3 IO in .vtu format #8757

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Lab - Fixes for C3t3 IO in .vtu format #8757

merged 2 commits into from
Mar 7, 2025

Conversation

janetournois
Copy link
Member

@janetournois janetournois commented Feb 27, 2025 •
edited
Loading

Summary of Changes

  • Subdomain indices can be 0 or negative, just the cells with subdomain 0 are not added to the complex.
  • make binary status of the opened ofstream consistent with call to CGAL::IO::output_to_vtu()

Release Management

  • Affected package(s): CGAL Lab
  • License and copyright ownership: unchanged

@janetournois janetournois added this to the 6.0.2 milestone Feb 27, 2025
@janetournois janetournois changed the title Read *.vtu files in demo - deal with cells with subdomain_index 0 Lab - Fixes for C3t3 IO in .vtu format Feb 27, 2025
@sloriot
Copy link
Member

sloriot commented Mar 7, 2025

Successfully tested in CGAL-6.1-Ic-104

@sloriot sloriot merged commit 82aa7d0 into CGAL:6.0.x-branch Mar 7, 2025
9 checks passed
@sloriot sloriot deleted the Lab-fix_read_vtk-jtournois branch March 7, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug CGAL 3D demo Tested
Projects
None yet
Milestone
6.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@janetournois @sloriot