Skip to content

fail the test on travis #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ky-hg wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fail the test on travis #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49d580d
fail the test on travis
ky-hg Mar 22, 2021
7cc70c9
pass test
ky-hg Mar 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .idea/.gitignore
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .idea/.name
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/compiler.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 25 additions & 0 deletions .idea/jarRepositories.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions .idea/misc.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions app/.idea/.gitignore
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions app/.idea/gradle.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions app/.idea/misc.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions app/.idea/modules.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions app/src/main/java/com/example/simpleparadox/listycity/City.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
package com.example.simpleparadox.listycity;

/**
* the lab says to add a test for functionality that will fail (later implement it, i will choose the city class and have it and set a neighbouring city field
*/
public class City implements Comparable<City>{
private String city;
private String province;
private City neighbour;

City(String city, String province){
this.city = city;
Expand All @@ -17,6 +21,14 @@ String getProvinceName(){
return this.province;
}

public City getNeighbour() {
return neighbour;
}

public void setNeighbour(City neighbour) {
this.neighbour = neighbour;
}

@Override
public int compareTo(City o) {
return city.compareTo(o.getCityName());
Expand Down
1 change: 1 addition & 0 deletions app/src/test/java/com/example/simpleparadox/listycity/CityListTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,4 +93,5 @@ void testCountCities() {

assertEquals(1, cityList.countCities());
}

}
26 changes: 26 additions & 0 deletions app/src/test/java/com/example/simpleparadox/listycity/CityTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
package com.example.simpleparadox.listycity;

import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.*;

public class CityTest {

private City mockCity() {
return new City("Edmonton", "Alberta");
}

private City mockCity1() {
return new City("Calgary", "Alberta");
}

@Test
void SetNeighbourTest(){

City testCity = mockCity();
testCity.setNeighbour(mockCity1());

assertEquals(testCity.getNeighbour().getCityName(),"Calgary");
}

}