Skip to content

added test count deleted city #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alivia-g wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added test count deleted city #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
273d7a2
added test count deleted city
alivia-g Mar 22, 2021
46e1d6e
fixed test failing error
alivia-g Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .idea/.gitignore
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .idea/.name
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/compiler.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 25 additions & 0 deletions .idea/jarRepositories.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions .idea/misc.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions app/src/main/java/com/example/simpleparadox/listycity/CityList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
*/
public class CityList {
private List<City> cities = new ArrayList<>();
private int numberOfCitiesDeleted = 0;

/**
* This adds a city to the list if the city does not exist
Expand Down Expand Up @@ -64,6 +65,7 @@ public void delete(City city) {
for (City c : cities) {
if (c.compareTo(city) == 0){
cities.remove(c);
numberOfCitiesDeleted++;
break;
}
}
Expand All @@ -77,4 +79,11 @@ public void delete(City city) {
public int countCities() {
return cities.size();
}

/**
* Returns the total count of cities being removed
* @return
* An integer representing the number of cities being deleted if any
*/
public int countDeletedCities() { return numberOfCitiesDeleted; }
}
10 changes: 10 additions & 0 deletions app/src/test/java/com/example/simpleparadox/listycity/CityListTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,4 +93,14 @@ void testCountCities() {

assertEquals(1, cityList.countCities());
}

@Test
void testCountDeletedCities() {
CityList cityList = mockCityList();
cityList.add(new City("Ottawa", "ON"));
cityList.delete(cityList.getCities().get(0));
assertEquals(1, cityList.countDeletedCities());
cityList.delete(cityList.getCities().get(0));
assertEquals(2, cityList.countDeletedCities());
}
}