From 2470a1a158e27fc1ac7095256479266598d9a388 Mon Sep 17 00:00:00 2001 From: cnk2024 Date: Tue, 17 Mar 2026 02:35:22 -0400 Subject: [PATCH 1/6] fix: syntax error in jshint workflow --- .github/workflows/jshint,yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/jshint,yaml b/.github/workflows/jshint,yaml index 0c1a3f8a9b..9fa2099060 100644 --- a/.github/workflows/jshint,yaml +++ b/.github/workflows/jshint,yaml @@ -39,4 +39,4 @@ jobs: useLockFile: false - name: Run JShint - - run: ./node_modules/.bin/jshint . \ No newline at end of file + run: ./node_modules/.bin/jshint . \ No newline at end of file From efc38e3ded481f1271d34be5ba024d732dffe73c Mon Sep 17 00:00:00 2001 From: cnk2024 Date: Tue, 17 Mar 2026 02:37:37 -0400 Subject: [PATCH 2/6] fix: syntax error in jshint workfile --- .github/workflows/{jshint,yaml => jshint.yaml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/workflows/{jshint,yaml => jshint.yaml} (100%) diff --git a/.github/workflows/jshint,yaml b/.github/workflows/jshint.yaml similarity index 100% rename from .github/workflows/jshint,yaml rename to .github/workflows/jshint.yaml From 3053aff667c6206b10f61cd08b7a09a5870d93c5 Mon Sep 17 00:00:00 2001 From: cnk2024 Date: Tue, 17 Mar 2026 02:44:34 -0400 Subject: [PATCH 3/6] feat: configured github action for JShint - Only runs JShint on modified files in PR - Does not fail checks if potential issues found (JShint prone to false positives or flagging trivial issues) --- .github/workflows/jshint.yaml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/.github/workflows/jshint.yaml b/.github/workflows/jshint.yaml index 9fa2099060..22527c3033 100644 --- a/.github/workflows/jshint.yaml +++ b/.github/workflows/jshint.yaml @@ -39,4 +39,14 @@ jobs: useLockFile: false - name: Run JShint - run: ./node_modules/.bin/jshint . \ No newline at end of file + run: | + git fetch origin main + FILES=$(git diff --name-only origin/main...HEAD | grep '\.js$' || true) + + if [ -z "$FILES" ]; then + echo "No JS files changed" + else + echo "Running JSHint on:" + echo "$FILES" + ./node_modules/.bin/jshint $FILES || echo "JSHint found potential issues. You may want to review them" + fi \ No newline at end of file From d8002f41052f0e3d6a1736c650d82b6f502d58bc Mon Sep 17 00:00:00 2001 From: cnk2024 Date: Tue, 17 Mar 2026 02:51:13 -0400 Subject: [PATCH 4/6] fix: fixed fatal diff error in jshint action - Made trivial edit to js file to test action --- .github/workflows/jshint.yaml | 2 ++ src/admin/search.js | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/jshint.yaml b/.github/workflows/jshint.yaml index 22527c3033..0bf85b6507 100644 --- a/.github/workflows/jshint.yaml +++ b/.github/workflows/jshint.yaml @@ -25,6 +25,8 @@ jobs: steps: - uses: actions/checkout@v4 + with: + fetch-depth: 0 - run: cp install/package.json package.json diff --git a/src/admin/search.js b/src/admin/search.js index a1ba466191..daa05099a7 100644 --- a/src/admin/search.js +++ b/src/admin/search.js @@ -139,4 +139,4 @@ module.exports.filterDirectories = filterDirectories; module.exports.simplify = simplify; module.exports.sanitize = sanitize; -require('../promisify')(module.exports); +require('../promisify')(module.exports); \ No newline at end of file From 580e3d4d982cf05bc8eb22595761cc19f2f66b05 Mon Sep 17 00:00:00 2001 From: cnk2024 Date: Tue, 17 Mar 2026 02:53:56 -0400 Subject: [PATCH 5/6] test: trivial edit to categories.js to test jshint action --- src/api/categories.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/api/categories.js b/src/api/categories.js index 4806868f93..c909377e28 100644 --- a/src/api/categories.js +++ b/src/api/categories.js @@ -247,4 +247,4 @@ categoriesAPI.setModerator = async (caller, { cid, member, set }) => { const privilegeList = await privileges.categories.getUserPrivilegeList(); await categoriesAPI.setPrivilege(caller, { cid, privilege: privilegeList, member, set }); -}; +}; \ No newline at end of file From f16e8d476ffce0f3813d49400b7dfa265d0ae374 Mon Sep 17 00:00:00 2001 From: cnk2024 Date: Tue, 17 Mar 2026 02:56:47 -0400 Subject: [PATCH 6/6] fix: updated message jshint action --- .github/workflows/jshint.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/jshint.yaml b/.github/workflows/jshint.yaml index 0bf85b6507..ba32fc2455 100644 --- a/.github/workflows/jshint.yaml +++ b/.github/workflows/jshint.yaml @@ -50,5 +50,5 @@ jobs: else echo "Running JSHint on:" echo "$FILES" - ./node_modules/.bin/jshint $FILES || echo "JSHint found potential issues. You may want to review them" + ./node_modules/.bin/jshint $FILES || echo "JSHint found potential issues in modified files." fi \ No newline at end of file