Update .solve() functions with typed time_limit argument
#775
+32
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgnaceBleukx
changed the title
.solve() functions with type arguments.solve() functions with typed arguments
ThomSerg
reviewed
Nov 17, 2025
Collaborator
ThomSerg
left a comment
ThomSerg
left a comment
There was a problem hiding this comment.
Looks good. Maybe change the pull request's title to reflect that this is only for the time_limit argument, and for the others (for example not for solution_limit).
IgnaceBleukx
changed the title
.solve() functions with typed arguments.solve() functions with typed time_limit argument
Dimosts
requested changes
Nov 25, 2025
Collaborator
Dimosts
left a comment
Dimosts
left a comment
There was a problem hiding this comment.
Why only time_limit and not e.g. also solution_limit? I suggest that we should do all that w can in the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the function headers of
solveandsolveAllwith type hints for the time_limit argument.Something weird was the
def solve()function of the superclass, it has some weirdmodelargument which did not make any sense to me; according to git blame it has been there since 2021.Also fixes #745 (new version of gcs)