Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1924 +/- ##
==========================================
- Coverage 83.78% 83.71% -0.07%
==========================================
Files 196 196
Lines 37493 37538 +45
Branches 34306 34351 +45
==========================================
+ Hits 31414 31426 +12
- Misses 4296 4328 +32
- Partials 1783 1784 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and remove logic duplicated in
OpType::port_kindThe main goal here is to enable hugr-py to read in CFGs serialized from Rust, by changing the Rust to output in the same form as the python.
So, to test this...I should write out a file from the Rust test (i.e. comparing against snapshot)...and then load that into a test in python (that checks the CFG still has edges, it won't without this fix). We don't have any code that does this yet AFAICS so this is a draft while that remains TODO.
fixes #1923