CSCEXAM-1491 Fix copying of external assessments questions

lupari · lupari · commit aeb767eb32a4 · 2025-11-28T17:12:50.000+02:00
diff --git a/app/controllers/exam/copy/ExamCopyContext.java b/app/controllers/exam/copy/ExamCopyContext.java
@@ -59,10 +59,8 @@ public boolean isWithAnswers() {
     }
 
     public boolean shouldSetParent() {
-        // Teacher copies, non-collaborative student exams, and copies with answers should have parent set
-        return (
-            copyType == CopyType.TEACHER_COPY || copyType == CopyType.STUDENT_EXAM || copyType == CopyType.WITH_ANSWERS
-        );
+        // Teacher copies and non-collaborative student exams should have parent set
+        return (copyType == CopyType.TEACHER_COPY || copyType == CopyType.STUDENT_EXAM);
     }
 
     public boolean shouldShuffleOptions() {
diff --git a/test/resources/externalExamAttainment.json b/test/resources/externalExamAttainment.json
@@ -193,7 +193,7 @@
             "modified": null,
             "modifier": null,
             "question": {
-              "id": 5,
+              "id": 5555555555,
               "tags": [],
               "type": "MultipleChoiceQuestion",
               "state": null,

Original file line number	Diff line number	Diff line change
`@@ -59,10 +59,8 @@ public boolean isWithAnswers() {`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`public boolean shouldSetParent() {`
`62`		`- // Teacher copies, non-collaborative student exams, and copies with answers should have parent set`
`63`		`- return (`
`64`		`- copyType == CopyType.TEACHER_COPY \|\| copyType == CopyType.STUDENT_EXAM \|\| copyType == CopyType.WITH_ANSWERS`
`65`		`- );`
	`62`	`+ // Teacher copies and non-collaborative student exams should have parent set`
	`63`	`+ return (copyType == CopyType.TEACHER_COPY \|\| copyType == CopyType.STUDENT_EXAM);`
`66`	`64`	`}`
`67`	`65`
`68`	`66`	`public boolean shouldShuffleOptions() {`