Skip to content

Commit a814eae

Browse files
Fix tests
1 parent 53b3519 commit a814eae

File tree

1 file changed

+37
-37
lines changed

1 file changed

+37
-37
lines changed

tests/test_qeventloop.py

Lines changed: 37 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ def write():
357357
exp_num_notifiers = len(loop._read_notifiers) + 1
358358
got_msg = None
359359
fut = asyncio.Future()
360-
loop.add_reader(srv_sock.fileno(), can_read)
360+
loop._add_reader(srv_sock.fileno(), can_read)
361361
assert len(loop._read_notifiers) == exp_num_notifiers, "Notifier should be added"
362362
loop.run_until_complete(asyncio.wait_for(fut, timeout=1.0))
363363

@@ -378,9 +378,9 @@ def can_read():
378378
client_sock, srv_sock = sock_pair
379379

380380
got_msg = None
381-
loop.add_reader(srv_sock.fileno(), can_read)
381+
loop._add_reader(srv_sock.fileno(), can_read)
382382
exp_num_notifiers = len(loop._read_notifiers) - 1
383-
loop.remove_reader(srv_sock.fileno())
383+
loop._remove_reader(srv_sock.fileno())
384384
assert len(loop._read_notifiers) == exp_num_notifiers, "Notifier should be removed"
385385
client_sock.send(b"a")
386386
client_sock.close()
@@ -395,18 +395,18 @@ def test_remove_reader_after_closing(loop, sock_pair):
395395
"""Verify that we can remove a reader callback from an event loop."""
396396
client_sock, srv_sock = sock_pair
397397

398-
loop.add_reader(srv_sock.fileno(), lambda: None)
398+
loop._add_reader(srv_sock.fileno(), lambda: None)
399399
loop.close()
400-
loop.remove_reader(srv_sock.fileno())
400+
loop._remove_reader(srv_sock.fileno())
401401

402402

403403
def test_remove_writer_after_closing(loop, sock_pair):
404404
"""Verify that we can remove a reader callback from an event loop."""
405405
client_sock, srv_sock = sock_pair
406406

407-
loop.add_writer(client_sock.fileno(), lambda: None)
407+
loop._add_writer(client_sock.fileno(), lambda: None)
408408
loop.close()
409-
loop.remove_writer(client_sock.fileno())
409+
loop._remove_writer(client_sock.fileno())
410410

411411

412412
def test_add_reader_after_closing(loop, sock_pair):
@@ -415,7 +415,7 @@ def test_add_reader_after_closing(loop, sock_pair):
415415

416416
loop.close()
417417
with pytest.raises(RuntimeError):
418-
loop.add_reader(srv_sock.fileno(), lambda: None)
418+
loop._add_reader(srv_sock.fileno(), lambda: None)
419419

420420

421421
def test_add_writer_after_closing(loop, sock_pair):
@@ -424,7 +424,7 @@ def test_add_writer_after_closing(loop, sock_pair):
424424

425425
loop.close()
426426
with pytest.raises(RuntimeError):
427-
loop.add_writer(client_sock.fileno(), lambda: None)
427+
loop._add_writer(client_sock.fileno(), lambda: None)
428428

429429

430430
def test_can_add_writer(loop, sock_pair):
@@ -438,16 +438,16 @@ def can_write():
438438

439439
client_sock, _ = sock_pair
440440
fut = asyncio.Future()
441-
loop.add_writer(client_sock.fileno(), can_write)
441+
loop._add_writer(client_sock.fileno(), can_write)
442442
assert len(loop._write_notifiers) == 1, "Notifier should be added"
443443
loop.run_until_complete(asyncio.wait_for(fut, timeout=1.0))
444444

445445

446446
def test_can_remove_writer(loop, sock_pair):
447447
"""Verify that we can remove a writer callback from an event loop."""
448448
client_sock, _ = sock_pair
449-
loop.add_writer(client_sock.fileno(), lambda: None)
450-
loop.remove_writer(client_sock.fileno())
449+
loop._add_writer(client_sock.fileno(), lambda: None)
450+
loop._remove_writer(client_sock.fileno())
451451
assert not loop._write_notifiers, "Notifier should be removed"
452452

453453

@@ -478,7 +478,7 @@ def write():
478478
loop.call_soon(write)
479479

480480
fut = asyncio.Future()
481-
loop.add_reader(srv_sock.fileno(), can_read)
481+
loop._add_reader(srv_sock.fileno(), can_read)
482482
notifier = loop._read_notifiers[srv_sock.fileno()]
483483
loop.run_until_complete(asyncio.wait_for(fut, timeout=1.0))
484484

@@ -503,7 +503,7 @@ def can_write():
503503
num_calls = 0
504504
client_sock, _ = sock_pair
505505
fut = asyncio.Future()
506-
loop.add_writer(client_sock.fileno(), can_write)
506+
loop._add_writer(client_sock.fileno(), can_write)
507507
notifier = loop._write_notifiers[client_sock.fileno()]
508508
loop.run_until_complete(asyncio.wait_for(fut, timeout=1.0))
509509

@@ -548,24 +548,24 @@ async def client_coro():
548548
def cb1():
549549
nonlocal result1
550550
assert result1 is None
551-
loop.remove_reader(c_sock.fileno())
551+
loop._remove_reader(c_sock.fileno())
552552
result1 = c_sock.recv(1)
553-
loop.add_writer(c_sock.fileno(), cb2)
553+
loop._add_writer(c_sock.fileno(), cb2)
554554

555555
def cb2():
556556
nonlocal result3
557557
assert result3 is None
558558
c_sock.send(b"2")
559-
loop.remove_writer(c_sock.fileno())
560-
loop.add_reader(c_sock.fileno(), cb3)
559+
loop._remove_writer(c_sock.fileno())
560+
loop._add_reader(c_sock.fileno(), cb3)
561561

562562
def cb3():
563563
nonlocal result3
564564
assert result3 is None
565565
result3 = c_sock.recv(1)
566566
client_done.set_result(True)
567567

568-
loop.add_reader(c_sock.fileno(), cb1)
568+
loop._add_reader(c_sock.fileno(), cb1)
569569

570570
asyncio.ensure_future(client_coro())
571571
asyncio.ensure_future(server_coro())
@@ -586,7 +586,7 @@ def test_add_reader_replace(loop, sock_pair):
586586
def any_callback():
587587
if not callback_invoked.done():
588588
callback_invoked.set_result(True)
589-
loop.remove_reader(c_sock.fileno())
589+
loop._remove_reader(c_sock.fileno())
590590

591591
def callback1():
592592
# the "bad" callback: if this gets invoked, something went wrong
@@ -606,10 +606,10 @@ async def server_coro():
606606
await s_writer.drain()
607607

608608
async def client_coro():
609-
loop.add_reader(c_sock.fileno(), callback1)
610-
loop.add_reader(c_sock.fileno(), callback2)
609+
loop._add_reader(c_sock.fileno(), callback1)
610+
loop._add_reader(c_sock.fileno(), callback2)
611611
await callback_invoked
612-
loop.remove_reader(c_sock.fileno())
612+
loop._remove_reader(c_sock.fileno())
613613
assert (await loop.sock_recv(c_sock, 3)) == b"foo"
614614

615615
client_done = asyncio.ensure_future(client_coro())
@@ -633,7 +633,7 @@ def test_add_writer_replace(loop, sock_pair):
633633
def any_callback():
634634
if not callback_invoked.done():
635635
callback_invoked.set_result(True)
636-
loop.remove_writer(c_sock.fileno())
636+
loop._remove_writer(c_sock.fileno())
637637

638638
def callback1():
639639
# the "bad" callback: if this gets invoked, something went wrong
@@ -648,10 +648,10 @@ def callback2():
648648
any_callback()
649649

650650
async def client_coro():
651-
loop.add_writer(c_sock.fileno(), callback1)
652-
loop.add_writer(c_sock.fileno(), callback2)
651+
loop._add_writer(c_sock.fileno(), callback1)
652+
loop._add_writer(c_sock.fileno(), callback2)
653653
await callback_invoked
654-
loop.remove_writer(c_sock.fileno())
654+
loop._remove_writer(c_sock.fileno())
655655

656656
loop.run_until_complete(asyncio.wait_for(client_coro(), timeout=0.1))
657657
assert not called1
@@ -664,10 +664,10 @@ def test_remove_reader_idempotence(loop, sock_pair):
664664
def cb():
665665
pass
666666

667-
removed0 = loop.remove_reader(fd)
668-
loop.add_reader(fd, cb)
669-
removed1 = loop.remove_reader(fd)
670-
removed2 = loop.remove_reader(fd)
667+
removed0 = loop._remove_reader(fd)
668+
loop._add_reader(fd, cb)
669+
removed1 = loop._remove_reader(fd)
670+
removed2 = loop._remove_reader(fd)
671671

672672
assert not removed0
673673
assert removed1
@@ -680,10 +680,10 @@ def test_remove_writer_idempotence(loop, sock_pair):
680680
def cb():
681681
pass
682682

683-
removed0 = loop.remove_writer(fd)
684-
loop.add_writer(fd, cb)
685-
removed1 = loop.remove_writer(fd)
686-
removed2 = loop.remove_writer(fd)
683+
removed0 = loop._remove_writer(fd)
684+
loop._add_writer(fd, cb)
685+
removed1 = loop._remove_writer(fd)
686+
removed2 = loop._remove_writer(fd)
687687

688688
assert not removed0
689689
assert removed1
@@ -701,12 +701,12 @@ def writer_cb(fut):
701701
fut.set_result(None)
702702

703703
def fut_cb(fut):
704-
loop.remove_writer(fd)
704+
loop._remove_writer(fd)
705705
cb_called.set_result(None)
706706

707707
fut = asyncio.Future()
708708
fut.add_done_callback(fut_cb)
709-
loop.add_writer(fd, writer_cb, fut)
709+
loop._add_writer(fd, writer_cb, fut)
710710
loop.run_until_complete(cb_called)
711711

712712

0 commit comments

Comments
 (0)