@@ -357,7 +357,7 @@ def write():
357
357
exp_num_notifiers = len (loop ._read_notifiers ) + 1
358
358
got_msg = None
359
359
fut = asyncio .Future ()
360
- loop .add_reader (srv_sock .fileno (), can_read )
360
+ loop ._add_reader (srv_sock .fileno (), can_read )
361
361
assert len (loop ._read_notifiers ) == exp_num_notifiers , "Notifier should be added"
362
362
loop .run_until_complete (asyncio .wait_for (fut , timeout = 1.0 ))
363
363
@@ -378,9 +378,9 @@ def can_read():
378
378
client_sock , srv_sock = sock_pair
379
379
380
380
got_msg = None
381
- loop .add_reader (srv_sock .fileno (), can_read )
381
+ loop ._add_reader (srv_sock .fileno (), can_read )
382
382
exp_num_notifiers = len (loop ._read_notifiers ) - 1
383
- loop .remove_reader (srv_sock .fileno ())
383
+ loop ._remove_reader (srv_sock .fileno ())
384
384
assert len (loop ._read_notifiers ) == exp_num_notifiers , "Notifier should be removed"
385
385
client_sock .send (b"a" )
386
386
client_sock .close ()
@@ -395,18 +395,18 @@ def test_remove_reader_after_closing(loop, sock_pair):
395
395
"""Verify that we can remove a reader callback from an event loop."""
396
396
client_sock , srv_sock = sock_pair
397
397
398
- loop .add_reader (srv_sock .fileno (), lambda : None )
398
+ loop ._add_reader (srv_sock .fileno (), lambda : None )
399
399
loop .close ()
400
- loop .remove_reader (srv_sock .fileno ())
400
+ loop ._remove_reader (srv_sock .fileno ())
401
401
402
402
403
403
def test_remove_writer_after_closing (loop , sock_pair ):
404
404
"""Verify that we can remove a reader callback from an event loop."""
405
405
client_sock , srv_sock = sock_pair
406
406
407
- loop .add_writer (client_sock .fileno (), lambda : None )
407
+ loop ._add_writer (client_sock .fileno (), lambda : None )
408
408
loop .close ()
409
- loop .remove_writer (client_sock .fileno ())
409
+ loop ._remove_writer (client_sock .fileno ())
410
410
411
411
412
412
def test_add_reader_after_closing (loop , sock_pair ):
@@ -415,7 +415,7 @@ def test_add_reader_after_closing(loop, sock_pair):
415
415
416
416
loop .close ()
417
417
with pytest .raises (RuntimeError ):
418
- loop .add_reader (srv_sock .fileno (), lambda : None )
418
+ loop ._add_reader (srv_sock .fileno (), lambda : None )
419
419
420
420
421
421
def test_add_writer_after_closing (loop , sock_pair ):
@@ -424,7 +424,7 @@ def test_add_writer_after_closing(loop, sock_pair):
424
424
425
425
loop .close ()
426
426
with pytest .raises (RuntimeError ):
427
- loop .add_writer (client_sock .fileno (), lambda : None )
427
+ loop ._add_writer (client_sock .fileno (), lambda : None )
428
428
429
429
430
430
def test_can_add_writer (loop , sock_pair ):
@@ -438,16 +438,16 @@ def can_write():
438
438
439
439
client_sock , _ = sock_pair
440
440
fut = asyncio .Future ()
441
- loop .add_writer (client_sock .fileno (), can_write )
441
+ loop ._add_writer (client_sock .fileno (), can_write )
442
442
assert len (loop ._write_notifiers ) == 1 , "Notifier should be added"
443
443
loop .run_until_complete (asyncio .wait_for (fut , timeout = 1.0 ))
444
444
445
445
446
446
def test_can_remove_writer (loop , sock_pair ):
447
447
"""Verify that we can remove a writer callback from an event loop."""
448
448
client_sock , _ = sock_pair
449
- loop .add_writer (client_sock .fileno (), lambda : None )
450
- loop .remove_writer (client_sock .fileno ())
449
+ loop ._add_writer (client_sock .fileno (), lambda : None )
450
+ loop ._remove_writer (client_sock .fileno ())
451
451
assert not loop ._write_notifiers , "Notifier should be removed"
452
452
453
453
@@ -478,7 +478,7 @@ def write():
478
478
loop .call_soon (write )
479
479
480
480
fut = asyncio .Future ()
481
- loop .add_reader (srv_sock .fileno (), can_read )
481
+ loop ._add_reader (srv_sock .fileno (), can_read )
482
482
notifier = loop ._read_notifiers [srv_sock .fileno ()]
483
483
loop .run_until_complete (asyncio .wait_for (fut , timeout = 1.0 ))
484
484
@@ -503,7 +503,7 @@ def can_write():
503
503
num_calls = 0
504
504
client_sock , _ = sock_pair
505
505
fut = asyncio .Future ()
506
- loop .add_writer (client_sock .fileno (), can_write )
506
+ loop ._add_writer (client_sock .fileno (), can_write )
507
507
notifier = loop ._write_notifiers [client_sock .fileno ()]
508
508
loop .run_until_complete (asyncio .wait_for (fut , timeout = 1.0 ))
509
509
@@ -548,24 +548,24 @@ async def client_coro():
548
548
def cb1 ():
549
549
nonlocal result1
550
550
assert result1 is None
551
- loop .remove_reader (c_sock .fileno ())
551
+ loop ._remove_reader (c_sock .fileno ())
552
552
result1 = c_sock .recv (1 )
553
- loop .add_writer (c_sock .fileno (), cb2 )
553
+ loop ._add_writer (c_sock .fileno (), cb2 )
554
554
555
555
def cb2 ():
556
556
nonlocal result3
557
557
assert result3 is None
558
558
c_sock .send (b"2" )
559
- loop .remove_writer (c_sock .fileno ())
560
- loop .add_reader (c_sock .fileno (), cb3 )
559
+ loop ._remove_writer (c_sock .fileno ())
560
+ loop ._add_reader (c_sock .fileno (), cb3 )
561
561
562
562
def cb3 ():
563
563
nonlocal result3
564
564
assert result3 is None
565
565
result3 = c_sock .recv (1 )
566
566
client_done .set_result (True )
567
567
568
- loop .add_reader (c_sock .fileno (), cb1 )
568
+ loop ._add_reader (c_sock .fileno (), cb1 )
569
569
570
570
asyncio .ensure_future (client_coro ())
571
571
asyncio .ensure_future (server_coro ())
@@ -586,7 +586,7 @@ def test_add_reader_replace(loop, sock_pair):
586
586
def any_callback ():
587
587
if not callback_invoked .done ():
588
588
callback_invoked .set_result (True )
589
- loop .remove_reader (c_sock .fileno ())
589
+ loop ._remove_reader (c_sock .fileno ())
590
590
591
591
def callback1 ():
592
592
# the "bad" callback: if this gets invoked, something went wrong
@@ -606,10 +606,10 @@ async def server_coro():
606
606
await s_writer .drain ()
607
607
608
608
async def client_coro ():
609
- loop .add_reader (c_sock .fileno (), callback1 )
610
- loop .add_reader (c_sock .fileno (), callback2 )
609
+ loop ._add_reader (c_sock .fileno (), callback1 )
610
+ loop ._add_reader (c_sock .fileno (), callback2 )
611
611
await callback_invoked
612
- loop .remove_reader (c_sock .fileno ())
612
+ loop ._remove_reader (c_sock .fileno ())
613
613
assert (await loop .sock_recv (c_sock , 3 )) == b"foo"
614
614
615
615
client_done = asyncio .ensure_future (client_coro ())
@@ -633,7 +633,7 @@ def test_add_writer_replace(loop, sock_pair):
633
633
def any_callback ():
634
634
if not callback_invoked .done ():
635
635
callback_invoked .set_result (True )
636
- loop .remove_writer (c_sock .fileno ())
636
+ loop ._remove_writer (c_sock .fileno ())
637
637
638
638
def callback1 ():
639
639
# the "bad" callback: if this gets invoked, something went wrong
@@ -648,10 +648,10 @@ def callback2():
648
648
any_callback ()
649
649
650
650
async def client_coro ():
651
- loop .add_writer (c_sock .fileno (), callback1 )
652
- loop .add_writer (c_sock .fileno (), callback2 )
651
+ loop ._add_writer (c_sock .fileno (), callback1 )
652
+ loop ._add_writer (c_sock .fileno (), callback2 )
653
653
await callback_invoked
654
- loop .remove_writer (c_sock .fileno ())
654
+ loop ._remove_writer (c_sock .fileno ())
655
655
656
656
loop .run_until_complete (asyncio .wait_for (client_coro (), timeout = 0.1 ))
657
657
assert not called1
@@ -664,10 +664,10 @@ def test_remove_reader_idempotence(loop, sock_pair):
664
664
def cb ():
665
665
pass
666
666
667
- removed0 = loop .remove_reader (fd )
668
- loop .add_reader (fd , cb )
669
- removed1 = loop .remove_reader (fd )
670
- removed2 = loop .remove_reader (fd )
667
+ removed0 = loop ._remove_reader (fd )
668
+ loop ._add_reader (fd , cb )
669
+ removed1 = loop ._remove_reader (fd )
670
+ removed2 = loop ._remove_reader (fd )
671
671
672
672
assert not removed0
673
673
assert removed1
@@ -680,10 +680,10 @@ def test_remove_writer_idempotence(loop, sock_pair):
680
680
def cb ():
681
681
pass
682
682
683
- removed0 = loop .remove_writer (fd )
684
- loop .add_writer (fd , cb )
685
- removed1 = loop .remove_writer (fd )
686
- removed2 = loop .remove_writer (fd )
683
+ removed0 = loop ._remove_writer (fd )
684
+ loop ._add_writer (fd , cb )
685
+ removed1 = loop ._remove_writer (fd )
686
+ removed2 = loop ._remove_writer (fd )
687
687
688
688
assert not removed0
689
689
assert removed1
@@ -701,12 +701,12 @@ def writer_cb(fut):
701
701
fut .set_result (None )
702
702
703
703
def fut_cb (fut ):
704
- loop .remove_writer (fd )
704
+ loop ._remove_writer (fd )
705
705
cb_called .set_result (None )
706
706
707
707
fut = asyncio .Future ()
708
708
fut .add_done_callback (fut_cb )
709
- loop .add_writer (fd , writer_cb , fut )
709
+ loop ._add_writer (fd , writer_cb , fut )
710
710
loop .run_until_complete (cb_called )
711
711
712
712
0 commit comments