Ignore - Accidental PR

[vgadodia]

Summary by CodeRabbit

Release Notes

• New Features

  • Workspace support: Select and set default workspaces for organizing recordings.
  • Multi-track recording: Capture screen, camera, and cursor data simultaneously in separate tracks.
  • Camera preview: Real-time camera feed display during recording setup.

• Improvements

  • Redesigned interface with new icons and horizontal settings navigation.
  • Enhanced recording controls with streamlined UI.

• Branding

  • Application renamed from Cap to Inflight across all interfaces.

• Updates

  • Added Android adaptive icon support.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This PR migrates the application from "Cap" to "Inflight" branding, introduces workspace-scoped features, implements multi-stream recording (separate display and camera uploads), and adds versioned shareable links with fallback upload strategies. It also includes substantial UI refactoring with new target selection components, a redesigned settings panel, and a camera preview component.

Changes

Cohort / File(s)	Summary
Branding & Configuration .github/workflows/publish.yml, apps/desktop/src-tauri/Cargo.toml, apps/desktop/src-tauri/tauri.conf.json, apps/desktop/src-tauri/tauri.prod.conf.json, apps/desktop/src-tauri/scripts/prodBeforeBundle.js, apps/desktop/src-tauri/tray.rs	Unified migration from "Cap" to "Inflight" across CI/CD workflow, package metadata, Tauri configuration, update server endpoints, and user-facing UI strings. CI credentials and targets updated (CN_APPLICATION, SENTRY_ORG/PROJECT). Deep-link schemes and binary names changed accordingly.
Workspace Integration – Rust Backend apps/desktop/src-tauri/src/api.rs, apps/desktop/src-tauri/src/auth.rs, apps/desktop/src-tauri/src/general_settings.rs, apps/desktop/src-tauri/src/recording_settings.rs, apps/desktop/src-tauri/src/deeplink_actions.rs	Added Workspace type and fetch_workspaces() API. Replaced organization fetch with workspace fetch in auth. Added workspace_id/default_workspace_id fields to settings stores and StartRecordingInputs. Threaded workspace context through recording initialization and storage.
Multipart Upload & Versioning – Rust Backend apps/desktop/src-tauri/src/api.rs, apps/desktop/src-tauri/src/upload.rs, crates/project/src/meta.rs	Added subpath parameter to multipart upload functions (initiate, presign_part, complete). Introduced version_id support for versioned shareable links. Extended InstantMultipartUpload and UploadMeta to carry subpath. Added fallback upload helpers (camera, cursor, screenshot).
Recording Pipeline Refactor – Rust Backend apps/desktop/src-tauri/src/recording.rs, apps/desktop/src-tauri/src/lib.rs, crates/recording/src/instant_recording.rs, crates/recording/src/output_pipeline/ffmpeg.rs	Separated display and camera uploads in InProgressRecording and CompletedRecording::Instant. Added camera feed and cursor capture pipelines with multi-track output (display.mp4, camera.mp4, cursor.json). Introduced Mp4MuxerConfig for configurable output sizing. Extended ActorBuilder with with_camera_feed() and with_custom_cursor().
Windows & UI Configuration – Rust Backend apps/desktop/src-tauri/src/windows.rs, apps/desktop/src-tauri/src/lib.rs, apps/desktop/src-tauri/app.config.timestamp_1764867563009.js, apps/desktop/src-tauri/icons/android/mipmap-anydpi-v26/ic_launcher.xml, apps/desktop/src-tauri/icons/android/values/ic_launcher_background.xml	Updated window sizes, transparency settings, traffic lights positioning for macOS. Added camera WebSocket port initialization. Added Android adaptive icon resources. Introduced app configuration module with Vite/Tauri setup.
Icon Library & Components – TypeScript apps/desktop/src/icons.tsx	Added 22 new exported icon components (DoubleArrowSwitcher, ArrowUpRight, RecordFill, LogoSquare, InflightLogo, CameraIcon, MicrophoneIcon, SystemAudioIcon, StopIcon, PlayIcon, PauseIcon, etc.) with SVG rendering and styling props.
Target Selection Components – TypeScript apps/desktop/src/routes/(window-chrome)/new-main/HorizontalTargetButton.tsx, apps/desktop/src/routes/(window-chrome)/new-main/VerticalTargetButton.tsx, apps/desktop/src/routes/(window-chrome)/new-main/index.tsx	Introduced reusable HorizontalTargetButton and VerticalTargetButton components for display/window/area selection. Added CameraPreview component with WebSocket-based real-time camera stream. Refactored target menu handling and control layout.
Recording Controls UI – TypeScript apps/desktop/src/routes/in-progress-recording.tsx	Redesigned control bar with new icons (GrabHandleIcon, PauseIcon, PlayIcon, RestartIcon, StopIcon, TrashIcon). Replaced countdown transitions with presence-driven rendering. Added input disconnection and recording failure tracking. Disabled max-recording-for-free enforcement.
Settings UI Redesign – TypeScript apps/desktop/src/routes/(window-chrome)/settings.tsx, apps/desktop/src/routes/(window-chrome)/settings/general.tsx, apps/desktop/src/routes/(window-chrome)/settings/hotkeys.tsx, apps/desktop/src/routes/(window-chrome)/settings/recordings.tsx	Converted left vertical navigation to horizontal tab bar with animated indicator. Added workspace selection dropdown tied to authentication. Integrated account sign-in/out flow. Refactored hotkey display styling. Updated recording item actions (replaced Open link tooltip with View button).
Window Chrome & Layout – TypeScript apps/desktop/src/routes/(window-chrome).tsx, apps/desktop/src/routes/(window-chrome)/(main).tsx, apps/desktop/src/routes/(window-chrome)/new-main/CameraSelect.tsx, apps/desktop/src/routes/(window-chrome)/new-main/MicrophoneSelect.tsx, apps/desktop/src/routes/(window-chrome)/new-main/SystemAudio.tsx, apps/desktop/src/routes/(window-chrome)/setup.tsx	Refactored header rendering with settings-aware padding. Updated InfoPill component to support "on"/"off" variants. Replaced camera/microphone icon indicators with CameraIcon/MicrophoneIcon and hover-visible chevrons. Redesigned setup screen with welcome illustration and two-column layout. Updated all permission UI and descriptive text.
Upload & Export Flow – TypeScript apps/desktop/src/routes/editor/ExportDialog.tsx, apps/desktop/src/routes/editor/ShareButton.tsx, apps/desktop/src/routes/in-progress-recording.tsx, apps/desktop/src/routes/recordings-overlay.tsx, apps/desktop/src/routes/target-select-overlay.tsx	Added workspaceId propagation through export/upload calls. Updated recording name from "Cap Recording" to "Inflight Recording". Added workspace-aware options initialization via createWorkspacesQuery(). Adjusted upload invocations to pass additional workspace/version context.
Type Definitions & Query Utilities – TypeScript apps/desktop/src/utils/tauri.ts, apps/desktop/src/utils/queries.ts	Extended type signatures: uploadExportedVideo() now accepts workspaceId, RecordingSettingsStore includes workspaceId, StartRecordingInputs includes workspace_id, S3UploadMeta includes version_id. Added Workspace type export. Changed default recording mode from "studio" to "instant". Added createWorkspacesQuery() to fetch and manage workspaces.
Planning Document FLYOVER_FEATURE_PLAN.md	Added comprehensive Flyover Camera Feature Architecture document detailing multi-track recording/playback, GPU-based compositing, camera-follow positioning, cursor synchronization, editor UI, database schema, implementation timeline, risk mitigations, and success metrics.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Desktop App
    participant Tauri Backend
    participant Server API
    participant S3 Storage

    User->>Desktop App: Select workspace & start recording (display + camera)
    activate Desktop App
    Desktop App->>Tauri Backend: spawn_instant_recording_actor(workspace_id, camera_feed)
    deactivate Desktop App
    activate Tauri Backend
    Tauri Backend->>Tauri Backend: Create display_upload & camera_upload (InstantMultipartUpload)
    Tauri Backend->>Tauri Backend: Create CursorPipeline
    rect rgb(200, 220, 255)
        Note over Tauri Backend: Recording in progress
        Tauri Backend->>Tauri Backend: Capture display.mp4, camera.mp4, cursor.json
    end
    User->>Desktop App: Stop recording
    Desktop App->>Tauri Backend: handle_recording_finish()
    deactivate Tauri Backend
    activate Tauri Backend
    Tauri Backend->>Server API: create_or_get_video(workspace_id, has_camera=true)
    Server API-->>Tauri Backend: VideoUploadInfo {version_id, video_id}
    rect rgb(255, 220, 200)
        Note over Tauri Backend: Multipart upload (display)
        Tauri Backend->>Server API: upload_multipart_initiate(video_id, subpath="display.mp4")
        Server API-->>Tauri Backend: upload_id
        loop for each part
            Tauri Backend->>Server API: upload_multipart_presign_part(subpath, part_number)
            Server API-->>Tauri Backend: presigned_url
            Tauri Backend->>S3 Storage: PUT display chunk
        end
        Tauri Backend->>Server API: upload_multipart_complete(subpath, parts)
    end
    rect rgb(200, 255, 220)
        Note over Tauri Backend: Multipart upload (camera)
        Tauri Backend->>Server API: upload_multipart_initiate(video_id, subpath="camera.mp4")
        Tauri Backend->>Server API: upload_multipart_presign_part(subpath, part_number)
        Tauri Backend->>S3 Storage: PUT camera chunk
        Tauri Backend->>Server API: upload_multipart_complete(subpath, parts)
    end
    Tauri Backend->>Server API: Upload cursor.json
    Tauri Backend-->>Desktop App: UploadResult {link: /v/{version_id}}
    deactivate Tauri Backend
    Desktop App-->>User: Share link

Loading

sequenceDiagram
    participant User
    participant Desktop App
    participant Tauri Backend
    participant Server API
    participant Auth Store

    User->>Desktop App: Launch app
    activate Desktop App
    Desktop App->>Tauri Backend: check_upgraded_and_update()
    activate Tauri Backend
    Tauri Backend->>Server API: fetch_workspaces()
    Server API-->>Tauri Backend: [Workspace {id, name, avatar_url}]
    Tauri Backend->>Auth Store: Update auth.workspaces
    Tauri Backend-->>Desktop App: AuthStore (with workspaces)
    deactivate Tauri Backend
    Desktop App->>Desktop App: createWorkspacesQuery() initializes workspace list
    User->>Desktop App: Open Settings → General
    Desktop App->>Desktop App: Render workspace selector (from auth.workspaces)
    User->>Desktop App: Select default workspace
    Desktop App->>Desktop App: Update defaultWorkspaceId in settings
    User->>Desktop App: Start recording
    Desktop App->>Tauri Backend: start_recording(workspace_id from settings)
    deactivate Desktop App
    activate Tauri Backend
    Tauri Backend->>Server API: create_or_get_video(workspace_id, has_camera)
    Server API-->>Tauri Backend: VideoUploadInfo {version_id}
    Tauri Backend-->>Desktop App: RecordingHandle with workspace context
    deactivate Tauri Backend

Loading

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~120 minutes

Areas requiring extra attention:

• Workspace propagation pipeline: Verify workspace_id flows correctly through all entry points (recording start, upload initiation, settings persistence, auth state). Cross-check auth.rs, recording.rs, lib.rs, upload.rs, and tauri.ts for consistency.
• Multi-stream recording lifecycle: Validate display_upload and camera_upload coordination in CompletedRecording::Instant finish/abort/cleanup paths. Ensure both uploads are properly awaited and error-handled in handle_recording_finish() and cancellation scenarios.
• Multipart upload subpath wiring: Confirm subpath parameter is threaded consistently through upload_multipart_initiate, presign_part, and complete calls. Verify fallback upload helpers (upload_camera_fallback, upload_cursor_file) use correct subpath values.
• Version ID link generation: Check that versioned links (/v/{version_id}) are correctly generated and fallback to /s/{video_id} when version_id is absent across all upload code paths.
• Branding/naming consistency: Verify all user-facing strings have been updated from "Cap" to "Inflight" (CI workflow, UI copy, tray menu, window titles, update messages). Spot-check for any missed occurrences.
• Icon component exports: Validate all 22 new icon components in icons.tsx are correctly exported and have proper prop typing ({ class: string } vs. { class?: string }).
• CameraPreview WebSocket integration: Review WebSocket setup, frame handling, reconnection logic, and canvas cleanup in the new CameraPreview component within new-main/index.tsx.
• Settings tab bar UX: Verify the horizontal tab indicator positioning/animation works correctly with the new tab structure and that all navigation links are properly wired.
• Recording pipeline MP4 config: Confirm Mp4MuxerConfig with output_size and bpp is correctly applied during camera pipeline setup in instant_recording.rs.

Possibly related PRs

• Cap#937: Replaces AudioInputFeed with MicrophoneFeed / MicrophoneFeedLock API — directly overlaps with recording pipeline actor-based feed changes.
• Cap#1185: Adds organization-scoped features — parallel structure to the workspace-scoping implemented in this PR; shares upload/settings/auth plumbing patterns.
• Cap#964: Implements free 5-minute recording limit — this PR disables that enforcement, making them inverse-related in in-progress-recording.tsx.

Suggested labels

codex, feature, refactor, ui

Suggested reviewers

• oscartbeaumont
• Brendonovich

Poem

🐰 Hops with glee across the codebase wide,
Workspaces sprouted, streams multiplied!
From Cap to Inflight, the journey's set,
Multi-track recordings—our finest bet.
With versioned links and camera feeds so bright,
This rabbit's refactor takes flight! 🚀

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eed3f76 and 3c86bc3.

⛔ Files ignored due to path filters (54)

• Cargo.lock is excluded by !**/*.lock
• app-icon.png is excluded by !**/*.png
• apps/desktop/src-tauri/assets/dmg-background.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/128x128.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/[email protected] is excluded by !**/*.png
• apps/desktop/src-tauri/icons/32x32.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/64x64.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/Square107x107Logo.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/Square142x142Logo.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/Square150x150Logo.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/Square284x284Logo.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/Square30x30Logo.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/Square310x310Logo.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/Square44x44Logo.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/Square71x71Logo.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/Square89x89Logo.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/StoreLogo.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/android/mipmap-hdpi/ic_launcher.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/android/mipmap-hdpi/ic_launcher_foreground.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/android/mipmap-hdpi/ic_launcher_round.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/android/mipmap-mdpi/ic_launcher.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/android/mipmap-mdpi/ic_launcher_foreground.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/android/mipmap-mdpi/ic_launcher_round.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/android/mipmap-xhdpi/ic_launcher.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/android/mipmap-xhdpi/ic_launcher_foreground.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/android/mipmap-xhdpi/ic_launcher_round.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/android/mipmap-xxhdpi/ic_launcher.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/android/mipmap-xxhdpi/ic_launcher_foreground.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/android/mipmap-xxhdpi/ic_launcher_round.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/android/mipmap-xxxhdpi/ic_launcher.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/android/mipmap-xxxhdpi/ic_launcher_foreground.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/android/mipmap-xxxhdpi/ic_launcher_round.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/icon.ico is excluded by !**/*.ico
• apps/desktop/src-tauri/icons/icon.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/ios/[email protected] is excluded by !**/*.png
• apps/desktop/src-tauri/icons/ios/[email protected] is excluded by !**/*.png
• apps/desktop/src-tauri/icons/ios/[email protected] is excluded by !**/*.png
• apps/desktop/src-tauri/icons/ios/[email protected] is excluded by !**/*.png
• apps/desktop/src-tauri/icons/ios/[email protected] is excluded by !**/*.png
• apps/desktop/src-tauri/icons/ios/[email protected] is excluded by !**/*.png
• apps/desktop/src-tauri/icons/ios/[email protected] is excluded by !**/*.png
• apps/desktop/src-tauri/icons/ios/[email protected] is excluded by !**/*.png
• apps/desktop/src-tauri/icons/ios/[email protected] is excluded by !**/*.png
• apps/desktop/src-tauri/icons/ios/[email protected] is excluded by !**/*.png
• apps/desktop/src-tauri/icons/ios/[email protected] is excluded by !**/*.png
• apps/desktop/src-tauri/icons/ios/[email protected] is excluded by !**/*.png
• apps/desktop/src-tauri/icons/ios/[email protected] is excluded by !**/*.png
• apps/desktop/src-tauri/icons/ios/[email protected] is excluded by !**/*.png
• apps/desktop/src-tauri/icons/ios/[email protected] is excluded by !**/*.png
• apps/desktop/src-tauri/icons/ios/[email protected] is excluded by !**/*.png
• apps/desktop/src-tauri/icons/ios/[email protected] is excluded by !**/*.png
• apps/desktop/src-tauri/icons/ios/[email protected] is excluded by !**/*.png
• apps/desktop/src-tauri/icons/macos/icon.png is excluded by !**/*.png
• apps/desktop/src-tauri/icons/tray-default-icon.png is excluded by !**/*.png

📒 Files selected for processing (46)

• .github/workflows/publish.yml (3 hunks)
• FLYOVER_FEATURE_PLAN.md (1 hunks)
• apps/desktop/app.config.timestamp_1764867563009.js (1 hunks)
• apps/desktop/scripts/prodBeforeBundle.js (2 hunks)
• apps/desktop/src-tauri/Cargo.toml (1 hunks)
• apps/desktop/src-tauri/icons/android/mipmap-anydpi-v26/ic_launcher.xml (1 hunks)
• apps/desktop/src-tauri/icons/android/values/ic_launcher_background.xml (1 hunks)
• apps/desktop/src-tauri/src/api.rs (8 hunks)
• apps/desktop/src-tauri/src/auth.rs (3 hunks)
• apps/desktop/src-tauri/src/deeplink_actions.rs (1 hunks)
• apps/desktop/src-tauri/src/general_settings.rs (2 hunks)
• apps/desktop/src-tauri/src/lib.rs (9 hunks)
• apps/desktop/src-tauri/src/recording.rs (16 hunks)
• apps/desktop/src-tauri/src/recording_settings.rs (1 hunks)
• apps/desktop/src-tauri/src/tray.rs (1 hunks)
• apps/desktop/src-tauri/src/upload.rs (17 hunks)
• apps/desktop/src-tauri/src/windows.rs (7 hunks)
• apps/desktop/src-tauri/tauri.conf.json (2 hunks)
• apps/desktop/src-tauri/tauri.prod.conf.json (1 hunks)
• apps/desktop/src/icons.tsx (1 hunks)
• apps/desktop/src/routes/(window-chrome).tsx (4 hunks)
• apps/desktop/src/routes/(window-chrome)/(main).tsx (33 hunks)
• apps/desktop/src/routes/(window-chrome)/new-main/CameraSelect.tsx (6 hunks)
• apps/desktop/src/routes/(window-chrome)/new-main/HorizontalTargetButton.tsx (1 hunks)
• apps/desktop/src/routes/(window-chrome)/new-main/InfoPill.tsx (1 hunks)
• apps/desktop/src/routes/(window-chrome)/new-main/MicrophoneSelect.tsx (8 hunks)
• apps/desktop/src/routes/(window-chrome)/new-main/SystemAudio.tsx (2 hunks)
• apps/desktop/src/routes/(window-chrome)/new-main/VerticalTargetButton.tsx (1 hunks)
• apps/desktop/src/routes/(window-chrome)/new-main/index.tsx (25 hunks)
• apps/desktop/src/routes/(window-chrome)/settings.tsx (2 hunks)
• apps/desktop/src/routes/(window-chrome)/settings/general.tsx (18 hunks)
• apps/desktop/src/routes/(window-chrome)/settings/hotkeys.tsx (3 hunks)
• apps/desktop/src/routes/(window-chrome)/settings/recordings.tsx (8 hunks)
• apps/desktop/src/routes/(window-chrome)/setup.tsx (12 hunks)
• apps/desktop/src/routes/(window-chrome)/update.tsx (1 hunks)
• apps/desktop/src/routes/(window-chrome)/upgrade.tsx (4 hunks)
• apps/desktop/src/routes/editor/ExportDialog.tsx (39 hunks)
• apps/desktop/src/routes/editor/ShareButton.tsx (2 hunks)
• apps/desktop/src/routes/in-progress-recording.tsx (16 hunks)
• apps/desktop/src/routes/recordings-overlay.tsx (2 hunks)
• apps/desktop/src/routes/target-select-overlay.tsx (26 hunks)
• apps/desktop/src/utils/queries.ts (3 hunks)
• apps/desktop/src/utils/tauri.ts (7 hunks)
• crates/project/src/meta.rs (2 hunks)
• crates/recording/src/instant_recording.rs (14 hunks)
• crates/recording/src/output_pipeline/ffmpeg.rs (2 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[vgadodia]

Sorry, Idk why it keeps defaulting the PR to the upstream main 🤦‍♂️