is it possible to add custom buttons to some specified paths instead make them visible for every path?

[allenling]

i want to say add an import from file button to the root, or a reset button to some path, can i do that?

[allenling]

and also i am wondering why there's no renaming event? i mean yes we can iterate over currentValue and check if a key is in the newValue to tell if user has changed the name of a key, but since we do allow user to double click on a key name to modify the name, then i guess it's a trivial to say emit a rename event

[CarlosNZ]

Do you mean a callback specifically for key renaming, like onEdit, onDelete, etc?

Yeah, I guess that would be easy enough to emit one, but I'm not totally convinced it's necessary, given that you can tell the difference using the technique you describe (just make a little helper utility I guess), and also that renaming a property is effectively the same as a normal "edit" on the parent node.

The main reason not to do it now though is for backwards compatibility. If I changed this, then any implementations relying on onEdit callbacks for rename events would quietly break, so it'd be a major version update.

I'll definitely put it on my V2.0 laundry list though: #198

[allenling]

and in terms of backwards compatibility, IMHO, maybe we could make it a new feature, like just add a callback like onRename or whatever, and leave that oneEdit unchanged, so if you want to use that onRename, do it, or you can just totally ignore it, your code replied on onEdit still works because nothing's changed in onEdit.

and it's excited to see that you put it on your V2.0 list!

[allenling]

and about you said quote that renaming a property is effectively the same as a normal "edit" on the parent node. quote.

yes, and we can detect renaming by comparing the keys in currentValue and newValue, and in most cases, people won't have a big json, and iterating over an object is not a big deal.

but this might feel a bit "inconsistent" in design, becase we are using event driven or callback mechanism, like when update/addition/deletion happens, framework will notify you and you can do something in the callback function, but we have to detect key renaming ourselves.

but that’s just my opinion.

[CarlosNZ]

i want to say add an import from file button to the root, or a reset button to some path, can i do that?

I actually already made an issue a while back to do this: #149

But I also said:

I probably won't do this until someone specifically asks for it -- so if you would like this, please let me know

So I guess you're asking! Okay, I'll add it to the to-do board, should be pretty simple.

[allenling]

yes since i am not a frontend expert, i found that building some kind of widget to allow people to modify kv values in some configuration file feels hassle, and i think a flexible json editor like json-edit-react is really awesome!