fix(permissions): fixed permissions bug (#495)

Author: nsemets

src/app/core/components/nav-menu/nav-menu.component.ts

@@ -65,6 +65,7 @@ export class NavMenuComponent {
       isCollections: this.isCollectionsRoute() || false,
       currentUrl: this.router.url,
       isViewOnly: !!getViewOnlyParam(this.router),
+      permissions: this.currentResource()?.permissions,
     };
 
     const items = updateMenuItems(filtered, routeContext);

src/app/core/helpers/nav-menu.helper.ts

@@ -94,14 +94,21 @@ function updateProjectMenuItem(item: MenuItem, ctx: RouteContext): MenuItem {
         }
 
         menuItems = menuItems.map((menuItem) => {
-          if (menuItem.id !== 'project-wiki') {
-            return menuItem;
+          if (menuItem.id === 'project-wiki') {
+            return {
+              ...menuItem,
+              visible: ctx.wikiPageVisible,
+            };
           }
 
-          return {
-            ...menuItem,
-            visible: ctx.wikiPageVisible,
-          };
+          if (menuItem.id === 'project-contributors' || menuItem.id === 'project-settings') {
+            return {
+              ...menuItem,
+              visible: !!ctx.permissions?.length,
+            };
+          }
+
+          return menuItem;
         });
 
         return {
@@ -139,11 +146,20 @@ function updateRegistryMenuItem(item: MenuItem, ctx: RouteContext): MenuItem {
           ...subItem,
           visible: true,
           expanded: true,
-          items: menuItems.map((menuItem) => ({
-            ...menuItem,
-            routerLink: [ctx.resourceId as string, menuItem.routerLink],
-            queryParams: ctx.isViewOnly ? { view_only: getViewOnlyParamFromUrl(ctx.currentUrl) } : undefined,
-          })),
+          items: menuItems.map((menuItem) => {
+            if (menuItem.id === 'registration-contributors') {
+              return {
+                ...menuItem,
+                visible: !!ctx.permissions?.length,
+              };
+            }
+
+            return {
+              ...menuItem,
+              routerLink: [ctx.resourceId as string, menuItem.routerLink],
+              queryParams: ctx.isViewOnly ? { view_only: getViewOnlyParamFromUrl(ctx.currentUrl) } : undefined,
+            };
+          }),
         };
       }
       return { ...subItem, visible: false, expanded: false };

src/app/core/models/route-context.model.ts

@@ -1,3 +1,5 @@
+import { UserPermissions } from '@osf/shared/enums';
+
 export interface RouteContext {
   resourceId: string | undefined;
   providerId?: string;
@@ -11,4 +13,5 @@ export interface RouteContext {
   isCollections: boolean;
   currentUrl?: string;
   isViewOnly?: boolean;
+  permissions?: UserPermissions[];
 }

src/app/shared/models/current-resource.model.ts

@@ -1,7 +1,10 @@
+import { UserPermissions } from '../enums';
+
 export interface CurrentResource {
   id: string;
   type: string;
   parentId?: string;
   parentType?: string;
   wikiEnabled?: boolean;
+  permissions: UserPermissions[];
 }

src/app/shared/models/guid-response-json-api.model.ts

@@ -1,3 +1,5 @@
+import { UserPermissions } from '../enums';
+
 import { JsonApiResponse } from './common';
 
 export type GuidedResponseJsonApi = JsonApiResponse<GuidDataJsonApi, null>;
@@ -8,6 +10,7 @@ interface GuidDataJsonApi {
   attributes: {
     guid: string;
     wiki_enabled: boolean;
+    permissions: UserPermissions[];
   };
   relationships: {
     target?: {

src/app/shared/services/resource.service.ts

@@ -56,6 +56,7 @@ export class ResourceGuidService {
                 ? res.data.relationships.provider?.data.type
                 : res.data.relationships.target?.data.type,
             wikiEnabled: res.data.attributes.wiki_enabled,
+            permissions: res.data.attributes.permissions,
           }) as CurrentResource
       ),
       finalize(() => this.loaderService.hide())

src/app/shared/stores/current-resource/current-resource.state.ts

@@ -19,7 +19,7 @@ export class CurrentResourceState {
   private resourceService = inject(ResourceGuidService);
 
   @Action(GetResource)
-  getResourceType(ctx: StateContext<CurrentResourceStateModel>, action: GetResource) {
+  getResource(ctx: StateContext<CurrentResourceStateModel>, action: GetResource) {
     const state = ctx.getState();
 
     if (state.currentResource.data?.id === action.resourceId && !action.refresh) {