diff --git a/src/app/features/registry/components/registry-make-decision/registry-make-decision.component.html b/src/app/features/registry/components/registry-make-decision/registry-make-decision.component.html index 16f01a635..8b4e8c8c0 100644 --- a/src/app/features/registry/components/registry-make-decision/registry-make-decision.component.html +++ b/src/app/features/registry/components/registry-make-decision/registry-make-decision.component.html @@ -8,6 +8,9 @@ @case (SubmissionReviewStatus.Accepted) { {{ 'moderation.submissionReview.accepted' | translate }} } + @case (SubmissionReviewStatus.PendingWithdrawal) { + {{ 'moderation.submissionReview.withdrawalRequested' | translate }} + } } {{ action.dateModified | dateAgo }} {{ 'moderation.submissionReview.by' | translate }} @@ -20,20 +23,21 @@ }
- @if (isPendingModeration || isPendingReview) { + @if (isPendingModeration || isPendingReview || isPendingWithdrawal) {
} @else {
- @if (!schemaResponse()?.isOriginalResponse && !isInitialState) { + @if (schemaResponse() && !schemaResponse()?.isOriginalResponse && !isInitialState) {
diff --git a/src/app/features/registry/pages/registry-overview/registry-overview.component.ts b/src/app/features/registry/pages/registry-overview/registry-overview.component.ts index 91ecceea7..0ca7f2890 100644 --- a/src/app/features/registry/pages/registry-overview/registry-overview.component.ts +++ b/src/app/features/registry/pages/registry-overview/registry-overview.component.ts @@ -121,14 +121,14 @@ export class RegistryOverviewComponent { readonly schemaResponse = computed(() => { const registry = this.registry(); const index = this.selectedRevisionIndex(); - this.revisionInProgress = registry?.schemaResponses.find( + this.revisionInProgress = registry?.schemaResponses?.find( (r) => r.reviewsState === RevisionReviewStates.RevisionInProgress ); const schemaResponses = (this.isModeration ? registry?.schemaResponses - : registry?.schemaResponses.filter( + : registry?.schemaResponses?.filter( (r) => r.reviewsState === RevisionReviewStates.Approved || this.hasAdminAccess() )) || []; diff --git a/src/app/shared/mappers/identifiers.mapper.ts b/src/app/shared/mappers/identifiers.mapper.ts index 84cac2704..3ef7c7c11 100644 --- a/src/app/shared/mappers/identifiers.mapper.ts +++ b/src/app/shared/mappers/identifiers.mapper.ts @@ -2,7 +2,7 @@ import { Identifier, IdentifiersJsonApiData, ResponseJsonApi } from '@shared/mod export class IdentifiersMapper { static fromJsonApi(response: ResponseJsonApi): Identifier[] { - return response.data.map((rawIdentifier) => { + return response?.data.map((rawIdentifier) => { return { category: rawIdentifier.attributes.category, value: rawIdentifier.attributes.value, diff --git a/src/assets/i18n/en.json b/src/assets/i18n/en.json index 5197e6a0d..0f86ade19 100644 --- a/src/assets/i18n/en.json +++ b/src/assets/i18n/en.json @@ -20,6 +20,7 @@ "confirm": "Confirm", "disconnect": "Disconnect", "revert": "Revert", + "next": "Next", "back": "Back", "continue": "Continue", @@ -1355,6 +1356,8 @@ "rejectRequest": "Reject request", "acceptUpdate": "Accept update", "rejectUpdate": "Reject update", + "acceptWithdrawal": "Accept withdrawal", + "rejectWithdrawal": "Reject withdrawal", "withdrawRequest": "Withdraw Request", "forceWithdraw": "Force Withdraw", "forceWithdrawMessage": "Registration will be withdrawn but still have a tombstone page with a justification for withdrawal and a subset of the metadata available", @@ -1362,6 +1365,8 @@ "rejectRequestMessage": "Submission will not appear in search results nor will be associated with the collection.", "acceptUpdateMessage": "Update will be accepted and registration will be updated", "rejectUpdateMessage": "Update will be rejected and registration will remain unchanged", + "acceptWithdrawalMessage": "Registration will be withdrawn but still have a tombstone page with a justification for withdrawal and subset of the metadata available.", + "rejectWithdrawalMessage": "Submission will remain fully public", "withdrawRequestMessage": "Submission will be withdrawn from the collection and will no longer appear in search results.", "remarksPlaceholder": "Add remarks to registration admins (optional)", "submitDecision": "Submit decision", @@ -1381,7 +1386,8 @@ "requested": "Requested", "withdrawn": "Withdrawn", "by": "by", - "embargoEnding": "with embargo ending" + "embargoEnding": "with embargo ending", + "withdrawalRequested": "Registration withdrawal requested" }, "preprintReviewStatus": { "submitted": "submitted a preprint \"{{name}}\" to",