Merge branch 'feature/open-pdf-links-in-new-tab' into develop

felliott · felliott · commit 9e9fc26af95f · 2017-11-13T22:49:26.000-05:00
[SVCS-423] Closes: #273
diff --git a/mfr/extensions/pdf/templates/viewer.mako b/mfr/extensions/pdf/templates/viewer.mako
@@ -19,7 +19,7 @@ http://sourceforge.net/adobe/cmap/wiki/License/
 -->
 <html dir="ltr" mozdisallowselectionprint moznomarginboxes>
   <head>
-    <base href="${base}/web/">
+    <base href="${base}/web/" target="_blank">
     <meta charset="utf-8">
     <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1">
     <meta name="google" content="notranslate">
diff --git a/mfr/server/static/js/mfr.js b/mfr/server/static/js/mfr.js
@@ -80,7 +80,7 @@
             self.pymParent.iframe.setAttribute('allowfullscreen', '');
             self.pymParent.iframe.setAttribute('webkitallowfullscreen', '');
             self.pymParent.iframe.setAttribute('scrolling', 'yes');
-            self.pymParent.iframe.setAttribute('sandbox', 'allow-scripts');
+            self.pymParent.iframe.setAttribute('sandbox', 'allow-scripts allow-popups');
 
             self.pymParent.el.appendChild(self.spinner);
             $(self.pymParent.iframe).on('load', function () {
diff --git a/tests/extensions/pdf/test_renderer.py b/tests/extensions/pdf/test_renderer.py
@@ -39,6 +39,6 @@ class TestPdfRenderer:
 
     def test_render_pdf(self, renderer, metadata, assets_url):
         body = renderer.render()
-        assert '<base href="{}/{}/web/">'.format(assets_url, 'pdf') in body
+        assert '<base href="{}/{}/web/" target="_blank">'.format(assets_url, 'pdf') in body
         assert '<div id="viewer" class="pdfViewer"></div>' in body
         assert 'DEFAULT_URL = \'{}\''.format(metadata.download_url) in body
